From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91258 invoked by alias); 2 Dec 2015 17:58:40 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 91248 invoked by uid 89); 2 Dec 2015 17:58:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: fencepost.gnu.org Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (208.118.235.10) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 02 Dec 2015 17:58:38 +0000 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54342) by fencepost.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1a4Bfn-0005MQ-Mo for gcc-patches@gnu.org; Wed, 02 Dec 2015 12:58:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a4Bfj-0007z2-Dr for gcc-patches@gnu.org; Wed, 02 Dec 2015 12:58:35 -0500 Received: from relay1.mentorg.com ([192.94.38.131]:63576) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4Bfj-0007ye-6d for gcc-patches@gnu.org; Wed, 02 Dec 2015 12:58:31 -0500 Received: from svr-orw-fem-06.mgc.mentorg.com ([147.34.97.120]) by relay1.mentorg.com with esmtp id 1a4Bfg-0006Me-Ft from Thomas_Schwinge@mentor.com ; Wed, 02 Dec 2015 09:58:28 -0800 Received: from tftp-cs (147.34.91.1) by SVR-ORW-FEM-06.mgc.mentorg.com (147.34.97.120) with Microsoft SMTP Server id 14.3.224.2; Wed, 2 Dec 2015 09:58:28 -0800 Received: by tftp-cs (Postfix, from userid 49978) id 8EE7BC2319; Wed, 2 Dec 2015 09:58:27 -0800 (PST) From: Thomas Schwinge To: Tom de Vries CC: Jakub Jelinek , "gcc-patches@gnu.org" , Richard Biener Subject: Re: [PATCH] Handle BUILT_IN_GOACC_PARALLEL in ipa-pta In-Reply-To: <565DADE6.8020908@mentor.com> References: <565C0F47.5020604@mentor.com> <565C3CEC.9040209@mentor.com> <565C7B09.6000206@mentor.com> <565DADE6.8020908@mentor.com> User-Agent: Notmuch/0.9-125-g4686d11 (http://notmuchmail.org) Emacs/24.5.1 (i586-pc-linux-gnu) Date: Wed, 02 Dec 2015 17:58:00 -0000 Message-ID: <87zixsloli.fsf@kepler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: Windows NT kernel [generic] [fuzzy] X-Received-From: 192.94.38.131 X-SW-Source: 2015-12/txt/msg00330.txt.bz2 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-length: 3812 Hi! On Tue, 1 Dec 2015 15:25:42 +0100, Tom de Vries wr= ote: > Handle BUILT_IN_GOACC_PARALLEL in ipa-pta > * c-c++-common/goacc/kernels-alias-ipa-pta-2.c: New test. > * c-c++-common/goacc/kernels-alias-ipa-pta-3.c: New test. > * c-c++-common/goacc/kernels-alias-ipa-pta.c: New test. I see: PASS: c-c++-common/goacc/kernels-alias-ipa-pta-2.c (test for excess err= ors) FAIL: c-c++-common/goacc/kernels-alias-ipa-pta-2.c scan-tree-dump-times= optimized "(?n)=3D 0;$" 2 PASS: c-c++-common/goacc/kernels-alias-ipa-pta-2.c scan-tree-dump-times= optimized "(?n)=3D 1;$" 1 FAIL: c-c++-common/goacc/kernels-alias-ipa-pta-2.c scan-tree-dump-times= optimized "(?n)=3D \\*a" 0 PASS: c-c++-common/goacc/kernels-alias-ipa-pta-3.c (test for excess err= ors) PASS: c-c++-common/goacc/kernels-alias-ipa-pta-3.c scan-tree-dump-times= optimized "(?n)=3D 0;$" 1 PASS: c-c++-common/goacc/kernels-alias-ipa-pta-3.c scan-tree-dump-times= optimized "(?n)=3D 1;$" 1 PASS: c-c++-common/goacc/kernels-alias-ipa-pta-3.c scan-tree-dump-times= optimized "(?n)=3D \\*a" 1 PASS: c-c++-common/goacc/kernels-alias-ipa-pta.c (test for excess error= s) FAIL: c-c++-common/goacc/kernels-alias-ipa-pta.c scan-tree-dump-times o= ptimized "(?n)=3D 0;$" 2 PASS: c-c++-common/goacc/kernels-alias-ipa-pta.c scan-tree-dump-times o= ptimized "(?n)=3D 1;$" 1 FAIL: c-c++-common/goacc/kernels-alias-ipa-pta.c scan-tree-dump-times o= ptimized "(?n)=3D \\*_[0-9]\\[0\\];$" 0 ..., and similar for C++. Looking at c-c++-common/goacc/kernels-alias-ipa-pta.c: > --- /dev/null > +++ b/gcc/testsuite/c-c++-common/goacc/kernels-alias-ipa-pta.c > @@ -0,0 +1,23 @@ > +/* { dg-additional-options "-O2" } */ > +/* { dg-additional-options "-fipa-pta -fdump-tree-optimized" } */ > + > +#define N 2 > + > +void > +foo (void) > +{ > + unsigned int a[N]; > + unsigned int b[N]; > + unsigned int c[N]; > + > +#pragma acc kernels pcopyout (a, b, c) > + { > + a[0] =3D 0; > + b[0] =3D 1; > + c[0] =3D a[0]; > + } > +} > + > +/* { dg-final { scan-tree-dump-times "(?n)=3D 0;$" 2 "optimized" } } */ > +/* { dg-final { scan-tree-dump-times "(?n)=3D 1;$" 1 "optimized" } } */ > +/* { dg-final { scan-tree-dump-times "(?n)=3D \\*_\[0-9\]\\\[0\\\];$" 0 = "optimized" } } */ ..., manually running that one for C, I get: ;; Function foo._omp_fn.0 (foo._omp_fn.0, funcdef_no=3D1, decl_uid=3D18= 74, cgraph_uid=3D1, symbol_order=3D1) =20=20=20=20 __attribute__((oacc function (1, 1, 1), omp target entrypoint)) foo._omp_fn.0 (const struct .omp_data_t.0 & restrict .omp_data_i) { unsigned int[2] * _3; unsigned int[2] * _5; unsigned int _7; unsigned int[2] * _8; =20=20=20=20 : _3 =3D *.omp_data_i_2(D).a; *_3[0] =3D 0; _5 =3D *.omp_data_i_2(D).b; *_5[0] =3D 1; _7 =3D *_3[0]; _8 =3D *.omp_data_i_2(D).c; *_8[0] =3D _7; return; =20=20=20=20 } =20=20=20=20 =20=20=20=20 =20=20=20=20 ;; Function foo (foo, funcdef_no=3D0, decl_uid=3D1866, cgraph_uid=3D0, = symbol_order=3D0) =20=20=20=20 foo () { unsigned int c[2]; unsigned int b[2]; unsigned int a[2]; struct .omp_data_t.0 .omp_data_arr.1; static long unsigned int .omp_data_sizes.2[3] =3D {8, 8, 8}; static short unsigned int .omp_data_kinds.3[3] =3D {514, 514, 514}; =20=20=20=20 : .omp_data_arr.1.c =3D &c; .omp_data_arr.1.b =3D &b; .omp_data_arr.1.a =3D &a; GOACC_parallel_keyed (-1, foo._omp_fn.0, 3, &.omp_data_arr.1, &.omp_d= ata_sizes.2, &.omp_data_kinds.3, 0); .omp_data_arr.1 =3D{v} {CLOBBER}; a =3D{v} {CLOBBER}; b =3D{v} {CLOBBER}; c =3D{v} {CLOBBER}; return; =20=20=20=20 } Gr=C3=BC=C3=9Fe Thomas --=-=-= Content-Type: application/pgp-signature; name="signature.asc" Content-length: 472 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJWXzE5AAoJEK3/DN1sMFFtu/oH/RiytC/T4F72vrrlFjlCZ3Cf MlS9RM43BJ33CDCd1kTA0ZQdlYy+hPfJdQB4imAHNZzAk6gTLnmC118c1JJxFFJY W+4VzdKttRc/n9oF/jHVGf1QajwgyVPxOrX3LNFJZlmIHlwRQKcVky/a7Z3z1UV2 VqPzEpcC39DbvY211GQL5y44ZNNMnXQcBjr8HzG4nS7+Expbw08IMXN5SdWhPbOb Ob9bGLRLNqeYQJjQRAhRHtqv1GifmDMGhGtPYbBwkTR7t8jdl9kGgXY9xBrn+KLC MNwY1fwmEiD93iw3cjGUTwSpLRLAV0WOh0KYtmXlG1aB9SxpsGb8WWv+AGO2p7E= =Z5ie -----END PGP SIGNATURE----- --=-=-=--