From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 89185 invoked by alias); 11 Oct 2015 14:43:14 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 89173 invoked by uid 89); 11 Oct 2015 14:43:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: mail-out.m-online.net Received: from mail-out.m-online.net (HELO mail-out.m-online.net) (212.18.0.10) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Sun, 11 Oct 2015 14:43:12 +0000 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3nYm8X6MDkz3hmht; Sun, 11 Oct 2015 16:43:07 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 3nYm8W4tPdzvh28; Sun, 11 Oct 2015 16:43:07 +0200 (CEST) Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavisd-new, port 10024) with ESMTP id 8KYcXOJzbPDk; Sun, 11 Oct 2015 16:43:06 +0200 (CEST) X-Auth-Info: Oy0AyaN6xKcpa68iThG5FYo3kDhIal7819NJk7nua0Tn66ileuFVEOjqGw4OK4+A Received: from igel.home (ppp-93-104-62-35.dynamic.mnet-online.de [93.104.62.35]) by mail.mnet-online.de (Postfix) with ESMTPA; Sun, 11 Oct 2015 16:43:06 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id 264912C3BF3; Sun, 11 Oct 2015 16:43:06 +0200 (CEST) From: Andreas Schwab To: Alan Modra Cc: Ian Lance Taylor , David Edelsohn , "Lynn A. Boger" , Matthias Klose , gcc-patches Subject: Re: [PATCH] PR66870 PowerPC64 Enable gold linker with split stack References: <55FB10E7.9090607@linux.vnet.ibm.com> <56101F0E.8000003@ubuntu.com> <56153C00.2000209@linux.vnet.ibm.com> <561556F9.8030802@ubuntu.com> <5616BC63.3060307@linux.vnet.ibm.com> <5616D609.2000400@ubuntu.com> <56181AD9.6080501@linux.vnet.ibm.com> <87vbae2z71.fsf@igel.home> <20151011130719.GF4434@bubble.grove.modra.org> X-Yow: I love FRUIT PICKERS!! Date: Sun, 11 Oct 2015 14:43:00 -0000 In-Reply-To: <20151011130719.GF4434@bubble.grove.modra.org> (Alan Modra's message of "Sun, 11 Oct 2015 23:37:19 +1030") Message-ID: <87zizpcvph.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2015-10/txt/msg01072.txt.bz2 Alan Modra writes: > diff --git a/gcc/go/gospec.c b/gcc/go/gospec.c > index ca3c2d7..fbb55be 100644 > --- a/gcc/go/gospec.c > +++ b/gcc/go/gospec.c > @@ -120,8 +120,10 @@ lang_specific_driver (struct cl_decoded_option **in_decoded_options, > /* Whether the -S option was used. */ > bool saw_opt_S = false; > > - /* Whether the -m32 option was used. */ > - bool saw_opt_m32 ATTRIBUTE_UNUSED = false; > +#ifdef TARGET_CAN_SPLIT_STACK_64BIT > + /* Whether the -m64 option is in force. */ > + bool is_m64 = TARGET_CAN_SPLIT_STACK_64BIT; > +#endif > > /* The first input file with an extension of .go. */ > const char *first_go_file = NULL; > @@ -160,7 +162,11 @@ lang_specific_driver (struct cl_decoded_option **in_decoded_options, > > #ifdef TARGET_CAN_SPLIT_STACK_64BIT > case OPT_m32: > - saw_opt_m32 = true; > + is_m64 = false; > + break; > + > + case OPT_m64: > + is_m64 = true; > break; > #endif > > @@ -253,7 +259,7 @@ lang_specific_driver (struct cl_decoded_option **in_decoded_options, > #endif > > #ifdef TARGET_CAN_SPLIT_STACK_64BIT > - if (!saw_opt_m32) > + if (is_m64) > supports_split_stack = 1; > #endif Please remind me why this logic isn't implemented as a target hook. supports_split_stack = TARGET_CAN_SPLIT_STACK; /* rs6000.h */ #define TARGET_CAN_SPLIT_STACK TARGET_64BIT Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."