public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Thomas Schwinge <thomas@codesourcery.com>
To: "Joseph S. Myers" <joseph@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org,  maxim@codesourcery.com, thomas@schwinge.name
Subject: Re: [PATCH] glibc / uclibc / bionic switch vs. non-Linux, GNU-based systems
Date: Fri, 10 Dec 2010 12:34:00 -0000	[thread overview]
Message-ID: <87zksddeut.fsf@dirichlet.schwinge.homeip.net> (raw)
In-Reply-To: <Pine.LNX.4.64.1012081632080.1827@digraph.polyomino.org.uk>	(Joseph S. Myers's message of "Wed, 8 Dec 2010 16:33:35 +0000 (UTC)")

[-- Attachment #1: Type: text/plain, Size: 1503 bytes --]

Hallo!

On 2010-12-08 16:33, Joseph S. Myers wrote:
> This alternative patch limits use of linux.opt to those targets for
> which it is relevant - that is, *-*-linux* (systems using the Linux
> kernel and an MMU-based ABI), as those are the systems for which
> alternative libcs may be available withing a single compiler
> configuration.

I reviewed this patch (with Joseph's additional change to not duplicate
the DEFAULT_LIBC definition in certain cases), and it appears correct to
me.  (I cannot formally approve it, however.)

I also tested this one instead of my original patch, and successfully
built GCC natively on i686 GNU/Hurd.


> 2010-12-08  Joseph Myers  <joseph@codesourcery.com>
>
> 	* config/alpha/linux.h (OPTION_GLIBC): Define differently if
> 	SINGLE_LIBC.
> 	* config/linux.h (OPTION_GLIBC, OPTION_UCLIBC, OPTION_BIONIC):
> 	Define differently if SINGLE_LIBC.
> 	* config/rs6000/linux.h (OPTION_GLIBC): Define differently if
> 	SINGLE_LIBC.
> 	* config/rs6000/linux64.h (OPTION_GLIBC): Define differently if
> 	SINGLE_LIBC.
> 	* config.gcc (*-*-linux* | frv-*-*linux* | *-*-kfreebsd*-gnu |
> 	*-*-knetbsd*-gnu | *-*-gnu* | *-*-kopensolaris*-gnu): Define
> 	DEFAULT_LIBC and SINGLE_LIBC instead of OPTION_GLIBC.

s%DEFAULT_LIBC and %% as per your follow-up email.

> 	(*-*-uclinux*): Define DEFAULT_LIBC and SINGLE_LIBC.
> 	(bfin*-uclinux*, moxie-*-uclinux*, m68k-*-uclinux*): Don't define
> 	DEFAULT_LIBC or use linux.opt.


Grüße,
 Thomas

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

  parent reply	other threads:[~2010-12-10 11:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-08 15:54 Thomas Schwinge
2010-12-08 16:45 ` Joseph S. Myers
2010-12-08 16:58   ` Thomas Schwinge
2010-12-08 17:28     ` Joseph S. Myers
2010-12-10 12:34   ` Thomas Schwinge [this message]
2010-12-14 18:09   ` Ping " Joseph S. Myers
2010-12-20 14:46     ` Ping^2 " Joseph S. Myers
2010-12-20 17:04   ` Maxim Kuvyrkov
2010-12-20 21:06     ` Mark Mitchell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zksddeut.fsf@dirichlet.schwinge.homeip.net \
    --to=thomas@codesourcery.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=joseph@codesourcery.com \
    --cc=maxim@codesourcery.com \
    --cc=thomas@schwinge.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).