From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 1DBE0384DED1 for ; Thu, 15 Feb 2024 16:56:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1DBE0384DED1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1DBE0384DED1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708016172; cv=none; b=rtWbyObXkFkvuX/QqKVHTQk+yAHhjTXXpbrg6/vbqi8AIstUN7zK7fWD+KKatb9Hp6Ye0/IxL16gGitsydqf2bpjq397jTw1LUX4X5x6CepJKYrWEP6EoBlr0zU7f3xP/zP03aA1VsSI7RzV50veUtfojzSVM+8kysYSexw7Wzk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708016172; c=relaxed/simple; bh=UCn1OH1QhI4FVqEiQxEp8LvZ6maecTH7jEVkRJwf5Ho=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=Jgn37VNQNApCFaZd5C6OiKq0VXN5/Jx9cdrFl3LE8lZmOE8KbUK3t5Cge4ZbTmtOxb5EKBs9jcPHqIZdpkFF0bgM39b0IFFLciCLWTop10EI0dvrtbXfM844rUh/cCcRvhCFav60lcbOckTmPMmwJFo/2hlmg29jufokd0WJX/4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708016169; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bd83R08NfwBw2IyAOERtPynxX4waC9UsS9wqKZSfPHM=; b=T387wNl33yzH7eX+hegluPTheYkdRlM77wiSMWScjwo+3QV37smkydodPLpOBEqxgPqPbb NvLX6u7JSTlFgKN4nXntUPaLxUbNlxhp9beW7AJhsNFh2xcDHRIqcxsRkMLeRAKr+LHU4O tUxAxhItYugFl63I/E4HWqXE5LiPdLU= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-589-pa8wBw_BN6qWTuCBK4TUGg-1; Thu, 15 Feb 2024 11:56:08 -0500 X-MC-Unique: pa8wBw_BN6qWTuCBK4TUGg-1 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-7816e45f957so139599185a.1 for ; Thu, 15 Feb 2024 08:56:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708016167; x=1708620967; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=bd83R08NfwBw2IyAOERtPynxX4waC9UsS9wqKZSfPHM=; b=qW/qC8yw/Deu2YzhnAqdciLxmIJQGe93R2nQmFhjXf6H+TicG7nNdxgDKe3DY1VLOH AmTNle57bbrsPXI+R23PjTVdJewBqtQ9gUH9caEKMJ/z/H5TI4bFeDSwjhaasZy888uw 6m2OCn3dDGWvog0nE2wx6ob36kDWrqpAMl97ro2SrU/tR/NvXmq0tpeA3HcH2tDaY+mu f5ffNf3Ro3ZEByMPm5gsSKFmZIBdIbvEou3+GI4RRU2VvH3Klv9+RAbHfFM6IlQKAGcf Zns09XByanQ4UMPnvKLvv9Yurq/ndq4vQybb9s1O5GNGqQVVR/cSPB4M1dbazTZQ0DMz S73w== X-Forwarded-Encrypted: i=1; AJvYcCULi2ejWYkBAEQE7I9edGpPCTX7YRFngPTBWz/JXoEGc6IWJWR4F+L7ocirzkY48iaEzURAoaUyYO57aUX6SfbqKzNUbe8bzA== X-Gm-Message-State: AOJu0Yw6OLiYgZzI2v/X1ZNfBbejTxF6SeOaYzv6fxF0AA54d3a8Njt2 gKUdeJV5J98fqZYMUqJywZVn+v+lRgTY41DZzlO8Yq9KwWSID5WWm6E4qBvy/1KiTVW/hjWUuey df3lz5vwT4UE8lA8GMmdMRRudBkHnZujimBqmN1HjKbqZn7FTEMFHpaGtXJbFDW0= X-Received: by 2002:a05:620a:3902:b0:787:3674:c9be with SMTP id qr2-20020a05620a390200b007873674c9bemr2587059qkn.8.1708016167546; Thu, 15 Feb 2024 08:56:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IHmRGGU/6LShDuqiIZM4NDUK5q14aqABFSk4DO4GOIaQzJkJ6TayCyLpcYIx9PPacZV6+ucfQ== X-Received: by 2002:a05:620a:3902:b0:787:3674:c9be with SMTP id qr2-20020a05620a390200b007873674c9bemr2587046qkn.8.1708016167320; Thu, 15 Feb 2024 08:56:07 -0800 (PST) Received: from t14s.localdomain (c-76-28-97-5.hsd1.ma.comcast.net. [76.28.97.5]) by smtp.gmail.com with ESMTPSA id f6-20020a05620a15a600b00787224025e0sm733274qkk.130.2024.02.15.08.56.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 08:56:06 -0800 (PST) Message-ID: <880ad541f09689b402510cdc2994edad1c55c363.camel@redhat.com> Subject: Re: [PATCH] libgccjit: Add count zeroes builtins to ensure_optimization_builtins_exist From: David Malcolm To: Antoni Boucher , "gcc-patches@gcc.gnu.org" , "jit@gcc.gnu.org" Date: Thu, 15 Feb 2024 11:56:06 -0500 In-Reply-To: <35b8bdf858da6f6cfb2c6fe3a1f6620ff6f8a5a2.camel@zoho.com> References: <35b8bdf858da6f6cfb2c6fe3a1f6620ff6f8a5a2.camel@zoho.com> User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 2024-02-15 at 11:32 -0500, Antoni Boucher wrote: > Hi. > This patch adds some missing builtins that can be generated by > optimizations. > I'm not sure how to add a test for this one. > Do you know the C code that can be optimized to a builtin_clz? I don't. Given a reproducer we could probably figure it out, but it's probably not worth bothering. > Thanks for the review. Thanks, looks good to me for trunk. Dave