From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57073 invoked by alias); 3 Jan 2019 22:17:09 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 56951 invoked by uid 89); 3 Jan 2019 22:17:08 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=H*F:D*comcast.net, UD:comcast.net, noisy, Hx-languages-length:963 X-HELO: resqmta-ch2-03v.sys.comcast.net Received: from resqmta-ch2-03v.sys.comcast.net (HELO resqmta-ch2-03v.sys.comcast.net) (69.252.207.35) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 03 Jan 2019 22:17:06 +0000 Received: from resomta-ch2-05v.sys.comcast.net ([69.252.207.101]) by resqmta-ch2-03v.sys.comcast.net with ESMTP id f71QgwtrfU0GIfBIXgO5Kx; Thu, 03 Jan 2019 22:17:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20161114; t=1546553825; bh=gpKtu298wNFQA6jwV6DhcvL80KNjHCs0LO+HOWiln/0=; h=Received:Received:Content-Type:Mime-Version:Subject:From:Date: Message-Id:To; b=jsGYigoavcRUimN6N/RQkkGuKH2YooPz1R+8G5xnW6qKidGFQkxMq37upW4BMNO/P Z/DxtHHzXYM4zH5QoMf2+HiHaqg4yE/icAfwy+eAdsYUsEltkambY1NG6B1xiLv2Ac QnZ+vxoWNRSSzoLFAl6gZAk5TDr8OYkju/6piiQZMLuPHIzKHQB3H0ZPfQnJIj5Kr5 nG7+rFe1xDo1dM67N4/BtdNi/lAT9ht3sb4vn8ArtH9o+FwQq0BCqWQd9xo/xluvub EEJ51zjdamN+q1Qao7vwP7dab5zdLKK19hQrFYsCcze85DqF1CJiUpqE48sIKXwUCe n+xcoOhulLl0g== Received: from [IPv6:2601:640:4001:ad2:ac76:bfe3:7063:eed7] ([IPv6:2601:640:4001:ad2:ac76:bfe3:7063:eed7]) by resomta-ch2-05v.sys.comcast.net with ESMTPA id fBIQgMdUIEaZDfBITgnNeY; Thu, 03 Jan 2019 22:17:02 +0000 X-Xfinity-VMeta: sc=0;st=legit Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: [PATCH] Don't run ident tests on powerpc-darwin From: Mike Stump In-Reply-To: Date: Thu, 03 Jan 2019 22:17:00 -0000 Cc: Iain Sandoe , GCC Patches , David Edelsohn Content-Transfer-Encoding: quoted-printable Message-Id: <88A93918-51E4-4BD3-8C82-786502547A68@comcast.net> References: <337A44FA-78DE-4CA1-9AF1-4A287B2DF023@sandoe.co.uk> To: Rainer Orth X-IsSubscribed: yes X-SW-Source: 2019-01/txt/msg00126.txt.bz2 On Jan 2, 2019, at 5:39 AM, Rainer Orth wrote: >=20 > It's on the brink, I'd say. The effective-keyword form is shorter and > more descriptive and can be extended to more targets way more easily. > Checking 2018-12 testresults, I find failures of the ident-*.c tests on > hppa2.0w-hp-hpux11.11 and powerpc-ibm-aix7.2.0.0. If those were to be > handled as well, I'd strongly prefer the effective-keyword variant > rather than adding more and more targets to the individual tests. For a completely different thought, we can compare to a fine grain feature = database that dejagnu or the running program can probe and adjust for... #ifdef __has_feature(directive_ident) #endif then, this is directly populated from the port's #define, and the duplicati= on is gone. I think I like this direction. Let maintenance, faster port t= ime, higher quality port, and testing less noisy in general.