From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) by sourceware.org (Postfix) with ESMTPS id 976F8385E83A for ; Tue, 14 May 2024 11:01:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 976F8385E83A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=foss.st.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 976F8385E83A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=185.132.182.106 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715684509; cv=none; b=NE+1lJucNtgaf2Dx4vzAeTTB9LYkOMkGfizgZRWQVc0ZcnbcIv51nrIeFr/BnX/TDFPz8p1lRinbrKCe4kikRTStPVIcXAt7+kvgYrNqgu1JH7E61H9Xtv359wIuteK7HU1/CCmJgABFILd5clFijfMWIlcueKs2PYbCgG+uP4M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715684509; c=relaxed/simple; bh=JAg1mdwlxXhPaO5UQbVX4Vg1mtXYeja8b28cBCe/qcc=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=bwSK6xr8SXhB5Vejfgp47WXJ7ZvRgfcDAlv6EFGtOJ1LY08pfeeXjh14R8lIsAj+BWR7AYxD187JhFIPxB5NeH69nPFGRXsLn54XlH0BqMjZlh+3H74n8VWljs63dZgamVNFbB8buKndktmRVigLp1ARrG1aXbzH0QhU9aDFHzU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0369458.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 44E9Or1i015428; Tue, 14 May 2024 13:01:44 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= message-id:date:mime-version:subject:from:to:cc:references :in-reply-to:content-type:content-transfer-encoding; s= selector1; bh=1C0vBpHGIYPHyeYCXb2shupP8RQMI5n/a3VxI6CNI7U=; b=yK aZbbyMHS8K0UYCOulzEgWPUTJmG5+A7PFdmkhqSiNZuPtx0onyguQkYr3fDBF8h3 mK/IhXbit1XlygALTKFxG2mKxOdwc7mN9l34A9PpGK7wCY4NH93I9jnPyarL5pVQ 6K3rSwua1xfAwf7dYRrtB78ma3lBDws5D7mTTmlGqySS/NNgq1I8gUrLUq0t4u9w TqrqvWJYj0bTi9aW283lG9fH/QymStXBhYIJmDTfrt01yqpZtSEKfpYvdBB9z9Kv 2itdTxAMdthtCmchTvDfE8OcU+BdO0TpITgIW4PITPqpg1CuRukRz7pqjvzC4afg DGRotl++C9y+m6y3Iq4Q== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3y2j80s7eq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 14 May 2024 13:01:43 +0200 (MEST) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id 467E640044; Tue, 14 May 2024 13:01:37 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node3.st.com [10.75.129.71]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id D5B542171F5; Tue, 14 May 2024 13:01:15 +0200 (CEST) Received: from [10.74.18.1] (10.74.18.1) by SHFDAG1NODE3.st.com (10.75.129.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 14 May 2024 13:01:15 +0200 Message-ID: <88b756bf-21d8-4d2d-bd5b-6c795f93345e@foss.st.com> Date: Tue, 14 May 2024 13:01:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PING] [PATCH v2] testsuite: Verify r0-r3 are extended with CMSE Content-Language: en-US From: Torbjorn SVENSSON To: , , Richard Biener , Jakub Jelinek CC: , References: <07fde3e9-c08a-4a05-839f-86c8a18efec3@arm.com> <20240502105045.2505591-1-torbjorn.svensson@foss.st.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.74.18.1] X-ClientProxiedBy: SHFCAS1NODE1.st.com (10.75.129.72) To SHFDAG1NODE3.st.com (10.75.129.71) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.11.176.26 definitions=2024-05-14_05,2024-05-10_02,2023-05-22_02 X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, I'm not sure if the previous "ok" from Richard on the v1 is enough for this or if there needs another approval. Adding extra maintainers since Richard Earnshaw appears to be busy the past weeks. Kind regards, Torbjörn On 2024-05-06 13:50, Torbjorn SVENSSON wrote: > Hi, > > Forgot to mention when I sent the patch that I would like to commit it > to the following branches: > > - releases/gcc-11 > - releases/gcc-12 > - releases/gcc-13 > - releases/gcc-14 > - trunk > > Kind regards, > Torbjörn > > On 2024-05-02 12:50, Torbjörn SVENSSON wrote: >> Add regression test to the existing zero/sign extend tests for CMSE to >> verify that r0, r1, r2 and r3 are properly extended, not just r0. >> >> boolCharShortEnumSecureFunc test is done using -O0 to ensure the >> instructions are in a predictable order. >> >> gcc/testsuite/ChangeLog: >> >>     * gcc.target/arm/cmse/extend-param.c: Add regression test. Add >>       -fshort-enums. >>     * gcc.target/arm/cmse/extend-return.c: Add -fshort-enums option. >> >> Signed-off-by: Torbjörn SVENSSON >> --- >>   .../gcc.target/arm/cmse/extend-param.c        | 21 +++++++++++++++---- >>   .../gcc.target/arm/cmse/extend-return.c       |  4 ++-- >>   2 files changed, 19 insertions(+), 6 deletions(-) >> >> diff --git a/gcc/testsuite/gcc.target/arm/cmse/extend-param.c >> b/gcc/testsuite/gcc.target/arm/cmse/extend-param.c >> index 01fac786238..d01ef87e0be 100644 >> --- a/gcc/testsuite/gcc.target/arm/cmse/extend-param.c >> +++ b/gcc/testsuite/gcc.target/arm/cmse/extend-param.c >> @@ -1,5 +1,5 @@ >>   /* { dg-do compile } */ >> -/* { dg-options "-mcmse" } */ >> +/* { dg-options "-mcmse -fshort-enums" } */ >>   /* { dg-final { check-function-bodies "**" "" "" } } */ >>   #include >> @@ -78,7 +78,6 @@ __attribute__((cmse_nonsecure_entry)) char >> enumSecureFunc (enum offset index) { >>     if (index >= ARRAY_SIZE) >>       return 0; >>     return array[index]; >> - >>   } >>   /* >> @@ -88,9 +87,23 @@ __attribute__((cmse_nonsecure_entry)) char >> enumSecureFunc (enum offset index) { >>   **    ... >>   */ >>   __attribute__((cmse_nonsecure_entry)) char boolSecureFunc (bool >> index) { >> - >>     if (index >= ARRAY_SIZE) >>       return 0; >>     return array[index]; >> +} >> -} >> \ No newline at end of file >> +/* >> +**__acle_se_boolCharShortEnumSecureFunc: >> +**    ... >> +**    uxtb    r0, r0 >> +**    uxtb    r1, r1 >> +**    uxth    r2, r2 >> +**    uxtb    r3, r3 >> +**    ... >> +*/ >> +__attribute__((cmse_nonsecure_entry,optimize(0))) char >> boolCharShortEnumSecureFunc (bool a, unsigned char b, unsigned short >> c, enum offset d) { >> +  size_t index = a + b + c + d; >> +  if (index >= ARRAY_SIZE) >> +    return 0; >> +  return array[index]; >> +} >> diff --git a/gcc/testsuite/gcc.target/arm/cmse/extend-return.c >> b/gcc/testsuite/gcc.target/arm/cmse/extend-return.c >> index cf731ed33df..081de0d699f 100644 >> --- a/gcc/testsuite/gcc.target/arm/cmse/extend-return.c >> +++ b/gcc/testsuite/gcc.target/arm/cmse/extend-return.c >> @@ -1,5 +1,5 @@ >>   /* { dg-do compile } */ >> -/* { dg-options "-mcmse" } */ >> +/* { dg-options "-mcmse -fshort-enums" } */ >>   /* { dg-final { check-function-bodies "**" "" "" } } */ >>   #include >> @@ -89,4 +89,4 @@ unsigned char __attribute__((noipa)) enumNonsecure0 >> (ns_enum_foo_t * ns_foo_p) >>   unsigned char boolNonsecure0 (ns_bool_foo_t * ns_foo_p) >>   { >>     return ns_foo_p (); >> -} >> \ No newline at end of file >> +}