From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by sourceware.org (Postfix) with ESMTPS id C06D5382CF33 for ; Fri, 27 May 2022 08:05:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C06D5382CF33 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2170.outbound.protection.outlook.com [104.47.17.170]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-41-WKBbxruvN066WTYNNt1Rxw-1; Fri, 27 May 2022 10:05:15 +0200 X-MC-Unique: WKBbxruvN066WTYNNt1Rxw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e2WRz5XxHyX5BtEC/GhbEpdc9UAdVBpT52xocIJ+PycWcIzyQ5i8ItEif1Da+1/izRc787/iED8TN2BMVUirx03PV8cTPgoPm5A0pZiXmR5I+xVln714RKYBlzOakrOwC2otHmYGrncJyAFvNFgsaNRX+C/oY+eqa38r6Z7V1jSjOGDH64eXKZ/9TNnXaVDT2qIM+HKedbAR/c4XbhUCUtpx3SJ/AJPLg7N11Xfmp0S/lPonnwPLggylhm7rHwemocW3tLuo74hDnX2VIpci3FM7dJSKp0cFp6V7kgAq2J0ZCKwEidkOy56aCHMawSWllxOrgS1kcIu/x6ubfDLDrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Y+MXsSsGC23krgPaqgRDmfVgHW8OLj2AnOgZPTo2Tzg=; b=EUgW/4J26jnj9FUkTtP/RzMhrhxjJJ7U/Ca17R0RrKNKgoqoOrHdKXBS6qaSWbha7fAcxIt1iz0SH3BSIwOCgGotLYwB1yJ07NW+Louw5b5m/39i22G9twRGGpIGkzwvdTzuDmWuTW8Sqx5usmpY5DYU6bkUt7Vc9vPHB429/e6JbG0dC0cDR8ODxJSucCSh0Wy49KiN2oTIGeY95J2VV5zruMN10iEIUGpep0Wt01o6QFUylLAViBOdXap/sH7Hk3DySQK0xPZiPyVxqzCHo+xRq4Z28AvcrunkTBiTgr2FFxXODmEhv0/pzzIEJw/BnEwUCc5iIS/4Tys8aDQE8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB7821.eurprd04.prod.outlook.com (2603:10a6:102:c5::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Fri, 27 May 2022 08:05:14 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.013; Fri, 27 May 2022 08:05:14 +0000 Message-ID: <88d618dc-0c78-81ed-5b1c-6157b9ba7a30@suse.com> Date: Fri, 27 May 2022 10:05:12 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Content-Language: en-US To: "gcc-patches@gcc.gnu.org" Cc: hubicka@ucw.cz, ubizjak@gmail.com From: Jan Beulich Subject: [PATCH] x86: correct bmi2_umul3_1's MEM_P() uses Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5PR0601CA0037.eurprd06.prod.outlook.com (2603:10a6:203:68::23) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8054ba37-03af-4de9-3916-08da3fb7a113 X-MS-TrafficTypeDiagnostic: PA4PR04MB7821:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Sg7F6sl/RPlzoQc4Jvg20h4VHdYsmDzHxxA1oD9pgiRdDh44b1/idp0njRe6H1iwgxFYV9qk5+1aImGjR/HBA3UI556VNGWbD0FDiMBvpXrV6puiZk/bJrZaqkiOzHNI785oizEklMlGfRKTeEwBSBEjZ9P2Ch2OKX2qE2gq1nTyyNxn3JDB1bLQnikLJo3D8UlyhFEu52h/2NPoz0nvOE8w51BmzOIo3Vl52qOQABvFxW6sgtS1aIcBc7FM9zf250Cv5ByT1HoJz1gJhRKskV4WjFCoB0hX0ydxvjY0BneNEvN7ZdO2uqcdKOEz2uA0NQAe534EvNVePdOUbRqvQrBNQ2xyiI7yQj4JzVpK/hwrSducPJpiVgmbYsjFhFs3iLhwrahp5t6jtfQFqkmUcUAzqZm3Z3JwT9mFaA+QkiEsQ35lKpr2Ze7DEFaAqnW9yuasd9gOlUNWEjkkrXJJ0886ldGQZikPVjNV73aJGPSKSsMbqzCayK+wtjbN4DwtHdUlrrhXnLum6wwPsgO/HToy4PKWhu16RgmdOOZ4i6ed1b24Bii9UawVQ4bP2iVTal4aMEir2mIktRmml2yrOdhJy80Bxz40B8A4G3z8LMWrIbDbWvP1TE9qZWMi9Mm/sJRb7vSvQQ+Cz07LLMNrK/QjRJIuSmL6cVAgQgbYNTd9t59WrtBSpHFCfFQTYQchkM6s8JN0jV4HNOmM2wbID0hggvfY4ZTaABDwhN9aM8UkYd9E5ZYf8X7OTAO2gRNP X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(36756003)(31696002)(2906002)(86362001)(6916009)(186003)(31686004)(2616005)(4744005)(26005)(38100700002)(8936002)(4326008)(5660300002)(6512007)(66946007)(66556008)(66476007)(8676002)(6506007)(316002)(6486002)(508600001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bSthU2ZDVEVENExIMlFKQ210MEhnS2lqTlRRY3hFWTY1czJUQ3ZtZE1wZWJE?= =?utf-8?B?WmFObVV3RU1nM3VlbWtmYy82M1JMbktjazdyZDkvL0dUWndza3laVmFGaW9C?= =?utf-8?B?RnJMZzk3c2wyUEp1MEpkTXNzOVlrRzZ0Vk40ekxvZWYwLzVuZXk2VWFKZURs?= =?utf-8?B?SFlRNndwT2V1ZnpiK214WjVxQUprOWw0Ulp6UjNXUmNKNEZWTEo3dW5FL0xR?= =?utf-8?B?a3hkTDNBZDRCVEpYdTd4YURqTFRTb0RpS3NvUTZsQlJxSFlLNVJxeHRYZVN3?= =?utf-8?B?UDQ5RXRmZDlLaW1seU0yN1VEbGVhdzZ4L0RzTy82Mk5nMFNndWtLNHZRR3JU?= =?utf-8?B?dFR1aHozT3ljVS96TWlzTHFLVU1XUFFaekF0MGhVblJUSVpRcDh1aUVpWVBC?= =?utf-8?B?QnpPUHZiWXRjdVQ1R1Y2OTM5YzhSbUhBV1VNYUFGWEhGamlwRXZGZDFsejlR?= =?utf-8?B?cEs3eUlZb0JpSlVEVzFXamkrVkpuWi80Y242Y2JQa0ZwaUhSTUNXY1kvUWxa?= =?utf-8?B?L04rTit1MFBqOWdxUjRDQ3QvbXNHcVEwUURCc0tKYzJVU29sVWxsVmtzWFJH?= =?utf-8?B?V3hKTUhIWDZhakhCSFFxOTQ1RGJWcFdNcEQwSk03RHVNTWNjL0x3aHFkQUk5?= =?utf-8?B?czNkN0tBemdUUmRyUkx1ZWJDZ3FBOTBiVStueldHV2E2c3YyOU1McFJNNGk3?= =?utf-8?B?enJwenRmaHJKdG5zTU5aZUJDREdQdldjR0xBWTdQUGsxUkdtbTlFakJ4VWlt?= =?utf-8?B?ZTJnZGxoZnR3VDY2M0docTlGVTUrZGdZVy81d3NBdFJmTFNyM3k5enJ5RkNF?= =?utf-8?B?Rm1zYmtYU05MUEZDMFJJQjB1Y2ZETVVJVjgzdnphbVErNjFWRnlUVWlmekhD?= =?utf-8?B?cWVJaVdSSWR5aTd4LzdFVjE5NzkyNGVuTnpRVGE0WnpNdWI3dXh6Z2ZPa0Vw?= =?utf-8?B?K25Uaks4blFSYmYzWEV0WjE3RDNPc1J0N0M3cE9Wd0FTSk9iQVI0SjcvOWF5?= =?utf-8?B?SWVaZUlxa0ptYnpwbDFpREE1T0podEZTYTRUSE5zbkVIbHNVNVFRMlhwUXgw?= =?utf-8?B?Z3JkUGxJblFJSWY4SHRveWVpeFRldmJYYTdENTJBMDE2R1kxVWUvRXRBY08w?= =?utf-8?B?VzJ6RU9KTm9TOFg3V1NwK2RsSkdHK1FUbEY3aHZGWTV3WXNCSzI1R3ZUUkhY?= =?utf-8?B?dTdWQzBpeVVDeDQrNlNIdnV2WlNQb1loMGRxWHNaQ2tLVnZScG5XcEF3MUpG?= =?utf-8?B?eFR5Vi9WSTNhS295NkZRZG43cGZRTGZkQ1k4NFBUTFg3ZXhFbVJqMkczNkNu?= =?utf-8?B?WTByS0Q5Nk0yWE9ocWxYTUNEQ01Wcy9qMzVuQWtOSzhpWnY2dDllYjEvYk13?= =?utf-8?B?ZGF1RUJvcWh3Y2J2TkpTWk9nY3hXUWlhNWFOVWphU3htbmNKNzdPV1VrcHdD?= =?utf-8?B?T0hKOE8vSHpLZ1VGbGlzM1dnSlVlUjgxOFBoK2E1dmZMQUFEeGZkNzVSdFNW?= =?utf-8?B?VzB4QUllR21TWVdTSmlwT0VWNzVvWU43U2wzUmU1K1FwdTN3VUgwZ1BDbW9K?= =?utf-8?B?dU9abTF5WTA2bGRuWW5ob3dZZnc0bWhqWGZIbmlocHgrYzgxLzU2b3paVVh3?= =?utf-8?B?SHFRZ3drakpUdjJnYk4wb1daZzJ0dXJRODRNR0oydXB3dkd0K0ljRGxQMko2?= =?utf-8?B?dTBTdzdmREVmTHhNRUZzMndYa0xSYzJ0M3hnWHdCNERNTHF3RDZIWXZETWxw?= =?utf-8?B?cUlQV1RNUWtPYmFSd0MweHZuTkFXeDluY2ovdUtQenc0T1FCVit1dXEvNVB2?= =?utf-8?B?U1p0SGRpamc4SVowSGZIcHY1SjM0L3dzWXlHQ01XeWFVd0puenRZMndvNlN5?= =?utf-8?B?T3hKakJiOHowdC9IdFlVVnBmZkFRNUxlQS9nUkliK05BdW0zSkM2Qy9wWjA0?= =?utf-8?B?eWwxTkhqSzQzYTg0eVVFelVSQ3o5YjZwRWZTaTZWNGRwTDVYbjZWNUxSN1kz?= =?utf-8?B?b2FZYzU4bm51UFRFNkFhR015VzBBMFJTNHJzK1BtZXRmRzlpYm5rNExyV3VR?= =?utf-8?B?ZTBtbXdOTnVCK0ZjQVA4WGMrS2NLSklkS2RLaFl6aWJRMlBQWnlPTXAzNlRP?= =?utf-8?B?UUw2SzdNdVhkT09rTS9jVXZsTXluVlIwVy94bDg2dzM0WmdDVmpYT21zakx0?= =?utf-8?B?eHN2VzJ3Y1dHRzFNTXYwSE9qVWxsL2dBMjc5V04za0lKeXBRWE53VkRCZFpD?= =?utf-8?B?OHFzOEk0OXcwTFJEUnRUdW81S1ZsSTlyWVROUXUxT29SdVp4NytRdSs3MVhr?= =?utf-8?B?d25RTWNKTHN5VzRiL3RmOVpQQkIrNHZZUkcySU9TZmVVNFR2Mm8vQT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8054ba37-03af-4de9-3916-08da3fb7a113 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2022 08:05:14.1553 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /+Vw8laTxXv44mFPfiNg8WHn1KjFkMUisyBkYH/b7OEaMQKHlcrV+90wzQKO2mx6nsikxu8A3qe8YflPquC9ew== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7821 X-Spam-Status: No, score=-3031.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 May 2022 08:05:24 -0000 It's pretty clear that the operand numbers in the MEM_P() checks are off by one, perhaps due to a copy-and-paste oversight (unlike in most other places here we're dealing with two outputs). --- What I don't understand is why operand 2 is "nonimmediate_operand", not "register_operand" (which afaict would eliminate the need for these MEM_P() checks). This would then also extend to e.g. the subsequent umul3_1 and mul3_1 (and apparently quite a few more). --- a/gcc/config/i386/i386.md +++ b/gcc/config/i386/i386.md @@ -8465,7 +8465,7 @@ (zero_extend: (match_dup 3))) (match_operand:QI 4 "const_int_operand" "n"))))] "TARGET_BMI2 && INTVAL (operands[4]) == * BITS_PER_UNIT - && !(MEM_P (operands[1]) && MEM_P (operands[2]))" + && !(MEM_P (operands[2]) && MEM_P (operands[3]))" "mulx\t{%3, %0, %1|%1, %0, %3}" [(set_attr "type" "imulx") (set_attr "prefix" "vex")