From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd32.google.com (mail-io1-xd32.google.com [IPv6:2607:f8b0:4864:20::d32]) by sourceware.org (Postfix) with ESMTPS id 40E523858286 for ; Thu, 21 Dec 2023 04:04:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 40E523858286 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 40E523858286 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d32 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703131487; cv=none; b=Fi8VVHS5wElii6uC7hsoKr7MQ+bed6p2A3h+kgsfdwosjYhE56kyg/bORBsBcUDu0DI+rn7YNsoTboJufxJJyNJ56aNtsp4sIoQkGruJhRhw+9+GwtCkmv7aipwX+Q4Ep82mj1mWSJOkb46bx5UIN9nDcS3pkDajgmm1OsHzyq8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703131487; c=relaxed/simple; bh=ZnCtvrI9wCNNFrARMP17/yQDY5WJLn/PipnETxUCQz8=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=ojxGvRtKxCHJbaa5xuyEKMFelYZiblNyJnbsNjhJL6AJnSUAjhgeAErn7emgktOiusObp8zuRp0GsKwFgggNXA9euIdpRQSrffMydeEEqBgv1mpkGmtaqRs6S3sx3NUvFuQfI7f6+aDz5BTKMigD6gfjNLelnM/Q3GIx3ZDFDQY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd32.google.com with SMTP id ca18e2360f4ac-7b71e389fb2so17625139f.3 for ; Wed, 20 Dec 2023 20:04:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703131485; x=1703736285; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WPnmjS/gvBzfaDHQY+Q43kJJoEaa4qNdwPTAgFA/1i0=; b=NOHJZ68xq1P26huVqa36oj5PvpnUREvDOmz78fbEzxugKM4SLYbkh4/GFrLvHyTKPy IQZYbq78kDQS02YYSDgno7UbdDsJPMOtg2l64tZR6/8ifc9eIPsuYKFFF2coqUemcMTg tri4L3d965SVib+YGP/l+P7yM0qWmYrPdn8bdEVFnigD1WXD7ExJ+dk7EQQGb1HgWhHS H6BoluEMpm6WVdrQQHPNETdw/CgWFiQZ3vEqY79NxkfFU5/HbC/4oCBYS2eoP01/vRcl 3LS+TikIikhtyebj/4EwulLG51pcZJ+JArhmVHxBsyWb+oas5Q7xi978yFMfaMqJXZcc vglQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703131485; x=1703736285; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WPnmjS/gvBzfaDHQY+Q43kJJoEaa4qNdwPTAgFA/1i0=; b=rVh5mPzIaBiLircpu2T8Yf9Usd+n7bFpvARjVdXOYkdhZPWViN15pu3F+LFZ7bmYSr 1xfD/3cirMn8jLRlnmE0/aBaErpmOIkjUv7VEJEmS8V5Rv8o6kALiSnk+3nKwbqVG7j2 9kGQSp33gSdq32sOCd4UmxJyApGEwb9cQFmOm/+vAidbfSuvkR01/DJZaGn6whUo0j8c 8lcf8wKs+mNIdenqjKFwr9ELOfH55WBPiR+E2IuFegJwfjdDGVGouwIKtSsvG9+q87sL YvNR8a8AJ3wh8q3LFKJZO/gIMak/UFzvGQGW8NS79HmF56FWVU4cNnxISCZyqp0U06A4 roIQ== X-Gm-Message-State: AOJu0YzGqHGO7RVJx1xyOnK/LT1bNmtrYUuXDUV0rjz1Ei8MbhYPsH7u Vf6aOn6WTG4jh6zYnjThqBM= X-Google-Smtp-Source: AGHT+IGIYDXcyD4/JYJJon65RGcvHtqh/Jpkcz3+HZAgzMsjd3dBTo3HQtliQNXxTvMek0KfkVjgJw== X-Received: by 2002:a05:6602:1546:b0:7b7:d220:9e3d with SMTP id h6-20020a056602154600b007b7d2209e3dmr9979937iow.2.1703131485183; Wed, 20 Dec 2023 20:04:45 -0800 (PST) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id t3-20020a02ab83000000b0043978165d54sm270395jan.104.2023.12.20.20.04.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Dec 2023 20:04:44 -0800 (PST) Message-ID: <8925b786-6588-4cbc-92e2-97be4091f1d3@gmail.com> Date: Wed, 20 Dec 2023 21:04:42 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/6] RISC-V: Support XTheadVector extension Content-Language: en-US To: "juzhe.zhong@rivai.ai" , "cooper.joshua" , gcc-patches Cc: Jim Wilson , palmer , andrew , "philipp.tomsich" , "christoph.muellner" , jinma , "cooper.qu" References: <20231118042258.3545-1-cooper.joshua@linux.alibaba.com> <20231220122055.343-1-cooper.joshua@linux.alibaba.com> <34515139-3044-4e4a-b250-535b7820e1a8@gmail.com> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/20/23 20:30, juzhe.zhong@rivai.ai wrote: > OK.  Sounds reasonable. > > But from my side, I used to commit patches after full coverage testing. Understood. And it's appreciated -- the code you're doing hits a wide variety of configurations, so the wider testing is probably applicable. Ideally the thead vector bits need reasonable testing to make sure they don't totally break the standard RVV support. So for something like the final scheme to add the "th." prefix I'd expect they can get away with just rv64gcv. WHile there is a chance that'll miss something, the odds are pretty low that a bug will be uncovered for each additional configuration tested beyond the first. In contrast if they needed to make a structural changes that are more than adding a path for thead's vector unit, then we might reasonably ask for a deeper test of that specific patch (perhaps even suggesting the configurations most likely affected and thus which need to be tested). The key being we want to use time wisely and testing dozens of multilibs for each change isn't really reasonable. It's always a delicate balance to articulate the right level of testing because the "right" level can vary based on each engineer's risk assessment of a particular change. Jeff