From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 4F2333858025 for ; Tue, 20 Jun 2023 16:07:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4F2333858025 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687277227; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QXOXJsBr2RUZY9mWpOBrSHpgVajouk6QbozfXcQqTq8=; b=ZocrqPu3vBj2FZFs1yPigXk47jTO45+JwKgKXFuwo8PhHanaXfJRY59cLS/cR6v9/eFlNE Mpix4e+L4cxBCw9PyY9paXsQb9RN/9Cp2Aqdri/s06ivo2DJ0eak2Z2cN/dUy1/8cktXNg +8lzOkIVjfR8Ak6G6O8U7+k//Ltp1DA= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-175-Z4DhmaZDNNud2Vz0AvGkGg-1; Tue, 20 Jun 2023 12:06:53 -0400 X-MC-Unique: Z4DhmaZDNNud2Vz0AvGkGg-1 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-7623a4864c2so543509585a.3 for ; Tue, 20 Jun 2023 09:06:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687277201; x=1689869201; h=mime-version:references:message-id:in-reply-to:subject:cc:to:date :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QXOXJsBr2RUZY9mWpOBrSHpgVajouk6QbozfXcQqTq8=; b=SmmEJzIt0dspFVNxykLHuUhRd/GvMnhnVz8296w0Be2O0vycwcn8z0WYokCPDKBpza i8RFR1wGfejXuUoiVYFgaKsdQs1KCllYUw/y2hufgieEmx5lt6ff48Sc6qI+9vKkTFga PmrDs1GbOpWxBbc5jVYwO2fFt3oE73/1JUEsLLxQdZPip15eKNJy6yK4pWY8X+ahExx3 hQfUUI1OkyMSoOB2GcDxW5kZiSzDNWds1JNLXfrpqlPyaKq2+UZX79CbvW9eDuEx2sql 385sIw9Sm32FNmWP9e1uUyrQjvjUylAhClXUzf31L/ryM3vIgnkox8B/UyyUYcgTyPE7 CLrg== X-Gm-Message-State: AC+VfDzaFCFEDrsPBWu0PHqXy8rfAIXChA+U2iJnMSpNZGcnLvh04nsT x8www2NR6l+sus57Sp+FhS2yemUrMMZN2g+LK1OGfbkjUF2dvFYnrCCK1Jh80OFZ1wkWwmEF9mK Preiisn4q7iPJmS3v1ufmxRWTEA== X-Received: by 2002:a05:620a:2888:b0:75d:52fd:bb79 with SMTP id j8-20020a05620a288800b0075d52fdbb79mr11379585qkp.46.1687277201113; Tue, 20 Jun 2023 09:06:41 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5R22H7SZf5vEC9TNyo1MkMDc/0Wc2tvi/yQsyPCQrj20SYOYW9TMQnIRdK1E0U7aC/bUuVWQ== X-Received: by 2002:a05:620a:2888:b0:75d:52fd:bb79 with SMTP id j8-20020a05620a288800b0075d52fdbb79mr11379569qkp.46.1687277200797; Tue, 20 Jun 2023 09:06:40 -0700 (PDT) Received: from [192.168.1.130] (ool-457670bb.dyn.optonline.net. [69.118.112.187]) by smtp.gmail.com with ESMTPSA id p8-20020a05620a132800b007592174cb08sm1277423qkj.10.2023.06.20.09.06.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jun 2023 09:06:40 -0700 (PDT) From: Patrick Palka X-Google-Original-From: Patrick Palka Date: Tue, 20 Jun 2023 12:06:39 -0400 (EDT) To: Ken Matsui cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org Subject: Re: [PATCH v7 1/6] c++: implement __is_reference built-in trait In-Reply-To: <20230612224909.21188-2-kmatsui@cs.washington.edu> Message-ID: <8992720a-206d-fabe-8336-e5a8557d4219@idea> References: <20230612224109.20749-1-kmatsui@cs.washington.edu> <20230612224909.21188-1-kmatsui@cs.washington.edu> <20230612224909.21188-2-kmatsui@cs.washington.edu> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-13.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 12 Jun 2023, Ken Matsui via Libstdc++ wrote: > This patch implements built-in trait for std::is_reference. > > gcc/cp/ChangeLog: > > * cp-trait.def: Define __is_reference. > * constraint.cc (diagnose_trait_expr): Handle CPTK_IS_REFERENCE. > * semantics.cc (trait_expr_value): Likewise. > (finish_trait_expr): Likewise. > > gcc/testsuite/ChangeLog: > > * g++.dg/ext/has-builtin-1.C: Test existence of __is_reference. > * g++.dg/ext/is_reference.C: New test. LGTM > > Signed-off-by: Ken Matsui > --- > gcc/cp/constraint.cc | 3 +++ > gcc/cp/cp-trait.def | 1 + > gcc/cp/semantics.cc | 4 +++ > gcc/testsuite/g++.dg/ext/has-builtin-1.C | 3 +++ > gcc/testsuite/g++.dg/ext/is_reference.C | 34 ++++++++++++++++++++++++ > 5 files changed, 45 insertions(+) > create mode 100644 gcc/testsuite/g++.dg/ext/is_reference.C > > diff --git a/gcc/cp/constraint.cc b/gcc/cp/constraint.cc > index 8cf0f2d0974..f6951ee2670 100644 > --- a/gcc/cp/constraint.cc > +++ b/gcc/cp/constraint.cc > @@ -3705,6 +3705,9 @@ diagnose_trait_expr (tree expr, tree args) > case CPTK_HAS_VIRTUAL_DESTRUCTOR: > inform (loc, " %qT does not have a virtual destructor", t1); > break; > + case CPTK_IS_REFERENCE: > + inform (loc, " %qT is not a reference", t1); > + break; > case CPTK_IS_ABSTRACT: > inform (loc, " %qT is not an abstract class", t1); > break; > diff --git a/gcc/cp/cp-trait.def b/gcc/cp/cp-trait.def > index 8b7fece0cc8..1e3310cd682 100644 > --- a/gcc/cp/cp-trait.def > +++ b/gcc/cp/cp-trait.def > @@ -67,6 +67,7 @@ DEFTRAIT_EXPR (IS_CONVERTIBLE, "__is_convertible", 2) > DEFTRAIT_EXPR (IS_EMPTY, "__is_empty", 1) > DEFTRAIT_EXPR (IS_ENUM, "__is_enum", 1) > DEFTRAIT_EXPR (IS_FINAL, "__is_final", 1) > +DEFTRAIT_EXPR (IS_REFERENCE, "__is_reference", 1) > DEFTRAIT_EXPR (IS_LAYOUT_COMPATIBLE, "__is_layout_compatible", 2) > DEFTRAIT_EXPR (IS_LITERAL_TYPE, "__is_literal_type", 1) > DEFTRAIT_EXPR (IS_NOTHROW_ASSIGNABLE, "__is_nothrow_assignable", 2) > diff --git a/gcc/cp/semantics.cc b/gcc/cp/semantics.cc > index a2e74a5d2c7..2f37bc353a1 100644 > --- a/gcc/cp/semantics.cc > +++ b/gcc/cp/semantics.cc > @@ -12075,6 +12075,9 @@ trait_expr_value (cp_trait_kind kind, tree type1, tree type2) > case CPTK_IS_FINAL: > return CLASS_TYPE_P (type1) && CLASSTYPE_FINAL (type1); > > + case CPTK_IS_REFERENCE: > + return type_code1 == REFERENCE_TYPE; > + > case CPTK_IS_LAYOUT_COMPATIBLE: > return layout_compatible_type_p (type1, type2); > > @@ -12289,6 +12292,7 @@ finish_trait_expr (location_t loc, cp_trait_kind kind, tree type1, tree type2) > case CPTK_IS_ENUM: > case CPTK_IS_UNION: > case CPTK_IS_SAME: > + case CPTK_IS_REFERENCE: > break; > > case CPTK_IS_LAYOUT_COMPATIBLE: > diff --git a/gcc/testsuite/g++.dg/ext/has-builtin-1.C b/gcc/testsuite/g++.dg/ext/has-builtin-1.C > index f343e153e56..b697673790c 100644 > --- a/gcc/testsuite/g++.dg/ext/has-builtin-1.C > +++ b/gcc/testsuite/g++.dg/ext/has-builtin-1.C > @@ -146,3 +146,6 @@ > #if !__has_builtin (__remove_cvref) > # error "__has_builtin (__remove_cvref) failed" > #endif > +#if !__has_builtin (__is_reference) > +# error "__has_builtin (__is_reference) failed" > +#endif > diff --git a/gcc/testsuite/g++.dg/ext/is_reference.C b/gcc/testsuite/g++.dg/ext/is_reference.C > new file mode 100644 > index 00000000000..b5ce4db7afd > --- /dev/null > +++ b/gcc/testsuite/g++.dg/ext/is_reference.C > @@ -0,0 +1,34 @@ > +// { dg-do compile { target c++11 } } > + > +#include > + > +using namespace __gnu_test; > + > +#define SA(X) static_assert((X),#X) > +#define SA_TEST_CATEGORY(TRAIT, TYPE, EXPECT) \ > + SA(TRAIT(TYPE) == EXPECT); \ > + SA(TRAIT(const TYPE) == EXPECT); \ > + SA(TRAIT(volatile TYPE) == EXPECT); \ > + SA(TRAIT(const volatile TYPE) == EXPECT) > + > +// Positive tests. > +SA_TEST_CATEGORY(__is_reference, int&, true); > +SA_TEST_CATEGORY(__is_reference, ClassType&, true); > +SA(__is_reference(int(&)(int))); > +SA_TEST_CATEGORY(__is_reference, int&&, true); > +SA_TEST_CATEGORY(__is_reference, ClassType&&, true); > +SA(__is_reference(int(&&)(int))); > +SA_TEST_CATEGORY(__is_reference, IncompleteClass&, true); > + > +// Negative tests > +SA_TEST_CATEGORY(__is_reference, void, false); > +SA_TEST_CATEGORY(__is_reference, int*, false); > +SA_TEST_CATEGORY(__is_reference, int[3], false); > +SA(!__is_reference(int(int))); > +SA(!__is_reference(int(*const)(int))); > +SA(!__is_reference(int(*volatile)(int))); > +SA(!__is_reference(int(*const volatile)(int))); > + > +// Sanity check. > +SA_TEST_CATEGORY(__is_reference, ClassType, false); > +SA_TEST_CATEGORY(__is_reference, IncompleteClass, false); > -- > 2.41.0 > >