From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id C6F37396ECE9 for ; Fri, 27 Nov 2020 10:22:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C6F37396ECE9 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Tobias_Burnus@mentor.com IronPort-SDR: sFel3aO8N5rRF2TpU+pmVhd5W4ukgtPxmkkgoXFJwqR/IdV5Cc/mmAJexN8eNnx7uTeD91L5m6 cPm0KQPlYPtXzdB4xqsbfNhdqeG8Ku+7NrUhTDlmvs82dMs+54t6/xqX/2RM6pjjIdC+mevilC 35LwL7ODLuKUCrgta4E7f5lmEYys8/B+xw7azmyiJSMwqZsUXvqJe4zkoBPG+yomIfMas+IbmV VylVvX1Rd32B68ANHRmLWlUtUo6k4HI290R58BnQ6CL+7YvEwyb+TQkcpn04mN1bS2TaXujEG9 cik= X-IronPort-AV: E=Sophos;i="5.78,374,1599552000"; d="scan'208";a="55553305" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa2.mentor.iphmx.com with ESMTP; 27 Nov 2020 02:22:08 -0800 IronPort-SDR: MhfAjgmQ3E24CkJ29spBWm3e49IgrMP8yOxgR8XJ14cvxAeiabbcoYCDcnZ5heRuUXX2nSPHtM EwakA1aDyRjqSX+2Y55g1DW7FrFCGvbNE9M6Hk4lx+zRT9wbjkoa1pSRJrl1H+4xYReQ+u/t8I 4f68bO1oTKCZZzyiaon03PNsC0Cx7h9qd4tFmHLSfyzYlLEzRg06ZRHSF2wkGmyKpr/YxioQyF envFgJfM/vdjfk7257CWgy/GxQE5XqWUnNZfaKoB4vNdtQpiwxh2zT9y/2IoBFywUkSA8irBM/ lCs= Subject: Re: [Patch] OpenACC: Fix integer-type issue with collapse/tile [PR97880] From: Tobias Burnus To: Thomas Schwinge , gcc-patches References: <537ab396-e2eb-0c38-09fb-9a18f857f66c@codesourcery.com> Message-ID: <8993893f-5d53-6cfa-da65-68aeee2c3045@codesourcery.com> Date: Fri, 27 Nov 2020 11:22:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <537ab396-e2eb-0c38-09fb-9a18f857f66c@codesourcery.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-US X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-06.mgc.mentorg.com (139.181.222.6) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Nov 2020 10:22:11 -0000 Now committed as r11-5489-gf324479caf0ac326534f4fcf72cb12991ccddb3d Tobias On 25.11.20 12:00, Tobias Burnus wrote: > Here, the problem was that we were mixing types when calculating > the product of loop-steps, each type was taken from the loop var. > > Solution: take the largest type as diff_type and use it everywhere. > > And add a missing 'fold_convert' to fix the actual ICE. > > Comments? If not, I will commit it later. > > Tobias > ----------------- Mentor Graphics (Deutschland) GmbH, Arnulfstra=C3=9Fe 201, 80634 M=C3=BCnch= en / Germany Registergericht M=C3=BCnchen HRB 106955, Gesch=C3=A4ftsf=C3=BChrer: Thomas = Heurung, Alexander Walter