From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id C4CA2382C104 for ; Mon, 4 Dec 2023 20:15:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C4CA2382C104 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C4CA2382C104 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701720953; cv=none; b=g2g4J8r2IYwep6Yl7LuArdewfm5RCYP2RmOQxEu3+UUQm5E1Z2Zwrsyox31KYZIcxjQ53IcNh+ebyzQw+SsFgZJeoD2qdmmQk7JcbB7CrPT4xOulSuGblMLbvy6c/UCtqD+KkQoMrOxb3yZmTIQg54FI+ZrWq4d1zyzJB+8s9H0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701720953; c=relaxed/simple; bh=bUWWR7sDp3eeMPMfy8rOtZPtaAVhl7N1fFHWzmQ9wg0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=Jqe1xJVTtUiKTrWimvZjQYZEmywi8CLROqIlh7n0Ii1cDWDPzTyBw8mPSnTIg66SPEkx54AOxjy5nOL6fKFhlNpBP2GeRsVV56a7/XnW4QMYf7OeZv1yxjV483jcBnJYXlc4dr+GVpx6pP7RXImPPxbtxL32iUEE3djNEXWWajE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701720941; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UrugYF3G2nkimLyxuK0iBlqb3sAD1RQRBeZwAo9aRIU=; b=YWlS/4bC9arlBKUPHQkv18QnwTwGRuiks5cAn+7YwTtqianiARWtZv4ncowk3traPOIfkY zhkpzXyUL9/25jtGTuOzrZnjWmfYkCC1Bq7jRomt5l1VcR8afWAuZwoav3KeNfqbOtHic5 p9Urq096Ei4OXUuGY2Fpq40z9YTO9ks= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-46-wprONQ4YOoWPXKkBG0WoUg-1; Mon, 04 Dec 2023 15:15:40 -0500 X-MC-Unique: wprONQ4YOoWPXKkBG0WoUg-1 Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-425417112afso43392301cf.0 for ; Mon, 04 Dec 2023 12:15:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701720939; x=1702325739; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UrugYF3G2nkimLyxuK0iBlqb3sAD1RQRBeZwAo9aRIU=; b=wgplSfOi9F9F0H3WgLzr85HKB4KxzeGuxecaJhTU9cHEaF5qPGiMIHZ8NIWl5u1j/6 BRbhc6hfPvtrFgDeX6hDKj4Fz2KoeVUgZWCEwG84gbCBYc9zIu5ghWGE9cpmbkud6JEe g1tufj7WesAo34ev6nAZAauW3u3XIKI0fq7gqb95MDctyFIA4bLhwBu30BPXNXAMZioJ 7b143cW4Ludzy3/hR/sUSWXt4teu5UTzKzREqJmns7KuFhMV3LEBTQG4BqRh585LaRWb gyZ0N0pxlluT4oAjAvDuagaVAPEXoJnIKrAqR6nx8jkPDApHegCcxGh2iZBriWVvDwrm 9wXQ== X-Gm-Message-State: AOJu0Yy0Piu/ncIJhIG8yfB++CL5Ewg46wN7sbuRjOKJ0jhCNov4kn4h /n2nZvmsDwmzXuHHDQZyDUEzjduInN3v84yxbsb58zZ2U7uKcfb/BynrbOYS/wFueFVMeZXOdmc cQ9z1IEb6VyWCZDZiisFzJxTETuzYB2S0dxz8pY+6iSg3FRwvGZ7VtGLXUxjfApCkb4YrpTOCnN dvfA== X-Received: by 2002:ac8:5c4c:0:b0:425:4042:f457 with SMTP id j12-20020ac85c4c000000b004254042f457mr51300qtj.59.1701720939033; Mon, 04 Dec 2023 12:15:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IEdfA51803uXIUWciZrrns1h5c/TCxA6TvoXpyQHRS8SqN5uUX4815HwWu4XZXZcY1t+5ihpA== X-Received: by 2002:ac8:5c4c:0:b0:425:4042:f457 with SMTP id j12-20020ac85c4c000000b004254042f457mr51284qtj.59.1701720938719; Mon, 04 Dec 2023 12:15:38 -0800 (PST) Received: from [192.168.1.88] (23-233-12-249.cpe.pppoe.ca. [23.233.12.249]) by smtp.gmail.com with ESMTPSA id b6-20020ac844c6000000b00423e9316931sm4542133qto.83.2023.12.04.12.15.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Dec 2023 12:15:38 -0800 (PST) Message-ID: <8993908a-e12b-d50c-50ae-c994b926b3a5@redhat.com> Date: Mon, 4 Dec 2023 15:15:37 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] lra: Updates of biggest mode for hard regs [PR112278] To: gcc-patches@gcc.gnu.org, richard.sandiford@arm.com References: From: Vladimir Makarov In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/3/23 05:13, Richard Sandiford wrote: > [Gah. In my head I'd sent this a few weeks ago, but it turns out > that I hadn't even got to the stage of writing the changlog...] > > LRA keeps track of the biggest mode for both hard registers and > pseudos. The updates assume that the modes are ordered, i.e. that > we can tell whether one is no bigger than the other at compile time. > > That is (or at least seemed to be) a reasonable restriction for pseudos. > But it isn't necessarily so for hard registers, since the uses of hard > registers can be logically distinct. The testcase is an example of this. > > The biggest mode of hard registers is also special for other reasons. > As the existing comment says: > > /* A reg can have a biggest_mode of VOIDmode if it was only ever seen as > part of a multi-word register. In that case, just use the reg_rtx > mode. Do the same also if the biggest mode was larger than a register > or we can not compare the modes. Otherwise, limit the size to that of > the biggest access in the function or to the natural mode at least. */ > > This patch applies the same approach to the updates. > > Tested on aarch64-linus-gnu (with and without SVE) and on x86_64-linux-gnu. > OK to install? > Sure.  Thank you for fixing this, Richard.