From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x131.google.com (mail-il1-x131.google.com [IPv6:2607:f8b0:4864:20::131]) by sourceware.org (Postfix) with ESMTPS id B0C0F3858D38 for ; Thu, 3 Aug 2023 15:09:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B0C0F3858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-il1-x131.google.com with SMTP id e9e14a558f8ab-3493862cfb1so4061725ab.1 for ; Thu, 03 Aug 2023 08:09:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691075352; x=1691680152; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6qMIo44YReoM0dTYC0Sl+L2mIYnvw76x9HcVgVitsZ8=; b=GaIFqibURNYCxjLXk7u8HH+rlKWOA1zTO4bEOe3T5nZsLAgIROhPm34TBSqkI+LtyI s+D0QXngDggpu7c0+ilaI5TW31CJyKgLL9B9oDHaoXwvj3C6AarLZUFoyF5nISeAG756 Ghp5x7IMjPu+pvKdRfUzeWhdWIe5Jr5Nz+RwewIghP8wuWZSQO2OOO+e4px7TGonmo7+ cgAXGFHz5U/+dJeYPvovGWE96iAcWb2PwkZQPBN5pwcwmt6/AHTLiR1a8UuxyULcPPJy tcRpwIWI6gaLmqmOUzt2WjotVQ5dpSqYOkO8eI5aaEkIYIlpZf4sx8AW62Zo57yMHtAp /R2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691075352; x=1691680152; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6qMIo44YReoM0dTYC0Sl+L2mIYnvw76x9HcVgVitsZ8=; b=PYvENsaIA9MpIi+K2s5kmG/CkvwdAMzJi+/sWzfDA6OF7IDvLT73LJkz+urH4DTzMH eSgRI19/kMXd1ViMUqkT/IyYNOBU3GJw2JpK4OvO/Ne84LN4kLHcvM7EQmGZGot47XyD 97IjrZCL7HxatwqzheKLcqHYnJ5SIXJXdbEwpKrDtYvS9kl9ouD619T9XDtBTlH+wCMj gnEzow3bw6IXLj7Qmz6ukeU58vWxEoiyojt0mu6ojFhDvP6KwIgNrPq5398BE50LJY4g qhlplmugAOzdGW1rcKKqDQ6DMdzWo668+ugVElLqUa/8hnUEQMfu5C78G5mfOHFIPZCD SFhA== X-Gm-Message-State: ABy/qLaTqswEIt6g2GhLNxbh3dZ59IYpdCdOis6+8xV1jF5CRc+GxLep C/UtbqRRA5flEsrFSovyL7M= X-Google-Smtp-Source: APBJJlHguNOFb4Tz/06jHFKX3qfEHl2u9369i7vvllqMSxztbEJD4aO0MU32W/htUyt3iwxhuX7O3A== X-Received: by 2002:a05:6e02:1cae:b0:348:9fb8:abed with SMTP id x14-20020a056e021cae00b003489fb8abedmr22098162ill.27.1691075351882; Thu, 03 Aug 2023 08:09:11 -0700 (PDT) Received: from [172.31.1.103] ([172.58.35.95]) by smtp.gmail.com with ESMTPSA id o15-20020a92c68f000000b0034886587bdcsm37810ilg.18.2023.08.03.08.09.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Aug 2023 08:09:11 -0700 (PDT) Message-ID: <89dfe3c2-ef96-3000-de87-74ff83354adf@gmail.com> Date: Thu, 3 Aug 2023 09:09:08 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 3/5] [RISC-V] Generate Zicond instruction for select pattern with condition eq or neq to 0 Content-Language: en-US To: Kito Cheng Cc: Robin Dapp , gcc-patches , "kito.cheng" , zengxiao , =?UTF-8?B?6ZKf5bGF5ZOy?= References: <112f5c53-4809-b71d-2296-dfaebde733cb@gmail.com> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_NUMSUBJECT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 8/3/23 08:56, Kito Cheng wrote: >>>> That'll be the first thing to look at. THe costing change was supposed >>>> only affect if-then-else constructs, not sets in general. >>> >>> >>> If so, I think the most simple fix is adding more checks on the set >>> cost - only check the SET_SRC is if-then-else? >> No, the simple fix is to just remove the errant part of the commit :-0 >> My tests aren't done, but that does seem to dramatically help. Given it >> wasn't supposed to go in as-is and it's causing major problems, I'll >> probably just rip it out even though my testing isn't done. > > OK, so I'm going to retreat from there, I've another lld issue that > needs to be fixed before the LLVM 17 release :) Reversion of errant hunk has been pushed. Sorry for the problems folks. Had I known it was going to have this kind of fallout, I would have slammed a coke and fixed it last night before doing to sleep :-0 And yes, focusing on the lld issue seems wise given what I'm hearing in the LLVM meeting. Jeff