From: Iain Sandoe <iain@sandoe.co.uk>
To: GCC Patches <gcc-patches@gcc.gnu.org>
Cc: Mike Stump <mikestump@comcast.net>
Subject: [PATCH, committed] Enable ident for X86 Darwin.
Date: Sun, 23 Dec 2018 11:09:00 -0000 [thread overview]
Message-ID: <8AEDB591-2676-429D-9D1A-C71B591F3C4D@sandoe.co.uk> (raw)
Hi,
The c-c++-common tests fail (or XPASS depending on which) on Darwin
because it doesn't currently emit .ident marker. For X86 Darwin, this
is a trivial oversight; the assembler supports the directive. We can
therefore use the default target hook there.
I applied the following as obvious,
Iain
2018-12-23 Iain Sandoe <iain@sandoe.co.uk>
gcc/
* config/i386/darwin.h (TARGET_ASM_OUTPUT_IDENT): New.
diff --git a/gcc/config/i386/darwin.h b/gcc/config/i386/darwin.h
index 53789e7c23..f760218bda 100644
--- a/gcc/config/i386/darwin.h
+++ b/gcc/config/i386/darwin.h
@@ -219,6 +219,11 @@ extern int darwin_emit_branch_islands;
} \
} while (0)
+/* Darwin x86 assemblers support the .ident directive. */
+
+#undef TARGET_ASM_OUTPUT_IDENT
+#define TARGET_ASM_OUTPUT_IDENT default_asm_output_ident_directive
+
/* Darwin profiling -- call mcount. */
#undef FUNCTION_PROFILER
#define FUNCTION_PROFILER(FILE, LABELNO) \
--
2.17.1
reply other threads:[~2018-12-23 11:08 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8AEDB591-2676-429D-9D1A-C71B591F3C4D@sandoe.co.uk \
--to=iain@sandoe.co.uk \
--cc=gcc-patches@gcc.gnu.org \
--cc=mikestump@comcast.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).