From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 3FEAF3858D3C for ; Thu, 16 Sep 2021 17:11:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3FEAF3858D3C Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 18GGE2mP019755; Thu, 16 Sep 2021 17:11:21 GMT Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by mx0b-00069f02.pphosted.com with ESMTP id 3b3t92k8j1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 16 Sep 2021 17:11:21 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 18GGtgSF079622; Thu, 16 Sep 2021 17:11:20 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2171.outbound.protection.outlook.com [104.47.59.171]) by userp3020.oracle.com with ESMTP id 3b167vhy01-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 16 Sep 2021 17:11:19 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GaZULA0/GsCdk6wWNkVDp2qVus4wOQkUcehzgBo3E5vGIguSHKmpZEDMEUxK7zB/Af8rc4rsN8uCbFrqKlCTbv1VPSsdhFOHxKrLKK4OX23wnJnugCVsDg0HD61RYwqPO9jtbLPji92cXkj45T5pKQ66okesRNtCFeRt9O8CMPaxvH70bhI0sJeJegb89J0m0LXmfSFWw7zy//ZhlFpar08+WgzVEJqJI8bqwGQ7zbcUOQ6IZjDzCa+wcDoJgjQg3hs4xna5A+SaJGFlqH1HARb+LiFBu0x8SGEz+GUB5fgcTnc+viJgQMJhNeYGjqiHuMwbSqunYyeAgO2SJomEBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=xdFwcNJZC3bopoQzT0VPFLqmFcDdvY6TPwNFctr5Wh0=; b=PoogvbK73GEVM891l7nE/AYw6bzhkH7kl9A4MoJWMRFXlapuYc1ACrV/qtTlOM9Md9VTTiFhQXO3dUn58ozfE4K2YLCAUBRCyGqiDVd2+8bA1agase4HQtT0FyHeisFEkHu8bDx++e14yHya35h1dmYDlC+myOgjeznsP0lYdie3brBoXhGAtmlJS/lD1wGbE8mJAmmoVxjvvl2d9pN4V+lVCuK1DbU0MO579jpMUIVoLqvU1RSRQX1ugemrhXbUhmZCLSVIl3ANNQ9Uy1Z8G+cNvCC4LdZQG5R8Q9fqA/EHzqKjRA66teuEzYVGshtkveiJnppWbFAyrnvtVpgAGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from CH2PR10MB4344.namprd10.prod.outlook.com (2603:10b6:610:af::19) by CH0PR10MB5098.namprd10.prod.outlook.com (2603:10b6:610:da::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14; Thu, 16 Sep 2021 17:11:18 +0000 Received: from CH2PR10MB4344.namprd10.prod.outlook.com ([fe80::25f8:eaf:a3b9:fe86]) by CH2PR10MB4344.namprd10.prod.outlook.com ([fe80::25f8:eaf:a3b9:fe86%3]) with mapi id 15.20.4523.016; Thu, 16 Sep 2021 17:11:18 +0000 From: Qing Zhao To: Jakub Jelinek CC: Richard Biener , Richard Sandiford , Nick Alcock via Gcc-patches , kees Cook Subject: Re: [PATCH] testsuite: Fix c-c++-common/auto-init-* tests Thread-Topic: [PATCH] testsuite: Fix c-c++-common/auto-init-* tests Thread-Index: AQHXpuOQRqRwHnTWAku7skZ1NoVruqulaPgAgAEBGYCAAFw4gIAAAgwAgAAMCYCAAAIugIAAF2WA Date: Thu, 16 Sep 2021 17:11:18 +0000 Message-ID: <8B2A5603-0212-49CF-9CB9-6FA75104662C@oracle.com> References: <1F37A36D-A681-4EA8-B96B-0195AE707C91@oracle.com> <20210911080320.GA304296@tucnak> <9C40E343-B36F-46DC-8A41-383B8EF97A48@oracle.com> <20210916091917.GF304296@tucnak> <902D3C35-8E78-4A91-99A3-AD644A7A1F53@oracle.com> <20210916145640.GI304296@tucnak> <20210916154733.GJ304296@tucnak> In-Reply-To: <20210916154733.GJ304296@tucnak> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3608.120.23.2.7) x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b0f8fec1-9123-4262-a11f-08d97934ff99 x-ms-traffictypediagnostic: CH0PR10MB5098: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2043; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: AWparnUeKiG7cMojdAQT7BOg4fNAAZPoznvgTfbOa8ckE0hUS8acG1SOwpZQc5JxMrs44KbgkYm9Us1NsVCizzLvPtAQ7kJsMhPYgiOWngOJKhOH0/ggawXkd91EEfEy+X8PXsZN29YhEsLIdZjkbjMb2OhxHSmcPINYVp5y+rtl/+8+nbeNimyHmJLoYE4klb/veAnoQRaB2A/PC/QMSuwmirYCtMKYAlsGY5M7guUC8gEMaz1+fOadd07xUvtX7kNdrXpam49y+VSsVJT5LWzDkMig/47LQi8E0KqdfauJPZqR+nEAch/vIVgXlrh4JhiIAm/eFb32fmw2YHUwbkyDqpGhhP6QsFFjbf1eOn1ZbGfl9AGgQNz2RaGp7TrvbaQp5H//UVVHGZQxnDG0ggKbfW3ilm3TGaGbMb6mumziD/ualKzVTOdDhQLtFSQl5mTTM9Vzts43KTfhACuN9PZ2KDiEp/VCVjmpffsKi7pMk7+txw5STlWK+kKomcPkEbcYnL9nqd/kyu5qQHBeAjxPo2YiI9bg35TLC9yYGSkSoL7o8ws8xhGDAQKteZuKCeK2Zqvm9bDDVsscNTlPQv8/LMo9aT8UxraTNveOUODY9wYS/uYIBy2znL6rU01gvr8GlI5P3AhcBkIsWn8RCUhyUveUm25F5kOGf/dHF1p0UHOTiqfg5kDhkZuj95BEwr0a+FzIMyXpChyAg/UG17ZPy82ZTnWdW2zpQOjo3q0ftdVtw7T9KAD99D3mlydn x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR10MB4344.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(136003)(39860400002)(366004)(376002)(396003)(6486002)(8936002)(122000001)(478600001)(38100700002)(186003)(6512007)(44832011)(86362001)(5660300002)(71200400001)(54906003)(38070700005)(4326008)(2906002)(66556008)(66476007)(66946007)(2616005)(33656002)(66446008)(64756008)(6916009)(76116006)(91956017)(316002)(8676002)(36756003)(6506007)(53546011)(83380400001)(45980500001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?XL7tNWQ0sWZMQV85lM1xM7Ko/uRZ734c3evd7tRusY16L8PmEEGjHslisyqK?= =?us-ascii?Q?SvKK0wDhJXxJqMq1pnhJHG1zD8vQWhqHNmTqQJE8B9XU6f6CH/oeVr7PJKNs?= =?us-ascii?Q?56hdZBm/ZkbbhSs4vvstDCMoSE9KzXNsvBgBuYOKMX1tFzDVLnPZ0nH6FOg2?= =?us-ascii?Q?MckiUZVr6osEfe9Fc2lFvJsRH6LKGJ92sr7U0tmocWPsCrNKmYgFLnakNqfj?= =?us-ascii?Q?BFpLS0VDT1oiv4J/DeQdo2mjW3bOhhMiAw4b01QbHsQv8lXArfHjcu8o9yrp?= =?us-ascii?Q?x0idREzscNZrqxrePGKNcg7Nc0nRyxLmvWQIeOgEjKSS5cFJRPpOHgJw7OYZ?= =?us-ascii?Q?v1rKWSoNDCK++oC6cAR5QN0ekGEQ8/TXFtiQkwH37ZIS+XJkTUWggRetSwHs?= =?us-ascii?Q?GQT1k4B494c1xazCs7sbgt0Qou8ciWzaFm0fMFMcTw95eApDrYFzjGlEzNrp?= =?us-ascii?Q?QRbZS181X+69SVDANVQGGiYgkLg8tN/ZneJIQI2N/4RL4/BUnvHF2qRknksD?= =?us-ascii?Q?I3rjuamDsVBDtAltuj9HqjkUuKm/T6cK0KSdgCjeaZu45LKI1L5E3/qeH97s?= =?us-ascii?Q?v8fG+ytj/NMKOkwwQe/HP8fIom57wA9k7uYbystPsBpa/3CL4UZplO8k11MJ?= =?us-ascii?Q?/oNGSp2MewLoIwrxgO1Wqdvjg/y4Wz2zCBk1ee1FyPSTJWWg+GwwzvCXNcQ9?= =?us-ascii?Q?Bt9o5ffcN5ioZjfDMzIu2AEkdWz9FVzJaeP0Huh7//LAcSRBhf25ZQf/sT/o?= =?us-ascii?Q?xWmOeT49pH01ElTT0XF56U4JdLh+BJjMy9te2p9eKvuGMb7klVxfau+P10KF?= =?us-ascii?Q?abuzYmdRYIOcj2BqmIxvdL9fgPMgBP1/oz00j7WxEiuVZGwWJ1tWkahGWRTF?= =?us-ascii?Q?yfVcoRMEOSnI29PmyjqkNtpBKMhpwU0rpfzVECk4N7Ex+um6UwirAm2lHcO/?= =?us-ascii?Q?uj//B9QFXv/O3q+rPymuLpi3sgGPwjDBybjGeQV3osbBiDAsamslmeUVPbIB?= =?us-ascii?Q?al0O6MLfMUnemuW/RsxOqsZApZFzztKfGjdPv1eRBH3WXRhGLbtW96WALCr6?= =?us-ascii?Q?k3b1C5xHOP6NKHtePmVBZ4ufIwysvGqnB+uiscCO/5SB/zhhcFJkNrvuC74X?= =?us-ascii?Q?uVYfioN4rKM4RbrbK6hxP+I9eIQCv1EEd6eWMGwuSJ/zLSTE+2hI8g88KO41?= =?us-ascii?Q?uV5vQUujRqFRFjimCphUEE+WUACPBdVMU45gD3VVEVfGl2Wl09ns3wfXgEhv?= =?us-ascii?Q?Ya2idKPQ+bISLvrLaLawmcP6djWwReWy8uzSrQ0NH9VA2nByPr3UYrtiIS/H?= =?us-ascii?Q?MLLYDJc9nN04Hp4HwxWANbzpAjTXq4Hl0gUbBxrDDx7NcBN0qcx8mD5deM6k?= =?us-ascii?Q?19imuac=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-ID: <082C73E3176B2D4CB29B91E01B41530D@namprd10.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH2PR10MB4344.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b0f8fec1-9123-4262-a11f-08d97934ff99 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Sep 2021 17:11:18.1999 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ftS02Q7FHFrOA8OteWjBigTxFcQeYcBj242iZRYb/Ki7qap8FjF+nIu5UB6Y7yXlDzMI5Z9UilIliVn5pCVPTA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB5098 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10109 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 suspectscore=0 phishscore=0 mlxlogscore=999 malwarescore=0 mlxscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109030001 definitions=main-2109160100 X-Proofpoint-ORIG-GUID: CNHFnH7LehCNPhKW0oIWXPNH2hUPLhzG X-Proofpoint-GUID: CNHFnH7LehCNPhKW0oIWXPNH2hUPLhzG X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Sep 2021 17:11:29 -0000 > On Sep 16, 2021, at 10:47 AM, Jakub Jelinek wrote: >=20 > On Thu, Sep 16, 2021 at 03:39:46PM +0000, Qing Zhao wrote: >>> Even -mtune=3D is needed if you want to stay safe, otherwise people tes= ting >>> with --target_board=3Dunix/-mtune=3Dcascadelake (or whatever else) migh= t get >>> failures. >>=20 >> Okay. Will try this. >>>=20 >>>>> and ideally also -fno-stack-protector >>>>> -fno-stack-clash-protection etc. >>>>=20 >>>> Could you explain a little bit on this why? >>>=20 >>> In case people test e.g. with --target_board=3Dunix/\{,-fstack-protecto= r-all\} >>> etc. (e.g. in Fedora/RHEL we do). >>> For the RTL scanning checks if they are done fairly early, those option= s >>> might not change anything, but with the ones scanning in the assembly, >>> one needs to watch if those options don't add e.g. in the prologue or >>> epilogue further copies of the instructions you scan for. >>=20 >> I see.=20 >>=20 >> Thank you. >=20 > Basically, try to test with a bunch of semi-randomly chosen option sets a= nd > see what breaks and what works and then for the cases you think are commo= n > enough and worth adjusting testcases adjust them, otherwise add dg-option= s > to make sure the expected arch/tune/etc. are in effect. > make check-gcc RUNTESTFLAGS=3D'--target_board=3Dunix\{-m64,-m64/-march=3D= skylake-avx512,-m64/-fstack-protector-all,-m64/-fstack-clash-protection,-m3= 2/-mno-sse,-m32/-mtune=3Dbonnell,-m32/-march=3Dbonnell,-m32/-fstack-protect= or-all/-fstack-clash-protection\} i386.exp=3Dauto-init*' Thanks a lot for the suggestions and help, I will try this. Qing > etc. >=20 > Jakub >=20