* [PATCH] Testsuite, i386: Fix test by passing -march
@ 2023-10-30 11:53 FX Coudert
2023-10-30 12:02 ` Uros Bizjak
2023-10-30 12:05 ` Iain Sandoe
0 siblings, 2 replies; 5+ messages in thread
From: FX Coudert @ 2023-10-30 11:53 UTC (permalink / raw)
To: GCC Patches; +Cc: Iain Sandoe, ubizjak, pinskia
[-- Attachment #1: Type: text/plain, Size: 331 bytes --]
Hi,
The newly introduced test gcc.target/i386/pr111698.c currently fails on Darwin, where the default arch is core2.
Andrew suggested in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112287 to pass a recent value to -march, and I can confirm that it fixes the testsuite failure on x86_64-apple-darwin21.
OK to push?
FX
[-- Attachment #2: 0001-Testsuite-i386-Fix-test-by-passing-march.patch --]
[-- Type: application/octet-stream, Size: 979 bytes --]
From 5c7bbb0fcd70376d3895716d0ee33291bf4d8aff Mon Sep 17 00:00:00 2001
From: Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
Date: Mon, 30 Oct 2023 12:50:01 +0100
Subject: [PATCH] Testsuite, i386: Fix test by passing -march
The test currently fails on Darwin, where the default arch is core2.
gcc/testsuite/ChangeLog:
PR target/112287
* gcc.target/i386/pr111698.c: Pass -march=sandybridge.
---
gcc/testsuite/gcc.target/i386/pr111698.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gcc/testsuite/gcc.target/i386/pr111698.c b/gcc/testsuite/gcc.target/i386/pr111698.c
index 2da6be531a2..037000716f1 100644
--- a/gcc/testsuite/gcc.target/i386/pr111698.c
+++ b/gcc/testsuite/gcc.target/i386/pr111698.c
@@ -1,5 +1,5 @@
/* PR target/111698 */
-/* { dg-options "-O2 -masm=att" } */
+/* { dg-options "-O2 -masm=att -march=sandybridge" } */
/* { dg-final { scan-assembler-not "testl" } } */
int m;
--
2.39.3 (Apple Git-145)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Testsuite, i386: Fix test by passing -march
2023-10-30 11:53 [PATCH] Testsuite, i386: Fix test by passing -march FX Coudert
@ 2023-10-30 12:02 ` Uros Bizjak
2023-10-30 12:05 ` Iain Sandoe
1 sibling, 0 replies; 5+ messages in thread
From: Uros Bizjak @ 2023-10-30 12:02 UTC (permalink / raw)
To: FX Coudert; +Cc: GCC Patches, Iain Sandoe, pinskia
On Mon, Oct 30, 2023 at 12:53 PM FX Coudert <fxcoudert@gmail.com> wrote:
>
> Hi,
>
> The newly introduced test gcc.target/i386/pr111698.c currently fails on Darwin, where the default arch is core2.
> Andrew suggested in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112287 to pass a recent value to -march, and I can confirm that it fixes the testsuite failure on x86_64-apple-darwin21.
>
> OK to push?
OK.
Thanks,
Uros.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Testsuite, i386: Fix test by passing -march
2023-10-30 11:53 [PATCH] Testsuite, i386: Fix test by passing -march FX Coudert
2023-10-30 12:02 ` Uros Bizjak
@ 2023-10-30 12:05 ` Iain Sandoe
2023-10-30 19:04 ` Andrew Pinski
1 sibling, 1 reply; 5+ messages in thread
From: Iain Sandoe @ 2023-10-30 12:05 UTC (permalink / raw)
To: FX Coudert; +Cc: GCC Patches, Uros Bizjak, pinskia
> On 30 Oct 2023, at 11:53, FX Coudert <fxcoudert@gmail.com> wrote:
> The newly introduced test gcc.target/i386/pr111698.c currently fails on Darwin, where the default arch is core2.
> Andrew suggested in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112287 to pass a recent value to -march, and I can confirm that it fixes the testsuite failure on x86_64-apple-darwin21.
>
> OK to push?
Fine from a Darwin perspective,
we could also make it ...
dg-additional-options “ -march=sandybridge” { target *-*-darwin* }
… if that is deemed less invasive.
Iain
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Testsuite, i386: Fix test by passing -march
2023-10-30 12:05 ` Iain Sandoe
@ 2023-10-30 19:04 ` Andrew Pinski
2023-10-30 20:14 ` FX Coudert
0 siblings, 1 reply; 5+ messages in thread
From: Andrew Pinski @ 2023-10-30 19:04 UTC (permalink / raw)
To: Iain Sandoe; +Cc: FX Coudert, GCC Patches, Uros Bizjak
On Mon, Oct 30, 2023 at 5:05 AM Iain Sandoe <iain@sandoe.co.uk> wrote:
>
>
>
> > On 30 Oct 2023, at 11:53, FX Coudert <fxcoudert@gmail.com> wrote:
>
> > The newly introduced test gcc.target/i386/pr111698.c currently fails on Darwin, where the default arch is core2.
> > Andrew suggested in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112287 to pass a recent value to -march, and I can confirm that it fixes the testsuite failure on x86_64-apple-darwin21.
> >
> > OK to push?
>
> Fine from a Darwin perspective,
> we could also make it ...
> dg-additional-options “ -march=sandybridge” { target *-*-darwin* }
> … if that is deemed less invasive.
Well It can fail on x86_64-linux-gnu too if GCC was configured with
--with-arch=core2 for an example.
So having it, in this case, not being darwin specific would be
beneficial for all x86_64/i?86 targets.
Thanks,
Andrew
>
> Iain
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Testsuite, i386: Fix test by passing -march
2023-10-30 19:04 ` Andrew Pinski
@ 2023-10-30 20:14 ` FX Coudert
0 siblings, 0 replies; 5+ messages in thread
From: FX Coudert @ 2023-10-30 20:14 UTC (permalink / raw)
To: Andrew Pinski; +Cc: Iain Sandoe, GCC Patches, Uros Bizjak
> Well It can fail on x86_64-linux-gnu too if GCC was configured with
> --with-arch=core2 for an example.
> So having it, in this case, not being darwin specific would be
> beneficial for all x86_64/i?86 targets.
I pushed it as-is, meaning it will indeed apply to all x86_64/i?86 targets.
FX
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-10-30 20:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-30 11:53 [PATCH] Testsuite, i386: Fix test by passing -march FX Coudert
2023-10-30 12:02 ` Uros Bizjak
2023-10-30 12:05 ` Iain Sandoe
2023-10-30 19:04 ` Andrew Pinski
2023-10-30 20:14 ` FX Coudert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).