From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 77063 invoked by alias); 7 Jan 2016 00:08:44 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 77018 invoked by uid 89); 7 Jan 2016 00:08:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=3938 X-HELO: resqmta-po-08v.sys.comcast.net Received: from resqmta-po-08v.sys.comcast.net (HELO resqmta-po-08v.sys.comcast.net) (96.114.154.167) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 07 Jan 2016 00:08:42 +0000 Received: from resomta-po-17v.sys.comcast.net ([96.114.154.241]) by resqmta-po-08v.sys.comcast.net with comcast id 2o8f1s0055Clt1L01o8gMW; Thu, 07 Jan 2016 00:08:41 +0000 Received: from [IPv6:2001:558:6045:a4:40c6:7199:cd03:b02d] ([IPv6:2001:558:6045:a4:40c6:7199:cd03:b02d]) by resomta-po-17v.sys.comcast.net with comcast id 2o8f1s0032ztT3H01o8fUm; Thu, 07 Jan 2016 00:08:40 +0000 Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: [PATCH] c/68966 - atomic_fetch_* on atomic_bool not diagnosed From: Mike Stump In-Reply-To: <568DA56C.9030301@gmail.com> Date: Thu, 07 Jan 2016 00:08:00 -0000 Cc: Marek Polacek , Jeff Law , Gcc Patch List , "Joseph S. Myers" Content-Transfer-Encoding: 7bit Message-Id: <8E751E23-D023-4196-B557-9C78B9680A3A@comcast.net> References: <567A271B.2090403@gmail.com> <56877F8B.9010000@redhat.com> <5689E0F8.5050209@gmail.com> <20160104152239.GB31604@redhat.com> <568B19E8.1020709@gmail.com> <20160105105123.GD31604@redhat.com> <568C0F9C.2050505@gmail.com> <20160106115001.GH31604@redhat.com> <568DA56C.9030301@gmail.com> To: Martin Sebor X-IsSubscribed: yes X-SW-Source: 2016-01/txt/msg00280.txt.bz2 On Jan 6, 2016, at 3:38 PM, Martin Sebor wrote: >>> gcc/testsuite/ChangeLog: >>> 2016-01-04 Martin Sebor >>> >>> PR c/68966 >>> * gcc.dg/atomic-fetch-bool.c: New test. >>> * gcc.dg/sync-fetch-bool.c: Same. >> >> So the tradition is to repeat "New test." rather than to say "Same." > > Can we try not to make the rules any more rigid than they need > to be? As we just discussed, following the required formatting > rules is error-prone and time-consuming enough. GCC's own > Coding Conventions doesn't even require ChangeLog entries for > new tests (https://gcc.gnu.org/codingconventions.html#ChangeLogs). > People have been adding them and that's just fine with me, but > I can't discern any established convention when it comes to the > comment when a new test is being added. I see examples of "New > test" or "New file" followed by "Likewise" or "Ditto" as well > as "New test" followed by "Same". I see no point in adding yet > another hoop for people to have to remember to jump through. And I thought it was Likewise. :-) $ grep Same *ChangeLog* | wc -l 3938 $ grep Likewise *ChangeLog* | wc -l 69444