From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpbgbr1.qq.com (smtpbgbr1.qq.com [54.207.19.206]) by sourceware.org (Postfix) with ESMTPS id 4C4F73858D20 for ; Mon, 13 Nov 2023 03:34:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4C4F73858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivai.ai Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivai.ai ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4C4F73858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=54.207.19.206 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699846458; cv=none; b=McChSvVEGvImalnTw+0xyhIM81xJxE+xx+rmnqafbumkgQeLCO2RxCFtkCSKLaJn0jXb62g50PtnfjRxpgzJFu2z+CpT5fMVfc5cFDpnb26sYhXpASBWfaB45fYLorea7EzDn4Paf4pYFGijsRFp990J4Q0eRsXisqOVT46HOtU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699846458; c=relaxed/simple; bh=/D/FxeREXbEbYCXyy/VlA+SthOq0KTObJUKqWLJoA2Y=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=OUNChUJaAoibOzC/rJCtgKkY5JbrRaHynzcgUYD1dSE2rLo3Y2vfIeR+xt+0UY9K4X195PiRn+c6wpGfy1nr6l/XEIOO6JdjGVC8q9aMJ5w93WFHDV5sy1pbbzT2G0QFiHuwAmh59jmSO2HWy9iCstZ4HuMPQKXCvPKoBD13dq4= ARC-Authentication-Results: i=1; server2.sourceware.org X-QQ-mid: bizesmtp78t1699846444tw2lfsp3 Received: from [10.101.11.9] ( [121.35.182.237]) by bizesmtp.qq.com (ESMTP) with id ; Mon, 13 Nov 2023 11:34:03 +0800 (CST) X-QQ-SSF: 01400000000000C0F000000A0000000 X-QQ-FEAT: 90EFqYDyPxCpd1JRz3owSbYa+Nk3rmjWjZI/gw8wxsgfwT7+25FsKQeEQxUF0 qzd4YR5AVEB85jn8zRoTbbeZanIJX76lXuJURdYworwzPqe64oH8IJ+5Zzx1EnmMr1yQX4b kTlz6jHhgfgJQaMQ6/aub6XKd2XnZG6klAPd/mNk+IrVvIb+GBy+Gxk2LykjnHeLY5uvZuy 17frl+I4md9zVhVxxmMyiJCNlRniRLVHstqkd7ti8cdrHy94VeeeplgHuZfCqLYWA5AW48Y Akl3OUlJOq7xV+BjcN+Nn80Thqko/8uvyQFAWzmbXbyZAzVLsmjxvpRGU2CLGS+Yzgcu4bx B2WO/5+ls/JKoywfjHcwixoTL0TV6dabdbbaABn X-QQ-GoodBg: 2 X-BIZMAIL-ID: 12880430271457338998 Message-ID: <8EED9555B9D9A20C+3743277b-5069-49fb-bfa2-bb9c30e880dd@rivai.ai> Date: Mon, 13 Nov 2023 11:34:03 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/7] ira/lra: Support subreg coalesce Content-Language: en-US To: "juzhe.zhong@rivai.ai" , "richard.sandiford" Cc: jeffreyalaw , gcc-patches , "vmakarov@redhat.com" References: <20231108034740.834590-1-lehua.ding@rivai.ai> <3d6ec0ee-6542-4b6a-a2cd-7fd54c136af9@gmail.com> <3D45AF37B3B11CB0+2023111209160809613957@rivai.ai> From: Lehua Ding In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:rivai.ai:qybglogicsvrgz:qybglogicsvrgz6a-0 X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,FORGED_MUA_MOZILLA,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023/11/13 9:11, juzhe.zhong@rivai.ai wrote: >>> Ah, nice!  How configurable are the bit ranges? > I think Lehua's patch is configurable for bit ranges. > Since his patch allow target flexible tracking subreg livenesss > according to REGMODE_NATURAL_SIZE > > +/* Return true if REGNO is a pseudo and MODE is a multil regs size. */ > +bool > +need_track_subreg (int regno, machine_mode reg_mode) > +{ > + poly_int64 total_size = GET_MODE_SIZE (reg_mode); > + poly_int64 natural_size = REGMODE_NATURAL_SIZE (reg_mode); > + return maybe_gt (total_size, natural_size) > + && multiple_p (total_size, natural_size) > + && regno >= FIRST_PSEUDO_REGISTER; > +} > > It depends on how targets configure REGMODE_NATURAL_SIZE target hook. > > If we return QImode size, his patch is enable tracking bit ranges 7 bits > subreg. Yes, the current subreg_ranges class provides remove_range/add_range/remove_ranges/add_ranges interfaces to modify ranges. Each subreg_range contains start and end fields representing the range [start, end). For live_subreg problem, the value returned by REGMODE_NATURAL_SIZE is used as the unit, for bit track like Jeff's side, it can be used bit as the unit. -- Best, Lehua (RiVAI) lehua.ding@rivai.ai