From: Pat Haugen <pthaugen@linux.ibm.com>
To: GCC Patches <gcc-patches@gcc.gnu.org>,
Segher Boessenkool <segher@kernel.crashing.org>,
"Kewen.Lin" <linkw@linux.ibm.com>,
Peter Bergner <bergner@linux.ibm.com>,
David Edelsohn <dje.gcc@gmail.com>
Subject: PING^3: [PATCH V4, rs6000] Disable generation of scalar modulo instructions
Date: Wed, 9 Aug 2023 13:33:46 -0500 [thread overview]
Message-ID: <8a160b5a-7744-be86-3ca0-b30fe0853813@linux.ibm.com> (raw)
In-Reply-To: <57a342c8-c3ae-b12b-f73a-9dc428acc91e@linux.ibm.com>
Ping.
On 6/30/23 2:26 PM, Pat Haugen via Gcc-patches wrote:
> Updated from prior version to address latest review comment (simplify
> umod<mode>3).
>
> Disable generation of scalar modulo instructions.
>
> It was recently discovered that the scalar modulo instructions can suffer
> noticeable performance issues for certain input values. This patch disables
> their generation since the equivalent div/mul/sub sequence does not suffer
> the same problem.
>
> Bootstrapped and regression tested on powerpc64/powerpc64le.
> Ok for master and backports after burn in?
>
> -Pat
>
>
> 2023-06-30 Pat Haugen <pthaugen@linux.ibm.com>
>
> gcc/
> * config/rs6000/rs6000.cc (rs6000_rtx_costs): Check if disabling
> scalar modulo.
> * config/rs6000/rs6000.h (RS6000_DISABLE_SCALAR_MODULO): New.
> * config/rs6000/rs6000.md (mod<mode>3, *mod<mode>3): Disable.
> (define_expand umod<mode>3): New.
> (define_insn umod<mode>3): Rename to *umod<mode>3 and disable.
> (umodti3, modti3): Disable.
>
> gcc/testsuite/
> * gcc.target/powerpc/clone1.c: Add xfails.
> * gcc.target/powerpc/clone3.c: Likewise.
> * gcc.target/powerpc/mod-1.c: Update scan strings and add xfails.
> * gcc.target/powerpc/mod-2.c: Likewise.
> * gcc.target/powerpc/p10-vdivq-vmodq.c: Add xfails.
next prev parent reply other threads:[~2023-08-09 18:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 19:26 Pat Haugen
2023-07-13 20:17 ` Pat Haugen
2023-08-01 19:19 ` PING ^2: " Pat Haugen
2023-08-09 18:33 ` Pat Haugen [this message]
2023-09-08 15:44 ` PING^4: " Pat Haugen
2023-09-13 20:48 ` Segher Boessenkool
2023-09-19 20:09 ` Pat Haugen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a160b5a-7744-be86-3ca0-b30fe0853813@linux.ibm.com \
--to=pthaugen@linux.ibm.com \
--cc=bergner@linux.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=linkw@linux.ibm.com \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).