From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 70CBC3858407 for ; Tue, 5 Dec 2023 02:29:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 70CBC3858407 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=loongson.cn ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 70CBC3858407 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701743351; cv=none; b=FSu5Bl2Cm5JGse+Lldb2n8z9iL/ieud+lOCyaIY1jv5EZBO1f3NWe66ga1GUyJNexMKz8Dbe4p55fiALdwWyKNNvmWdXM2cnY2mXN3mImQ11fy5OKm3D6LnSp86dNx4/iJxqreidELr3LkK3SPOHLQaWXo088EKsSGoexFfDL90= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701743351; c=relaxed/simple; bh=qonIQ0VuGjWiSATxxKY75MgPDnRdhCsATcZY4oVqAGE=; h=Subject:To:From:Message-ID:Date:MIME-Version; b=m1ihT9n8b00bb/BJ/4JJcx0IMd/qTEu/7XJTVkL0j8xnzX0TY894iQu7Q077kV83FLn87Uo1YMKUCmn8yXny+F+PodvmLYTvbZsvJW4fr3Ii1PjhRA195hCWTTP3moDrM768X6mJPLl+EbslXD5QEHsI75iweX6E1C52nyg+qS4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from mail.loongson.cn ([114.242.206.163]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rALBB-00012N-Ay for gcc-patches@gcc.gnu.org; Mon, 04 Dec 2023 21:29:00 -0500 Received: from loongson.cn (unknown [10.20.4.107]) by gateway (Coremail) with SMTP id _____8Dx_+vdim5l7+0+AA--.58734S3; Tue, 05 Dec 2023 10:28:46 +0800 (CST) Received: from [10.20.4.107] (unknown [10.20.4.107]) by localhost.localdomain (Coremail) with SMTP id AQAAf8Ax3tzcim5l3ghVAA--.55927S3; Tue, 05 Dec 2023 10:28:45 +0800 (CST) Subject: Re: [PATCH v1 1/2] LoongArch: Switch loongarch-def from C to C++ to make it possible. To: Xi Ruoyao , gcc-patches@gcc.gnu.org Cc: i@xen0n.name, xuchenghua@loongson.cn References: <20231202081441.4799-1-chenglulu@loongson.cn> <20231202081441.4799-2-chenglulu@loongson.cn> <81be50dd-a5ab-8669-d0b8-f60571b7d032@loongson.cn> <277055d68e16fb763e52faf646ec868c36281be7.camel@xry111.site> From: chenglulu Message-ID: <8a491f51-0d50-4db0-e0ca-1fef40783c3e@loongson.cn> Date: Tue, 5 Dec 2023 10:28:44 +0800 User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <277055d68e16fb763e52faf646ec868c36281be7.camel@xry111.site> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID:AQAAf8Ax3tzcim5l3ghVAA--.55927S3 X-CM-SenderInfo: xfkh0wpoxo3qxorr0wxvrqhubq/ X-Coremail-Antispam: 1Uk129KBj9xXoWrKr15Xw4UXw4UJr4xur47WrX_yoWfKrg_Za 1q9ryDu3yfJa1DJrsaqwn09F97Jr4jy342qr48Aw4agryUA3s5WFn09F93Zr48K3ykKFs8 GF95Xa13Z34UuosvyTuYvTs0mTUanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUj1kv1TuYvT s0mT0YCTnIWjqI5I8CrVACY4xI64kE6c02F40Ex7xfYxn0WfASr-VFAUDa7-sFnT9fnUUI cSsGvfJTRUUUbxAYFVCjjxCrM7AC8VAFwI0_Jr0_Gr1l1xkIjI8I6I8E6xAIw20EY4v20x vaj40_Wr0E3s1l1IIY67AEw4v_JrI_Jryl8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxS w2x7M28EF7xvwVC0I7IYx2IY67AKxVW8JVW5JwA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxV W8JVWxJwA2z4x0Y4vEx4A2jsIE14v26F4j6r4UJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_ Gr1j6F4UJwAS0I0E0xvYzxvE52x082IY62kv0487Mc804VCY07AIYIkI8VC2zVCFFI0UMc 02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUGVWUXwAv7VC2z280aVAF wI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcVAKI48JMxk0xIA0c2IEe2xFo4 CEbIxvr21l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG 67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMI IYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E 14v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJV W8JwCI42IY6I8E87Iv6xkF7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x07URa0PU UUUU= Received-SPF: pass client-ip=114.242.206.163; envelope-from=chenglulu@loongson.cn; helo=mail.loongson.cn X-Spam_score_int: -59 X-Spam_score: -6.0 X-Spam_bar: ------ X-Spam_report: (-6.0 / 5.0 requ) BAYES_00=-1.9,NICE_REPLY_A=-4.096,SPF_HELO_NONE=0.001,SPF_PASS=-0.001,T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00,BODY_8BITS,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_FAIL,SPF_HELO_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: 在 2023/12/2 下午9:41, Xi Ruoyao 写道: > On Sat, 2023-12-02 at 20:44 +0800, chenglulu wrote: >>>> @@ -657,12 +658,18 @@ abi_str (struct loongarch_abi abi) >>>>          strlen (loongarch_abi_base_strings[abi.base])); >>>>      else >>>>        { >>>> +      /* This situation has not yet occurred, so in order to avoid >>>> the >>>> + -Warray-bounds warning during C++ syntax checking, this part >>>> + of the code is commented first.*/ >>>> +      /* >>> Just put a "gcc_unreachable ();" here? >> Um, I just thought that the code can't go here, I will add a prompt >> message here.:-( > If I read the code correctly, this is indeed unreachable so we can just > put gcc_unreachable() here. But maybe I'm wrong. > I agree that if it runs this far, it's a problem with the code design. In addition,I've sorted out the patches to remove the unnecessary guards., and I will send the v2 version of the patch immediately.