From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 62924 invoked by alias); 18 May 2016 09:40:57 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 62774 invoked by uid 89); 18 May 2016 09:40:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 18 May 2016 09:40:44 +0000 Received: from svr-orw-fem-04.mgc.mentorg.com ([147.34.97.41]) by relay1.mentorg.com with esmtp id 1b2xy5-0003kp-DT from ChungLin_Tang@mentor.com ; Wed, 18 May 2016 02:40:41 -0700 Received: from [0.0.0.0] (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.3.224.2; Wed, 18 May 2016 02:40:41 -0700 Subject: Re: [PATCH, libgomp] Rewire OpenACC async To: Jakub Jelinek References: <56543B8C.404@codesourcery.com> <567910D1.1060306@codesourcery.com> <56FA4F69.1060101@codesourcery.com> <20160512100258.GV28550@tucnak.redhat.com> <87y47fv9hl.fsf@hertz.schwinge.homeip.net> <20160512105637.GA28550@tucnak.redhat.com> <63d939c4-5460-cc37-6518-fe5fddeedb90@codesourcery.com> <20160517090059.GG28550@tucnak.redhat.com> CC: Thomas Schwinge , gcc-patches , Cesar Philippidis , Julian Brown From: Chung-Lin Tang Message-ID: <8a82dd86-a4d8-28f7-8464-71a84b3c3071@codesourcery.com> Date: Wed, 18 May 2016 09:40:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <20160517090059.GG28550@tucnak.redhat.com> Content-Type: multipart/mixed; boundary="------------FBB5A267CF553DF783B1300D" X-IsSubscribed: yes X-SW-Source: 2016-05/txt/msg01325.txt.bz2 --------------FBB5A267CF553DF783B1300D Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Content-length: 680 On 2016/5/17 5:00 PM, Jakub Jelinek wrote: > On Tue, May 17, 2016 at 04:56:42PM +0800, Chung-Lin Tang wrote: >> I assume that bumping GOMP_VERSION in include/gomp-constants.h would be enough? > > I think so. > > Jakub > How is this patch? I have added a comment to remind to adjust the version number when plugin interface changes are made. And, if this approach to solve the plugin interface problem is okay, can I regard the device lock deadlock patches and async patch approved for trunk? Thanks, Chung-Lin include/ * gomp-constants.h (GOMP_VERSION): Increment to 1, add comment describe the need for increment this macro whenever the plugin interface is modified. --------------FBB5A267CF553DF783B1300D Content-Type: text/plain; charset="UTF-8"; x-mac-type=0; x-mac-creator=0; name="a.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="a.diff" Content-length: 690 Index: gomp-constants.h =================================================================== --- gomp-constants.h (revision 236363) +++ gomp-constants.h (working copy) @@ -196,8 +196,10 @@ enum gomp_map_kind /* Internal to libgomp. */ #define GOMP_TARGET_FLAG_UPDATE (1U << 31) -/* Versions of libgomp and device-specific plugins. */ -#define GOMP_VERSION 0 +/* Versions of libgomp and device-specific plugins. GOMP_VERSION + should be incremented whenever an ABI-incompatible change is introduced + to the plugin interface defined in libgomp/libgomp.h. */ +#define GOMP_VERSION 1 #define GOMP_VERSION_NVIDIA_PTX 1 #define GOMP_VERSION_INTEL_MIC 0 #define GOMP_VERSION_HSA 0 --------------FBB5A267CF553DF783B1300D--