From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2176 invoked by alias); 25 Jun 2018 16:02:27 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 2167 invoked by uid 89); 25 Jun 2018 16:02:27 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:2094 X-HELO: mx2.suse.de Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 25 Jun 2018 16:02:22 +0000 Received: from relay1.suse.de (charybdis-ext-too.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 281E1AC80; Mon, 25 Jun 2018 16:02:20 +0000 (UTC) Subject: Re: [PATCH][testsuite/guality] Be verbose about gdb version used To: Andreas Schwab Cc: Christophe Lyon , Jeff Law , gcc Patches , Mike Stump , Rainer Orth References: <20180622113456.r4pnsat4yz3qwac5@localhost.localdomain> <54fe6363-3dc4-5cde-8ba4-e7b536405a3e@redhat.com> <2cd780b2-e28b-c782-ecef-4f6932afb196@suse.de> From: Tom de Vries Message-ID: <8a851cf2-5935-6d5f-75e5-8fbfff403c12@suse.de> Date: Mon, 25 Jun 2018 16:02:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------71461538029FE4707B665BF0" X-IsSubscribed: yes X-SW-Source: 2018-06/txt/msg01562.txt.bz2 This is a multi-part message in MIME format. --------------71461538029FE4707B665BF0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-length: 1214 On 06/25/2018 04:36 PM, Andreas Schwab wrote: > On Jun 25 2018, Tom de Vries wrote: > >> @@ -151,6 +151,9 @@ proc report_gdb { gdb loc } { >> } >> set gdb [exec which $gdb] >> send_log "gdb used in $loc: $gdb\n" >> - set gdb_version [exec $gdb -v] >> + if { [catch { set gdb_version [exec $gdb -v] }] } { >> + send_log "gdb used in $loc: getting version failed\n" >> + return >> + } >> send_log "gdb used in $loc: version:\n---\n$gdb_version\n---\n" >> } > > How about this instead: > > diff --git a/gcc/testsuite/lib/gcc-gdb-test.exp b/gcc/testsuite/lib/gcc-gdb-test.exp > index 9aff6218300..26fb7cd2f4d 100644 > --- a/gcc/testsuite/lib/gcc-gdb-test.exp > +++ b/gcc/testsuite/lib/gcc-gdb-test.exp > @@ -151,6 +151,6 @@ proc report_gdb { gdb loc } { > } > set gdb [exec which $gdb] > send_log "gdb used in $loc: $gdb\n" > - set gdb_version [exec $gdb -v] > + catch { exec $gdb -v } gdb_version > send_log "gdb used in $loc: version:\n---\n$gdb_version\n---\n" > } Hmm, eliminating the set in the catch body is a good idea. But I want to start with a note that running gdb -v failed. Committed as attached. Thanks, - Tom --------------71461538029FE4707B665BF0 Content-Type: text/x-patch; name="0001-testsuite-guality-Fix-tcl-error-on-gdb-v-failure.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename*0="0001-testsuite-guality-Fix-tcl-error-on-gdb-v-failure.patch" Content-length: 926 [testsuite/guality] Fix tcl error on gdb -v failure 2018-06-25 Tom de Vries * lib/gcc-gdb-test.exp (report_gdb): Handle gdb -v failure. --- gcc/testsuite/lib/gcc-gdb-test.exp | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/gcc/testsuite/lib/gcc-gdb-test.exp b/gcc/testsuite/lib/gcc-gdb-test.exp index 9aff6218300..2ef9ca15c12 100644 --- a/gcc/testsuite/lib/gcc-gdb-test.exp +++ b/gcc/testsuite/lib/gcc-gdb-test.exp @@ -151,6 +151,12 @@ proc report_gdb { gdb loc } { } set gdb [exec which $gdb] send_log "gdb used in $loc: $gdb\n" - set gdb_version [exec $gdb -v] - send_log "gdb used in $loc: version:\n---\n$gdb_version\n---\n" + + send_log "gdb used in $loc: " + if { [catch { exec $gdb -v } gdb_version] } { + send_log "getting version failed:\n" + } else { + send_log "version:\n" + } + send_log -- "---\n$gdb_version\n---\n" } --------------71461538029FE4707B665BF0--