From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by sourceware.org (Postfix) with ESMTPS id 757AC3858D1E for ; Sun, 1 Oct 2023 14:36:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 757AC3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-690d8fb3b7eso14209149b3a.1 for ; Sun, 01 Oct 2023 07:36:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696171005; x=1696775805; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hGYcI5dZE12GHShMfD7eEaaAP2ULxQjSSY1mfVSR2UI=; b=LVu4baD/QcoJV4GnFzS49/a+CkYwfAuWLemDp/JCd+2E+zD3+Efpj94bE2FtpJVN3O pSEHJmiGnDQt/XVGxjxHRatqIdGcbwa71YustMK2BUiX4OHAUPDpoiXq5EksoRl03jzG aRBAqsMQBepHdEq+zlWVEvr20KkeTS+pvns3UFWyKL276MkmKrXNq0X11l1JovezBE50 s0RaGAiENYuOQg06fivXy87qgqspg2IpTHEIiafEY7b/0Q6FxWUDdI3OGdwJME+HBnq6 EGkKMTgK60eDjaJrYO79+mBq2Fge5JH+JdJ+7rUlFr8cz8V21HAhfdwV5rVLC/ydWOZQ 1BoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696171005; x=1696775805; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hGYcI5dZE12GHShMfD7eEaaAP2ULxQjSSY1mfVSR2UI=; b=EFo13Sc4QvOrU0qEzLQWuNfmVR36yxzvVMhakTyrvehDJOrHkA2GFbre63MykOCwIa Kh5M5Nd5ycfcVc+NdUOq393nYGQ8nimCGgHHXv9gmU8O1kOhJgeRimMgEbZLlg4BSmoD Wmb1Q4n4WiVoY8m3qwvbPtiZUYxT8+xRlzn68X7hrhOeAlJ0L89mu+toU+f95jHZt71n yJYmAK1lXiNzxZuSTqS1CqmHmBaTRHrh83zifPsWsTN3wnAA6Nw1r/Ks5wNa0QvZn81+ yEsHsQrgQcykT0QS/UBaozBQWxJGN3T55tN3MmaFlZNKHHxSe+g7DZ0s49jwDxhuo324 kiiA== X-Gm-Message-State: AOJu0YxOd5OpsW8vsNbSg6cmywoCqhjHTjFkuzdK15RuHI5PNTaMg0T/ j9R34vH3bLamtdzuX5zSDWHIGBqjW8Q= X-Google-Smtp-Source: AGHT+IHHXmaimyOdK83GPcOAGsfG/6r3VSuOJMtwutjpR/oLTNaQFHEcmlOZRvrgKWDHJZTK88Er1g== X-Received: by 2002:a05:6a00:15c7:b0:690:fa09:61d3 with SMTP id o7-20020a056a0015c700b00690fa0961d3mr12021051pfu.15.1696171005198; Sun, 01 Oct 2023 07:36:45 -0700 (PDT) Received: from [172.31.1.103] ([172.56.168.69]) by smtp.gmail.com with ESMTPSA id m26-20020aa78a1a000000b0068fd026b496sm17943952pfa.46.2023.10.01.07.36.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 01 Oct 2023 07:36:44 -0700 (PDT) Message-ID: <8aa6921a-c308-4e01-b1f5-856af9d52f33@gmail.com> Date: Sun, 1 Oct 2023 08:36:42 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] rtl-optimization/110939 Really fix narrow comparison of memory and constant Content-Language: en-US To: Stefan Schulze Frielinghaus , Eric Botcazou Cc: gcc-patches@gcc.gnu.org, Xi Ruoyao References: <20230810130402.752335-2-stefansf@linux.ibm.com> <38e00e90-d6f7-4316-b325-4695bc353517@gmail.com> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/1/23 08:26, Stefan Schulze Frielinghaus wrote: >> FWIW, I should definitely have caught this hunk earlier -- we've gone the >> rounds in this same space (GEN_INT vs gen_int_mode) elsewhere. >> >> Again, sorry for the long wait. >> >> jeff > > No worries at all. At least I have learned something new :) > > Thanks Jeff and Eric for clarification. This matches with my intuition, > now, so I've pushed the patch. BTW, in a completely different context I need to do some testing on the alpha port, which hasn't bootstrapped in a couple months. I'd been assuming the failure was completely due to ongoing changes I'm making in the infrastructure I used to bootstrap QEMU emulated systems. As it turns out, the infrastructure changes and this minor combine issue were both playing a role! Jeff