From: Jeff Law <law@redhat.com>
To: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: [PATCH][committed][PR tree-optimization/82123] 01/06 Do nothing in EVRP analyzer is not optimizing
Date: Tue, 20 Feb 2018 18:49:00 -0000 [thread overview]
Message-ID: <8ab6de14-3e50-37bb-4c15-f25b788875d8@redhat.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 498 bytes --]
This is part #1 of the patches to fix 81592/82123. The changes aren't
particularly large or invasive, but I already had them broken down
internally into distinct chunks, so I'm going to send them out that way.
This patch allows the EVRP range analyzer to be safely called even when
not optimizing. It does no analysis in that case. This prevents
problems if we were to ask for sprintf warnings but not have the
optimizer enabled.
Bootstrapped and regression tested on x86_64-linux-gnu.
Jeff
[-- Attachment #2: P1 --]
[-- Type: text/plain, Size: 1047 bytes --]
* gimple-ssa-evrp-analyze.c (evrp_range_analyzer::enter): Do nothing
if not optimizing.
(evrp_range_analyzer::record_ranges_from_stmt): Likewise.
(evrp_range_analyzer::pop_to_marker): Likewise.
diff --git a/gcc/gimple-ssa-evrp-analyze.c b/gcc/gimple-ssa-evrp-analyze.c
index 2eb2769..b9dcf90 100644
--- a/gcc/gimple-ssa-evrp-analyze.c
+++ b/gcc/gimple-ssa-evrp-analyze.c
@@ -69,6 +69,8 @@ evrp_range_analyzer::push_marker ()
void
evrp_range_analyzer::enter (basic_block bb)
{
+ if (!optimize)
+ return;
push_marker ();
record_ranges_from_incoming_edge (bb);
record_ranges_from_phis (bb);
@@ -279,6 +281,9 @@ evrp_range_analyzer::record_ranges_from_stmt (gimple *stmt, bool temporary)
{
tree output = NULL_TREE;
+ if (!optimize)
+ return;
+
if (dyn_cast <gcond *> (stmt))
;
else if (stmt_interesting_for_vrp (stmt))
@@ -390,6 +395,8 @@ evrp_range_analyzer::pop_to_marker (void)
void
evrp_range_analyzer::leave (basic_block bb ATTRIBUTE_UNUSED)
{
+ if (!optimize)
+ return;
pop_to_marker ();
}
next reply other threads:[~2018-02-20 18:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-20 18:49 Jeff Law [this message]
2018-02-26 12:27 ` Richard Biener
2018-02-26 19:48 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ab6de14-3e50-37bb-4c15-f25b788875d8@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).