public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Daniel Santos <daniel.santos@pobox.com>
To: gcc-patches <gcc-patches@gcc.gnu.org>,
	Uros Bizjak <ubizjak@gmail.com>, Jan Hubicka <hubicka@ucw.cz>,
	"H.J. Lu" <hjl.tools@gmail.com>, Martin Liska <mliska@suse.cz>,
	Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>,
	Mike Stump <mikestump@comcast.net>
Subject: PING Re: [PATCH 0/6] [i386] PR80969 Fix ICE with -mabi=ms -mavx512f
Date: Tue, 08 Aug 2017 19:31:00 -0000	[thread overview]
Message-ID: <8ac6dd17-e11c-a767-5d33-d3ec16b5b856@pobox.com> (raw)
In-Reply-To: <ef1171ca-bb17-c362-a5e8-231bf7700f79@pobox.com>

[-- Attachment #1: Type: text/plain, Size: 1111 bytes --]

Original message: https://gcc.gnu.org/ml/gcc-patches/2017-07/msg02005.html

Patches 2 and 3 have been committed and I have corrected the error in
patch 5.  I configuring with --enable-checking=yes,rtl
--enable-languages=all and retested with
RUNTESTFLAGS="--target_board=unix/\{,-m32\}"  The updated patches fix an
error when using mov instead of push and add documentation for changes
to target-supports.exp.  I have included modified ChangeLogs.

In addition to to fixing the ICE, this patch set makes more efficient
use of stack space in some cases the outgoing stack boundary is > 16
bytes and realignment is necessary.  This adds new tests, some of which
require avx512f (gcc/testsuite/gcc.target/i386/pr80969-4*.c) -- these I
have only tested these using Intel SDE.

Below is an updated list of the patches.

1. https://gcc.gnu.org/ml/gcc-patches/2017-07/msg02006.html
2. Committed.
3. Committed.
4. https://gcc.gnu.org/ml/gcc-patches/2017-07/msg02009.html
5. v2 -- https://gcc.gnu.org/ml/gcc-patches/2017-08/msg00249.html
6. v2 -- https://gcc.gnu.org/ml/gcc-patches/2017-08/msg00618.html

Thanks,
Daniel

[-- Attachment #2: pr80969.gcc.ChangeLog --]
[-- Type: text/plain, Size: 661 bytes --]

2017-08-08  Daniel Santos  <daniel.santos@pobox.com>

	* config/i386/i386.h (ix86_frame::stack_realign_allocate_offset):
	Remove
	(ix86_frame::stack_realign_allocate): New field.
	(struct machine_frame_state): Modify comments.
	(machine_frame_state::sp_realigned_fp_end): New field.
	* config/i386/i386.c (ix86_compute_frame_layout): Modify.
	(sp_valid_at): Likewise.
	(fp_valid_at): Likewise.
	(choose_baseaddr): Modify comments.
	(ix86_emit_outlined_ms2sysv_save): Modify.
	(ix86_expand_prologue): Likewise.
	* doc/sourcebuild.texi (avx2, avx2_runtime): Add missing items to
	effective-targets.
	(avx512f, avx512f_runtime): Add new items to effective-tarets.

[-- Attachment #3: pr80969.gcc.testsuite.ChangeLog --]
[-- Type: text/plain, Size: 570 bytes --]

2017-08-08  Daniel Santos  <daniel.santos@pobox.com>

	* lib/target-supports.exp (check_avx512_os_support_available): New
	Procedure.
	(check_avx2_hw_available): Modify.
	(check_avx512f_hw_available): New Procedure.
	(check_effective_target_avx512f_runtime): Likewise.
	* gcc.target/i386/pr80969-1.c: New testcase.
	* gcc.target/i386/pr80969-2a.c: Likewise.
	* gcc.target/i386/pr80969-2.c: Likewise.
	* gcc.target/i386/pr80969-3.c: Likewise.
	* gcc.target/i386/pr80969-4a.c: Likewise.
	* gcc.target/i386/pr80969-4b.c: Likewise.
	* gcc.target/i386/pr80969-4.c: Likewise.

  parent reply	other threads:[~2017-08-08 19:31 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-31 11:16 Daniel Santos
2017-07-31 11:19 ` [PATCH 6/6] [i386, testsuite] Add tests, fix bug in check_avx2_hw_available Daniel Santos
2017-08-08 19:23   ` [PATCH 6/6 v2] " Daniel Santos
2017-07-31 11:19 ` [PATCH 5/6] [i386] Modify SP realignment in ix86_expand_prologue, et. al Daniel Santos
2017-08-02 23:28   ` [PATCH 5/6 v2] " Daniel Santos
2017-07-31 11:19 ` [PATCH 2/6] [i386] Remove ix86_frame::outlined_save_offset Daniel Santos
2017-07-31 13:53   ` Uros Bizjak
2017-07-31 11:19 ` [PATCH 4/6] [i386] Modify ix86_compute_frame_layout Daniel Santos
2017-07-31 11:19 ` [PATCH 3/6] [i386] Remove machine_function::call_ms2sysv_pad_out Daniel Santos
2017-07-31 13:59   ` Uros Bizjak
2017-07-31 11:19 ` [PATCH 1/6] [i386] Correct comments, add assertions to sp_valid_at and fp_valid_at Daniel Santos
2017-07-31 17:23 ` [PATCH 0/6] [i386] PR80969 Fix ICE with -mabi=ms -mavx512f Daniel Santos
2017-08-01  6:20   ` Uros Bizjak
2017-08-08 19:31 ` Daniel Santos [this message]
2017-08-22 22:44   ` [PATCH v4 0/4] " Daniel Santos
2017-08-22 23:23     ` [PATCH 1/4] [i386] Correct comments, add assertions to sp_valid_at and fp_valid_at Daniel Santos
2017-08-23  3:51     ` [PATCH 4/4] [i386, testsuite] Add tests, fix bug in check_avx2_hw_available Daniel Santos
2017-08-23 13:46       ` Uros Bizjak
2017-08-24  1:32         ` Daniel Santos
2017-08-23  4:17     ` [PATCH 2/4] [i386] Modify ix86_compute_frame_layout Daniel Santos
2017-08-23  4:18     ` [PATCH 3/4] [i386] Modify SP realignment in ix86_expand_prologue, et. al Daniel Santos
2017-08-23 13:53     ` [PATCH v4 0/4] [i386] PR80969 Fix ICE with -mabi=ms -mavx512f Uros Bizjak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8ac6dd17-e11c-a767-5d33-d3ec16b5b856@pobox.com \
    --to=daniel.santos@pobox.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hjl.tools@gmail.com \
    --cc=hubicka@ucw.cz \
    --cc=mikestump@comcast.net \
    --cc=mliska@suse.cz \
    --cc=ro@CeBiTec.Uni-Bielefeld.DE \
    --cc=ubizjak@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).