From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 92884 invoked by alias); 22 Jan 2018 20:24:56 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 92789 invoked by uid 89); 22 Jan 2018 20:24:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,KAM_NUMSUBJECT,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=H*Ad:U*tkoenig, 22.01.2018, 22012018 X-Spam-User: qpsmtpd, 2 recipients X-HELO: cc-smtpout1.netcologne.de Received: from cc-smtpout1.netcologne.de (HELO cc-smtpout1.netcologne.de) (89.1.8.211) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 22 Jan 2018 20:24:27 +0000 Received: from cc-smtpin3.netcologne.de (cc-smtpin3.netcologne.de [89.1.8.203]) by cc-smtpout1.netcologne.de (Postfix) with ESMTP id 3605F1353B; Mon, 22 Jan 2018 21:24:22 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by cc-smtpin3.netcologne.de (Postfix) with ESMTP id 3134E11DD0; Mon, 22 Jan 2018 21:24:22 +0100 (CET) Received: from [78.35.155.137] (helo=cc-smtpin3.netcologne.de) by localhost with ESMTP (eXpurgate 4.1.9) (envelope-from ) id 5a664876-02b7-7f0000012729-7f00000184cb-1 for ; Mon, 22 Jan 2018 21:24:22 +0100 Received: from [192.168.178.20] (xdsl-78-35-155-137.netcologne.de [78.35.155.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by cc-smtpin3.netcologne.de (Postfix) with ESMTPSA; Mon, 22 Jan 2018 21:24:18 +0100 (CET) Subject: Re: [Patch, fortran] PR37577 - [meta-bug] change internal array descriptor format for better syntax, C interop TR, rank 15 To: Janne Blomqvist , Paul Richard Thomas Cc: "fortran@gcc.gnu.org" , gcc-patches References: From: Thomas Koenig Message-ID: <8adb0817-3f7f-2ec3-870c-d810d3b5c364@netcologne.de> Date: Mon, 22 Jan 2018 21:10:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2018-01/txt/msg01897.txt.bz2 Am 22.01.2018 um 20:59 schrieb Janne Blomqvist: > On Mon, Jan 22, 2018 at 9:12 PM, Paul Richard Thomas > wrote: >> This patch has been triggered by Thomas's recent message to the list. >> Not only did I start work late relative to stage 3 but debugging took >> somewhat longer than anticipated. Therefore, to get this committed >> asap, we will have to beg the indulgence of the release managers and >> prompt review and/or testing by fortran maintainers. (Dominique has >> already undertaken to test -m32.) > > I think that if we can "guarantee" that we're happy with the current > ABI for GCC 9 (and hopefully 10, 11, ...?) we have a quite strong case > for committing it now. But if anybody if planning on doing some > ABI-breaking work in the foreseeable future then maybe we should wait > until GCC 9 stage1 opens. Anybody with such plans? For asynchronous I/O, we could add a pointer to void (unused at present) for later use. That's all from my side. >> It should be noted that some of the intrinsics, which use switch/case >> for the type/kind selection, limit the effective element size that >> they handle to the maximum value of size_t, less 7 bits. A bit of >> straightforward work there would fix this limitation and would allow >> the GFC_DTYPE shifts and masks to be eliminated. > > Hmm, is this a hidden ABI break, then? No. This concerns code like type_size = GFC_DTYPE_TYPE_SIZE(array); switch(type_size) { case GFC_DTYPE_LOGICAL_1: case GFC_DTYPE_INTEGER_1: case GFC_DTYPE_DERIVED_1: pack_i1 ((gfc_array_i1 *) ret, (gfc_array_i1 *) array, (gfc_array_l1 *) mask, (gfc_array_i1 *) vector); return; for example in patck_generic.c. I think that, if we commit Paul's patch now, we can then fix these cases before gcc 8 is released. This is rather straigtforward. Regards Thomas