From: Jeff Law <law@redhat.com>
To: David Malcolm <dmalcolm@redhat.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 34/41] analyzer: new files: program-state.{cc|h}
Date: Fri, 10 Jan 2020 17:41:00 -0000 [thread overview]
Message-ID: <8b42c3098f21593135068c7b5bc233a0a6076a27.camel@redhat.com> (raw)
In-Reply-To: <20200108090302.2425-35-dmalcolm@redhat.com>
On Wed, 2020-01-08 at 04:02 -0500, David Malcolm wrote:
> Needs review.
>
> Changed in v5:
> - update ChangeLog path
> - updated copyright years to include 2020
>
> Changed in v4:
> - Remove include of gcc-plugin.h, reworking includes accordingly.
> - Wrap everything in #if ENABLE_ANALYZER
> - Remove /// comment lines
> - Add support for global state:
> - https://gcc.gnu.org/ml/gcc-patches/2019-12/msg00217.html
> - Rework logging to avoid exploded_graph multiple-inheritance (moving
> log_user base to a member)
>
> This patch introduces classes for tracking the state at a particular
> path of analysis.
>
> gcc/analyzer/ChangeLog:
> * program-state.cc: New file.
> * program-state.h: New file.
>
>
>
>
>
> diff --git a/gcc/analyzer/program-state.h b/gcc/analyzer/program-state.h
> new file mode 100644
> index 000000000000..be83d32b8833
> --- /dev/null
> +++ b/gcc/analyzer/program-state.h
> @@ -0,0 +1,365 @@
> +/* Classes for representing the state of interest at a given path of analysis.
> + Copyright (C) 2019-2020 Free Software Foundation, Inc.
> + Contributed by David Malcolm <dmalcolm@redhat.com>.
> +
> +This file is part of GCC.
> +
> +GCC is free software; you can redistribute it and/or modify it
> +under the terms of the GNU General Public License as published by
> +the Free Software Foundation; either version 3, or (at your option)
> +any later version.
> +
> +GCC is distributed in the hope that it will be useful, but
> +WITHOUT ANY WARRANTY; without even the implied warranty of
> +MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> +General Public License for more details.
> +
> +You should have received a copy of the GNU General Public License
> +along with GCC; see the file COPYING3. If not see
> +<http://www.gnu.org/licenses/>;. */
> +
> +#ifndef GCC_ANALYZER_PROGRAM_STATE_H
> +#define GCC_ANALYZER_PROGRAM_STATE_H
> +
> +#include "analyzer/sm.h"
> +#include "analyzer/region-model.h"
Not as bad as the previously reviewed patch. But let's see if we can
get those out of here and into the appropriate source files.
OK with the #includes moved to the right places.
jeff
next prev parent reply other threads:[~2020-01-10 17:40 UTC|newest]
Thread overview: 103+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 9:04 [PATCH 00/41] v5 of analyzer patch kit David Malcolm
2020-01-08 9:03 ` [PATCH 09/41] analyzer: add ChangeLog David Malcolm
2020-01-10 15:41 ` Jeff Law
2020-01-08 9:03 ` [PATCH 21/41] analyzer: new files: constraint-manager.{cc|h} David Malcolm
2020-01-10 17:54 ` Jeff Law
2020-01-08 9:03 ` [PATCH 25/41] analyzer: new files: sm-malloc.cc and sm-malloc.dot David Malcolm
2020-01-10 16:58 ` Jeff Law
2020-01-08 9:03 ` [PATCH 04/41] vec.h: add auto_delete_vec David Malcolm
2020-01-09 4:15 ` Jeff Law
2020-01-08 9:03 ` [PATCH 02/41] analyzer: internal documentation David Malcolm
2020-01-08 21:57 ` Jeff Law
2020-01-08 9:03 ` [PATCH 01/41] analyzer: user-facing documentation David Malcolm
2020-01-08 21:54 ` Jeff Law
2020-01-08 9:03 ` [PATCH 10/41] analyzer: changes to configure.ac David Malcolm
2020-01-10 15:44 ` Jeff Law
2020-01-08 9:03 ` [PATCH 11/41] analyzer: add new files to Makefile.in David Malcolm
2020-01-10 15:44 ` Jeff Law
2020-01-08 9:03 ` [PATCH 03/41] sbitmap.h: add operator const_sbitmap to auto_sbitmap David Malcolm
2020-01-08 21:57 ` Jeff Law
2020-01-08 9:03 ` [PATCH 23/41] analyzer: new files: pending-diagnostic.{cc|h} David Malcolm
2020-01-10 15:57 ` Jeff Law
2020-01-08 9:03 ` [PATCH 26/41] analyzer: new file: sm-file.cc David Malcolm
2020-01-10 15:58 ` Jeff Law
2020-01-08 9:03 ` [PATCH 15/41] analyzer: new file: analyzer-pass.cc and pass registration David Malcolm
2020-01-10 15:47 ` Jeff Law
2020-01-08 9:03 ` [PATCH 20/41] analyzer: new files: tristate.{cc|h} David Malcolm
2020-01-10 15:55 ` Jeff Law
2020-01-08 9:03 ` [PATCH 08/41] timevar.def: add TVs for analyzer David Malcolm
2020-01-10 15:40 ` Jeff Law
2020-01-08 9:03 ` [PATCH 06/41] Add diagnostic paths David Malcolm
2020-01-10 15:39 ` Jeff Law
2020-01-10 22:01 ` David Malcolm
2020-01-13 10:05 ` Rainer Orth
2020-01-13 21:42 ` [committed] testsuite: remove unused dg-line directive David Malcolm
2020-01-08 9:03 ` [PATCH 16/41] analyzer: new files: graphviz.{cc|h} David Malcolm
2020-01-10 15:49 ` Jeff Law
2020-01-08 9:03 ` [PATCH 17/41] analyzer: new files: digraph.{cc|h} and shortest-paths.h David Malcolm
2020-01-10 15:53 ` Jeff Law
2020-01-08 9:04 ` [PATCH 36/41] analyzer: new files: state-purge.{cc|h} David Malcolm
2020-01-10 16:12 ` Jeff Law
2020-01-08 9:04 ` [PATCH 35/41] analyzer: new file: exploded-graph.h David Malcolm
2020-01-10 16:11 ` Jeff Law
2020-01-10 17:19 ` David Malcolm
2020-01-10 17:25 ` Jeff Law
2020-01-08 9:04 ` [PATCH 24/41] analyzer: new files: sm.{cc|h} David Malcolm
2020-01-10 16:50 ` Jeff Law
2020-01-10 22:39 ` David Malcolm
2020-01-08 9:04 ` [PATCH 34/41] analyzer: new files: program-state.{cc|h} David Malcolm
2020-01-10 17:41 ` Jeff Law [this message]
2020-01-08 9:04 ` [PATCH 28/41] analyzer: new file: sm-sensitive.cc David Malcolm
2020-01-10 16:01 ` Jeff Law
2020-01-08 9:04 ` [PATCH 31/41] analyzer: new files: analysis-plan.{cc|h} David Malcolm
2020-01-10 16:06 ` Jeff Law
2020-01-08 9:04 ` [PATCH 33/41] analyzer: new files: program-point.{cc|h} David Malcolm
2020-01-10 16:10 ` Jeff Law
2020-01-08 9:04 ` [PATCH 14/41] analyzer: logging support David Malcolm
2020-01-10 15:47 ` Jeff Law
2020-01-08 9:04 ` [PATCH 18/41] analyzer: new files: supergraph.{cc|h} David Malcolm
2020-01-10 17:40 ` Jeff Law
2020-01-10 17:44 ` David Malcolm
2020-01-10 17:45 ` Jeff Law
2020-01-08 9:04 ` [PATCH 13/41] analyzer: command-line options David Malcolm
2020-01-10 16:37 ` Jeff Law
2020-01-08 9:04 ` [PATCH 32/41] analyzer: new files: call-string.{cc|h} David Malcolm
2020-01-10 16:07 ` Jeff Law
2020-01-08 9:04 ` [PATCH 40/41] gdbinit.in: add break-on-saved-diagnostic David Malcolm
2020-01-10 16:16 ` Jeff Law
2020-01-08 9:05 ` [PATCH 07/41] Add ordered_hash_map David Malcolm
2020-01-10 16:29 ` Jeff Law
2020-01-10 16:32 ` David Malcolm
2020-01-10 16:55 ` Jeff Law
2020-01-08 9:05 ` [PATCH 37/41] analyzer: new files: engine.{cc|h} David Malcolm
2020-01-10 18:10 ` Jeff Law
2020-01-08 9:05 ` [PATCH 38/41] analyzer: new files: checker-path.{cc|h} David Malcolm
2020-01-10 17:10 ` Jeff Law
2020-01-08 9:05 ` [PATCH 27/41] analyzer: new file: sm-pattern-test.cc David Malcolm
2020-01-10 15:59 ` Jeff Law
2020-01-08 9:05 ` [PATCH 41/41] analyzer: test suite David Malcolm
2020-01-10 16:16 ` Jeff Law
2020-01-08 9:05 ` [PATCH 12/41] analyzer: new files: analyzer-selftests.{cc|h} David Malcolm
2020-01-10 15:46 ` Jeff Law
2020-01-08 9:05 ` [PATCH 30/41] analyzer: new file: sm-taint.cc David Malcolm
2020-01-10 16:05 ` Jeff Law
2020-01-08 9:05 ` [PATCH 05/41] Add -fdiagnostics-nn-line-numbers David Malcolm
2020-01-08 22:07 ` [PATCH] testsuite: add lib/nn-line-numbers.exp David Malcolm
2020-01-10 2:48 ` [PATCH] testsuite: add dg-enable-nn-line-numbers (v6) David Malcolm
2020-01-10 15:38 ` [PATCH] testsuite: add lib/nn-line-numbers.exp Jeff Law
2020-01-10 16:46 ` David Malcolm
2020-01-10 17:52 ` Jeff Law
2020-01-09 4:17 ` [PATCH 05/41] Add -fdiagnostics-nn-line-numbers Jeff Law
2020-01-09 4:35 ` David Malcolm
2020-01-09 4:50 ` Jeff Law
2020-01-10 15:36 ` Jeff Law
2020-01-08 9:05 ` [PATCH 19/41] analyzer: new files: analyzer.{cc|h} David Malcolm
2020-01-10 15:54 ` Jeff Law
2020-01-10 17:04 ` David Malcolm
2020-01-08 9:05 ` [PATCH 22/41] analyzer: new files: region-model.{cc|h} David Malcolm
2020-01-08 9:05 ` [PATCH 39/41] analyzer: new files: diagnostic-manager.{cc|h} David Malcolm
2020-01-10 17:02 ` Jeff Law
2020-01-08 9:05 ` [PATCH 29/41] analyzer: new file: sm-signal.cc David Malcolm
2020-01-10 16:04 ` Jeff Law
2020-01-10 16:44 ` David Malcolm
2020-01-10 8:02 ` v6 of analyzer patch kit David Malcolm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b42c3098f21593135068c7b5bc233a0a6076a27.camel@redhat.com \
--to=law@redhat.com \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).