Re: [PATCH][RFC] Add quotes for constexpr keyword.

["Martin Liška" <mliska@suse.cz>]

On 11/21/2017 06:13 PM, Jeff Law wrote:
> On 11/21/2017 08:00 AM, Martin Liška wrote:
>> Hi.
>>
>> I'm sending v2 of the patch where I fixed test-suite fallout.
>>
>> Patch can bootstrap on ppc64le-redhat-linux and survives regression tests.
>>
>> Ready to be installed?
>> Martin
>>
>>
>> 0001-Add-quotes-for-constexpr-keyword.patch
>>
>>
>>  From 3195b1b71c387b1359c90f6e752e1c312120cd69 Mon Sep 17 00:00:00 2001
>> From: marxin <mliska@suse.cz>
>> Date: Wed, 15 Nov 2017 08:41:12 +0100
>> Subject: [PATCH] Add quotes for constexpr keyword.
>>
>> gcc/cp/ChangeLog:
>>
>> 2017-11-15  Martin Liska  <mliska@suse.cz>
>>
>> 	* class.c (finalize_literal_type_property): Add quotes for
>> 	constexpr keyword.
>> 	(explain_non_literal_class): Likewise.
>> 	* constexpr.c (ensure_literal_type_for_constexpr_object): Likewise.
>> 	(is_valid_constexpr_fn): Likewise.
>> 	(check_constexpr_ctor_body): Likewise.
>> 	(register_constexpr_fundef): Likewise.
>> 	(explain_invalid_constexpr_fn): Likewise.
>> 	(cxx_eval_builtin_function_call): Likewise.
>> 	(cxx_eval_call_expression): Likewise.
>> 	(cxx_eval_loop_expr): Likewise.
>> 	(potential_constant_expression_1): Likewise.
>> 	* decl.c (check_previous_goto_1): Likewise.
>> 	(check_goto): Likewise.
>> 	(grokfndecl): Likewise.
>> 	(grokdeclarator): Likewise.
>> 	* error.c (maybe_print_constexpr_context): Likewise.
>> 	* method.c (process_subob_fn): Likewise.
>> 	(defaulted_late_check): Likewise.
>> 	* parser.c (cp_parser_compound_statement): Likewise.
>>
>> gcc/testsuite/ChangeLog:
>>
>> 2017-11-16  Martin Liska  <mliska@suse.cz>
>>
>> 	* g++.dg/cpp0x/constexpr-48089.C: Add quotes for constexpr
>> 	keyword; add dg-message for 'in .constexpr. expansion of '.
>> 	* g++.dg/cpp0x/constexpr-50060.C: Likewise.
>> 	* g++.dg/cpp0x/constexpr-60049.C: Likewise.
>> 	* g++.dg/cpp0x/constexpr-70323.C: Likewise.
>> 	* g++.dg/cpp0x/constexpr-70323a.C: Likewise.
>> 	* g++.dg/cpp0x/constexpr-cast.C: Likewise.
>> 	* g++.dg/cpp0x/constexpr-diag3.C: Likewise.
>> 	* g++.dg/cpp0x/constexpr-ex1.C: Likewise.
>> 	* g++.dg/cpp0x/constexpr-generated1.C: Likewise.
>> 	* g++.dg/cpp0x/constexpr-ice16.C: Likewise.
>> 	* g++.dg/cpp0x/constexpr-ice5.C: Likewise.
>> 	* g++.dg/cpp0x/constexpr-incomplete2.C: Likewise.
>> 	* g++.dg/cpp0x/constexpr-neg1.C: Likewise.
>> 	* g++.dg/cpp0x/constexpr-recursion.C: Likewise.
>> 	* g++.dg/cpp0x/constexpr-shift1.C: Likewise.
>> 	* g++.dg/cpp1y/constexpr-70265-1.C: Likewise.
>> 	* g++.dg/cpp1y/constexpr-70265-2.C: Likewise.
>> 	* g++.dg/cpp1y/constexpr-79655.C: Likewise.
>> 	* g++.dg/cpp1y/constexpr-new.C: Likewise.
>> 	* g++.dg/cpp1y/constexpr-return2.C: Likewise.
>> 	* g++.dg/cpp1y/constexpr-shift1.C: Likewise.
>> 	* g++.dg/cpp1y/constexpr-throw.C: Likewise.
>> 	* g++.dg/cpp1z/constexpr-lambda6.C: Likewise.
>> 	* g++.dg/ext/constexpr-vla1.C: Likewise.
>> 	* g++.dg/ext/constexpr-vla2.C: Likewise.
>> 	* g++.dg/ext/constexpr-vla3.C: Likewise.
>> 	* g++.dg/cpp0x/static_assert10.C: Likewise.
>> 	* g++.dg/cpp1y/pr63996.C: Likewise.
>> 	* g++.dg/cpp1y/pr68180.C: Likewise.
>> 	* g++.dg/cpp1y/pr77830.C: Likewise.
>> 	* g++.dg/ubsan/pr63956.C: Likewise.
> OK.  And ISTM that other patches of a similar nature ought to just be
> considered OK without the need to review.
> 
> Jeff
> 

Thanks for review, installed as r255025.

Martin