From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 108985 invoked by alias); 21 Nov 2017 18:59:54 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 107832 invoked by uid 89); 21 Nov 2017 18:59:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: mx2.suse.de Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 21 Nov 2017 18:59:51 +0000 Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 0A532AC63; Tue, 21 Nov 2017 18:59:49 +0000 (UTC) Subject: Re: [PATCH][RFC] Add quotes for constexpr keyword. To: Jeff Law , Jonathan Wakely , Martin Sebor Cc: Jason Merrill , Marek Polacek , Jakub Jelinek , gcc-patches List References: <451b4f3d-d858-bbc8-5d1f-6056af5963d3@suse.cz> <20171018125252.GC19284@redhat.com> <99de094c-0e98-f2f2-39a9-a7394e0604ad@redhat.com> <0d484e7b-782b-7c4c-cdda-723efffe15a5@suse.cz> <7f78d1c7-ac2a-c43b-d0fb-9c09c70b65b2@gmail.com> <230260f8-2f1d-7f6d-973d-05ebe8ea78a4@gmail.com> <20171115163829.GG31922@redhat.com> <1b88d763-881f-749c-34b9-1ddfb67551eb@gmail.com> <20171115171029.GH31922@redhat.com> <991d8051-d6e4-5b3f-3944-8a0fdf3e7c9a@suse.cz> <644bed77-731c-7add-c7da-eceb873506aa@redhat.com> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= Message-ID: <8b459e91-5cec-56e8-a138-1a5214841a00@suse.cz> Date: Tue, 21 Nov 2017 19:07:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <644bed77-731c-7add-c7da-eceb873506aa@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg01947.txt.bz2 On 11/21/2017 06:13 PM, Jeff Law wrote: > On 11/21/2017 08:00 AM, Martin Liška wrote: >> Hi. >> >> I'm sending v2 of the patch where I fixed test-suite fallout. >> >> Patch can bootstrap on ppc64le-redhat-linux and survives regression tests. >> >> Ready to be installed? >> Martin >> >> >> 0001-Add-quotes-for-constexpr-keyword.patch >> >> >> From 3195b1b71c387b1359c90f6e752e1c312120cd69 Mon Sep 17 00:00:00 2001 >> From: marxin >> Date: Wed, 15 Nov 2017 08:41:12 +0100 >> Subject: [PATCH] Add quotes for constexpr keyword. >> >> gcc/cp/ChangeLog: >> >> 2017-11-15 Martin Liska >> >> * class.c (finalize_literal_type_property): Add quotes for >> constexpr keyword. >> (explain_non_literal_class): Likewise. >> * constexpr.c (ensure_literal_type_for_constexpr_object): Likewise. >> (is_valid_constexpr_fn): Likewise. >> (check_constexpr_ctor_body): Likewise. >> (register_constexpr_fundef): Likewise. >> (explain_invalid_constexpr_fn): Likewise. >> (cxx_eval_builtin_function_call): Likewise. >> (cxx_eval_call_expression): Likewise. >> (cxx_eval_loop_expr): Likewise. >> (potential_constant_expression_1): Likewise. >> * decl.c (check_previous_goto_1): Likewise. >> (check_goto): Likewise. >> (grokfndecl): Likewise. >> (grokdeclarator): Likewise. >> * error.c (maybe_print_constexpr_context): Likewise. >> * method.c (process_subob_fn): Likewise. >> (defaulted_late_check): Likewise. >> * parser.c (cp_parser_compound_statement): Likewise. >> >> gcc/testsuite/ChangeLog: >> >> 2017-11-16 Martin Liska >> >> * g++.dg/cpp0x/constexpr-48089.C: Add quotes for constexpr >> keyword; add dg-message for 'in .constexpr. expansion of '. >> * g++.dg/cpp0x/constexpr-50060.C: Likewise. >> * g++.dg/cpp0x/constexpr-60049.C: Likewise. >> * g++.dg/cpp0x/constexpr-70323.C: Likewise. >> * g++.dg/cpp0x/constexpr-70323a.C: Likewise. >> * g++.dg/cpp0x/constexpr-cast.C: Likewise. >> * g++.dg/cpp0x/constexpr-diag3.C: Likewise. >> * g++.dg/cpp0x/constexpr-ex1.C: Likewise. >> * g++.dg/cpp0x/constexpr-generated1.C: Likewise. >> * g++.dg/cpp0x/constexpr-ice16.C: Likewise. >> * g++.dg/cpp0x/constexpr-ice5.C: Likewise. >> * g++.dg/cpp0x/constexpr-incomplete2.C: Likewise. >> * g++.dg/cpp0x/constexpr-neg1.C: Likewise. >> * g++.dg/cpp0x/constexpr-recursion.C: Likewise. >> * g++.dg/cpp0x/constexpr-shift1.C: Likewise. >> * g++.dg/cpp1y/constexpr-70265-1.C: Likewise. >> * g++.dg/cpp1y/constexpr-70265-2.C: Likewise. >> * g++.dg/cpp1y/constexpr-79655.C: Likewise. >> * g++.dg/cpp1y/constexpr-new.C: Likewise. >> * g++.dg/cpp1y/constexpr-return2.C: Likewise. >> * g++.dg/cpp1y/constexpr-shift1.C: Likewise. >> * g++.dg/cpp1y/constexpr-throw.C: Likewise. >> * g++.dg/cpp1z/constexpr-lambda6.C: Likewise. >> * g++.dg/ext/constexpr-vla1.C: Likewise. >> * g++.dg/ext/constexpr-vla2.C: Likewise. >> * g++.dg/ext/constexpr-vla3.C: Likewise. >> * g++.dg/cpp0x/static_assert10.C: Likewise. >> * g++.dg/cpp1y/pr63996.C: Likewise. >> * g++.dg/cpp1y/pr68180.C: Likewise. >> * g++.dg/cpp1y/pr77830.C: Likewise. >> * g++.dg/ubsan/pr63956.C: Likewise. > OK. And ISTM that other patches of a similar nature ought to just be > considered OK without the need to review. > > Jeff > Thanks for review, installed as r255025. Martin