From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 2897A3858D32 for ; Tue, 26 Dec 2023 16:37:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2897A3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2897A3858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703608678; cv=none; b=CCL/8OgaaNTC1i/KTN0Puhmnb7fZboO9If6YQRSZpPA0nZzjNRlilP9+Y3Rlldfot0T/otIZkAPReGtVrf7QoyoE515yAx6NAI+wJOF8xIW/wCqnKELpiTbv4rPUHFQ86v8YymmZ5q+wSEkNZAX3lRM7FYtpwXaUJfSX6g89UCI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703608678; c=relaxed/simple; bh=eQ/gluSD3S7a7eldBzcZDiJWv3FajVp3zw8YBi8/8cY=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=t1j8Mxr72qZcnT0i3nYmIqF+6ROOciq3N/J7pw+RmQtk/961TZP6Z5to2UCXuWyJGbl0hyFFEDwZVWB+U60Y8f25dDPnCR0SNL9E9GPYSUvsyr6Ss2qmUOE/8WNLGvy2fhp7tI9uVXtxOTf0m3SliP/aGdOmiTYC68dbScubLnw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1703608675; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lN4qla8Mx1xXNDDVh9FEzGznyl6PsOUX3si4Hc1VeK8=; b=PeI7G4/+mX21uwE+x5XNb5t+A73qJLc0Kt5rdrhx8pROrxH/JaC2se752+hEc3YoFFcWIn q/D0Fs1vLp7GLxoHtqTUrMudxMJJxlX9ymIFExkwMCS3xC7NW78xy4scZwPG2mWyKSfQMx j4MEgnjOM2FkpIO/prt5t+Ab2cfcyZg= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-618-uSaFG6RDOOaK4O_wFxW99A-1; Tue, 26 Dec 2023 11:37:54 -0500 X-MC-Unique: uSaFG6RDOOaK4O_wFxW99A-1 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-67f7748ad02so118895726d6.1 for ; Tue, 26 Dec 2023 08:37:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703608673; x=1704213473; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lN4qla8Mx1xXNDDVh9FEzGznyl6PsOUX3si4Hc1VeK8=; b=BAEZaQxfodX0nvhq+hYfXwW6k6zb1aQ6pN4Vqfk/5QqEeORAQlqfRLRKJ5y5SoWdel xhlSVvsMVcid+frgjJWao8oLEig/QCL0NIZYsyKdQ3z0i1CDH9xvfivdwrrH2O7gk5SG evR5Mz1BVf3iPZ+UJ6Cdi6N67Y5YsMFCugibeSt6TZDa8Je7YomSJWL3wt3sys+QFaGL 8AwqyANbVXTyxHLrFo0didZYaEHI79ThcC+Z1qr81JNT0F7PQZKTB/n/psd7nmJg1v+p 5VJ/Q3NKz8t4jpTrMfkS4kNO6ogdMxDt4AEva1ViXm5wsThfgRzpvGpTzlP52nVxde2Q TRBg== X-Gm-Message-State: AOJu0YwaCga/n1XYviZiPEGE5Y3xEWmW8HToa8EGlDUXZT2aEUrip2sz gwwYmYmSpsLzjv/bCaxk/Tw6IeT577CeOSpkAa53UB4mtULCsYdSkBLkZvWPZQFOUbbp/94BUvw r4H2u3Z2Cxtk1QvABHXhNPa5PhcgQvwV8bw== X-Received: by 2002:a05:6214:4013:b0:67f:1fc2:182f with SMTP id kd19-20020a056214401300b0067f1fc2182fmr8789870qvb.50.1703608673499; Tue, 26 Dec 2023 08:37:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IFWeZHy/eVdTxR7wV3foT96leR2q1Fzv48bd8WQ9wR77FwYGIaP5XMNHIvKv/3PVh9izyr0Qg== X-Received: by 2002:a05:6214:4013:b0:67f:1fc2:182f with SMTP id kd19-20020a056214401300b0067f1fc2182fmr8789859qvb.50.1703608673201; Tue, 26 Dec 2023 08:37:53 -0800 (PST) Received: from [10.0.0.48] (c-98-202-117-243.hsd1.ut.comcast.net. [98.202.117.243]) by smtp.gmail.com with ESMTPSA id t9-20020a0cef49000000b006800a150d42sm1723210qvs.20.2023.12.26.08.37.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Dec 2023 08:37:52 -0800 (PST) Message-ID: <8b5533f7-4033-47f5-b238-851e37730b52@redhat.com> Date: Tue, 26 Dec 2023 11:37:49 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 1/1] c++: Initial support for P0847R7 (Deducing This) [PR102609] To: waffl3x Cc: "gcc-patches@gcc.gnu.org" References: <59LofhYhxl7MLEuElXwZcESRB6MpjdG-iq-89B63siDRo5k0j-y6z-PVa6Y3iE1xE5LkJwpwTFi82bd0RZjB1yZbSJptFdPTBWfvOGj1W78=@protonmail.com> <4e1adee6-269a-4a27-ad23-2742277d7889@redhat.com> From: Jason Merrill In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/23/23 02:10, waffl3x wrote: > On Friday, December 22nd, 2023 at 10:26 AM, Jason Merrill wrote: >> >> >> On 12/22/23 04:01, waffl3x wrote: >> >>> int n = 0; >>> auto f = [](this Self){ >>> static_assert(__is_same (decltype(n), int)); >>> decltype((n)) a; // { dg-error {is not captured} } >>> }; >>> f(); >>> >>> Could you clarify if this error being removed was intentional. I do >>> recall that Patrick Palka wanted to remove this error in his patch, but >>> it seemed to me like you stated it would be incorrect to allow it. >>> Since the error is no longer present I assume I am misunderstanding the >>> exchange. >>> >>> In any case, let me know if I need to modify my test case or if this >>> error needs to be added back in. >> >> >> Removing the error was correct under >> https://eel.is/c++draft/expr.prim#id.unqual-3 >> Naming n in that lambda would not refer a capture by copy, so the >> decltype is the same as outside the lambda. > > Alright, I've fixed my tests to reflect that. > > I've got defaulting assignment operators working. Defaulting equality > and comparison operators seemed to work out of the box somehow, so I > just have to make some fleshed out tests for those cases. > > There can always be more tests, I have a few ideas for what still needs > to be covered, mostly with dependent lambdas. Tests for xobj conversion > operators definitely need to be more fleshed out. I also need to > formulate some tests to make sure constraints are not being taking into > account when the object parameters should not correspond, but that's a > little more tough to test for than the valid cases. > > Other than tests though, is there anything you can think of that the > patch is missing? Other than the aforementioned tests, I'm pretty > confident everything is done. > > To recap, I have CWG2789 implemented on my end with the change we > discussed to require corresponding object parameters instead of the > same type, and I have CWG2586 implemented. I can't recall what other > outstanding issues we had, and my notes don't mention anything other > than tests. So I'm assuming everything is good. Sounds good! Did you mean to include the updated patch? Jason