From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id DE67E38582BF for ; Thu, 27 Oct 2022 10:34:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DE67E38582BF Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DBB6D1FDC2; Thu, 27 Oct 2022 10:34:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1666866886; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yf/9ysycr9yPc3BFDQJFTMR7S4dfjgp6LecFf/xZWtE=; b=qwL7ta7NqBolfdcS6KFSRVCzQdk+OrWno6bxQKt5qXQ7yRTuYNAIs5Y3zsEkeRcecMoEuQ fN3m3n++J3GchCBcVC9DZHejSsNIdRkEkZO714h+5Rysh1KusBZDFh/tWhXnfBvhTR2wXX O9qp86rVAWL6fK3gxOyGsMgo49GDDOg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1666866886; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yf/9ysycr9yPc3BFDQJFTMR7S4dfjgp6LecFf/xZWtE=; b=JoHHMya+qF5WtucE95mX0NsxDR4YJ2vG7pYu6Ky9HgkkOKC6qGXd5Vm+glE7hsOhKtKi9i fAh4lsU78j+h+bAQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C9AF2134CA; Thu, 27 Oct 2022 10:34:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id fpcuMMZeWmPgBQAAMHmgww (envelope-from ); Thu, 27 Oct 2022 10:34:46 +0000 Message-ID: <8b6262df-6c48-1ad6-9944-2530f69fbf68@suse.cz> Date: Thu, 27 Oct 2022 12:34:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: Ping [PATCH] Add condition coverage profiling To: =?UTF-8?Q?J=c3=b8rgen_Kvalsvik?= , gcc-patches@gcc.gnu.org References: <20221012101619.7221-1-jorgen.kvalsvik@woven-planet.global> Content-Language: en-US From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/25/22 08:33, Jørgen Kvalsvik wrote: > Gentle ping. I have a tuned the summary output slightly (decisions covered -> > condition outcomes covered) already. Sorry for a small delay, I'm working on it. One general issue I noticed is you use an invalid coding style, where you use 4 spaces for each level. Plus see the indentation for '{', '}': diff --git a/gcc/tree-profile.cc b/gcc/tree-profile.cc index 0b537d64d97..b661ed92045 100644 --- a/gcc/tree-profile.cc +++ b/gcc/tree-profile.cc @@ -553,11 +553,12 @@ masking_vectors (conds_ctx& ctx, array_slice blocks, body[0] = body.pop (); for (const basic_block b : body) - { + { for (edge e1 : b->preds) - for (edge e2 : b->preds) - { - const basic_block top = e1->src; + for (edge e2 : b->preds) + { + const basic_block top = e1->src; +... const basic_block bot = e2->src; const unsigned cond = e1->flags & e2->flags & (EDGE_CONDITION); Link: https://gcc.gnu.org/codingconventions.html What editor do you use? Cheers, Martin