From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by sourceware.org (Postfix) with ESMTPS id 560183857036 for ; Fri, 13 Aug 2021 16:58:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 560183857036 Received: by mail-pl1-x62b.google.com with SMTP id e19so12765288pla.10 for ; Fri, 13 Aug 2021 09:58:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=VTlEt/ky0Ek3IpsP5Xt7eSbxVN4MFJvbch+XueH9BoA=; b=cZFFEpb334/gxEqrGNV1UjsBfJsVOSMSHn57N4HgRqOcQ8nzqcFegi1S3cy8KascYQ WqQlew0JcnYCSJPG8gMeUbDqW1fQ/RxXOI+GBiMVnfpgmF3DkGIkQA0nU4XAirRHy4Pk nK8QS3zuJ8x1RPlp31LXOdJK1jyUxekpqVx51oxJgIOtEZl0BqRQw7Tj7Lh433SYZeOu y1LWiWGGN0Jm9UAntaGpG2F59996ZxcauzlFUyOo3alm2ldW35MRtl89BMOs/8tnbOVN PmKF5Xnb5jjORgUsy5p3vA+oZjLJzQXjYTGnNttohFr2DV+3SuRCCe2KNCCYyLmcfPNb 67vA== X-Gm-Message-State: AOAM5327CqPjUYlPVWWdPR7zIHdiu/fjs8+XoSVAE1xuRCwqYtMU1Vov Vlhv8kqXq5n/SMax0VHOWzBHA3B8TR06Sw== X-Google-Smtp-Source: ABdhPJxvo6T/QJzgRcvV70LWrcjYBL2vKzZKHcghxsKLXzbVhLNNGswt5DVxgOsDVQq4LgxveXLIBg== X-Received: by 2002:a62:878c:0:b029:3c5:f729:ef00 with SMTP id i134-20020a62878c0000b02903c5f729ef00mr3374597pfe.43.1628873931337; Fri, 13 Aug 2021 09:58:51 -0700 (PDT) Received: from [172.31.0.175] (c-98-202-48-222.hsd1.ut.comcast.net. [98.202.48.222]) by smtp.gmail.com with ESMTPSA id y8sm2971866pfe.162.2021.08.13.09.58.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Aug 2021 09:58:51 -0700 (PDT) Subject: Re: [PATCH] ipa: make target_clone default decl local [PR101726] To: =?UTF-8?Q?Martin_Li=c5=a1ka?= , gcc-patches@gcc.gnu.org References: <7bed4472-08a3-aaaa-7388-528d3f30ecd7@suse.cz> From: Jeff Law Message-ID: <8b74d7f6-149e-d55e-3209-e170962570f0@gmail.com> Date: Fri, 13 Aug 2021 10:58:50 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <7bed4472-08a3-aaaa-7388-528d3f30ecd7@suse.cz> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Aug 2021 16:58:53 -0000 On 8/12/2021 9:24 AM, Martin Liška wrote: > When we have a target_clone *declaration*, it does not make sense doing > the default version local. The use-case in the PR is that the reporter > wants to implement the function in assembly. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? > Thanks, > Martin > >     PR ipa/101726 > > gcc/ChangeLog: > >     * multiple_target.c (create_dispatcher_calls): Make default >       function local only if it is a definition. OK jeff