From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from xry111.site (xry111.site [89.208.246.23]) by sourceware.org (Postfix) with ESMTPS id 721803858433 for ; Fri, 8 Sep 2023 08:32:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 721803858433 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=xry111.site Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xry111.site DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site; s=default; t=1694161977; bh=zwZWLP/fVX6PqsHLXy3eteAEJ6X0k9RsiMPuoT2C8xo=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=lPK+ELxNyFNohmuWZdcdJz6//rRLrDPbm5CiK3PL4rBqykV0QGm2y0bor7zFXF54C XPcZYhVIcCGKEuwqlrRb90Skz3tSHWZnPNqkBpLdkBXysEA8WHaOUhs6S6zL1YTxWi iwga6Y41ZjWsCr/iRCrfaanbFBTXvrfoNRG9AIxU= Received: from localhost.localdomain (xry111.site [IPv6:2001:470:683e::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id BECAE659AC; Fri, 8 Sep 2023 04:32:56 -0400 (EDT) Message-ID: <8b98f5a1716e84f4e380246b243debc7b21e3288.camel@xry111.site> Subject: Re: [PATCH] LoongArch: Enable -fsched-pressure by default at -O1 and higher. From: Xi Ruoyao To: Guo Jie , gcc-patches@gcc.gnu.org Cc: xuchenghua@loongson.cn, chenglulu@loongson.cn, i@xen0n.name Date: Fri, 08 Sep 2023 16:32:55 +0800 In-Reply-To: References: <20230908020021.3174-1-guojie@loongson.cn> <4019d038e4ef790380cbeb0b3f6c231e00d47b76.camel@xry111.site> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,LIKELY_SPAM_FROM,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 2023-09-08 at 16:29 +0800, Guo Jie wrote: > Hi, >=20 > What I wanna change is "gcc/common/config/loongarch/loongarch- > common.cc", >=20 > and the patch is automatically generated by "git gcc-commit-mklog". >=20 > Is it necessary to=C2=A0 to remove "common/" ? My bad. I didn't realized the file has been moved to common. Don't change it :(. > Thanks for the review. >=20 >=20 > =E5=9C=A8 2023/9/8 =E4=B8=8B=E5=8D=884:06, Xi Ruoyao =E5=86=99=E9=81=93: > > On Fri, 2023-09-08 at 10:00 +0800, Guo Jie wrote: > > > gcc/ChangeLog: > > >=20 > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0* common/config= /loongarch/loongarch-common.cc: > > "common/" should be removed.=C2=A0 You can use "git gcc-verify" to figu= re > > out > > this kind of error before sending a patch in the future. > >=20 > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0(default_option= s loongarch_option_optimization_table): > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Default to -fsc= hed-pressure. > > "Default to -fsched-pressure at -O1 or above." > >=20 > > Otherwise OK. > >=20 > > > --- > > > =C2=A0=C2=A0gcc/common/config/loongarch/loongarch-common.cc | 1 + > > > =C2=A0=C2=A01 file changed, 1 insertion(+) > > >=20 > > > diff --git a/gcc/common/config/loongarch/loongarch-common.cc > > > b/gcc/common/config/loongarch/loongarch-common.cc > > > index c5ed37d27a6..b6901910b70 100644 > > > --- a/gcc/common/config/loongarch/loongarch-common.cc > > > +++ b/gcc/common/config/loongarch/loongarch-common.cc > > > @@ -36,6 +36,7 @@ static const struct default_options > > > loongarch_option_optimization_table[] =3D > > > =C2=A0=C2=A0=C2=A0 { OPT_LEVELS_ALL, OPT_fasynchronous_unwind_tables,= NULL, 1 }, > > > =C2=A0=C2=A0=C2=A0 { OPT_LEVELS_1_PLUS, OPT_fsection_anchors, NULL, 1= }, > > > =C2=A0=C2=A0=C2=A0 { OPT_LEVELS_2_PLUS, OPT_free, NULL, 1 }, > > > +=C2=A0 { OPT_LEVELS_1_PLUS, OPT_fsched_pressure, NULL, 1 }, > > > =C2=A0=C2=A0=C2=A0 { OPT_LEVELS_NONE, 0, NULL, 0 } > > > =C2=A0=C2=A0}; > > > =C2=A0=20 >=20 --=20 Xi Ruoyao School of Aerospace Science and Technology, Xidian University