public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: chenglulu <chenglulu@loongson.cn>
To: Xi Ruoyao <xry111@xry111.site>, gcc-patches@gcc.gnu.org
Cc: i@xen0n.name, xuchenghua@loongson.cn
Subject: Re: Ping: [PATCH] LoongArch: Replace -mexplicit-relocs=auto simple-used address peephole2 with combine
Date: Fri, 22 Dec 2023 15:21:04 +0800	[thread overview]
Message-ID: <8bb6e0c3-8e3c-7dc4-947d-fd338725fe16@loongson.cn> (raw)
In-Reply-To: <64c1875873aee3d8f196a4dd84fdf9f6fb3ee53d.camel@xry111.site>


在 2023/12/22 下午3:09, Xi Ruoyao 写道:
> On Fri, 2023-12-22 at 11:44 +0800, chenglulu wrote:
>> 在 2023/12/21 下午8:00, chenglulu 写道:
>>> Sorry, I've been busy with something else these two days. I don't
>>> think there's anything wrong with the code,
>>>
>>> but I need to test the spec.:-)
>> Hi, Ruoyao:
>>
>> After applying this patch, spec2006 464.h264 ref will have a 6.4%
>> performance drop. So I'm going to retest it.
> I think 6.4% is large enough not to be a random error.
>
> Is there an example showing the code regression?
>
> And I'm wondering if keeping the peephole besides the new
> define_insn_and_split produces a better result instead of solely relying
> on define_insn_and_split?
>
I haven't debugged this yet, I'm retesting, if there is still such a big 
performance gap,

I think I need to see the reason.


  reply	other threads:[~2023-12-22  7:21 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-12  6:47 Xi Ruoyao
2023-12-21 11:56 ` Ping: " Xi Ruoyao
2023-12-21 12:00   ` chenglulu
2023-12-22  3:44     ` chenglulu
2023-12-22  7:09       ` Xi Ruoyao
2023-12-22  7:21         ` chenglulu [this message]
2023-12-23  2:26           ` chenglulu
2023-12-23  2:29             ` chenglulu
2023-12-23 10:44               ` Xi Ruoyao
2023-12-23 10:47                 ` Xi Ruoyao
2023-12-24 12:59                   ` Xi Ruoyao
2023-12-25  2:08                     ` chenglulu
2023-12-25 10:38                       ` Xi Ruoyao
2023-12-27  3:59                 ` chenglulu
2023-12-27 11:21                   ` Xi Ruoyao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8bb6e0c3-8e3c-7dc4-947d-fd338725fe16@loongson.cn \
    --to=chenglulu@loongson.cn \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=i@xen0n.name \
    --cc=xry111@xry111.site \
    --cc=xuchenghua@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).