From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id 6F5BC3858291 for ; Fri, 22 Dec 2023 07:21:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6F5BC3858291 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6F5BC3858291 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=114.242.206.163 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703229669; cv=none; b=ONAw050NnYSiEryhWQDYhbkvTiiSC05l2rOiuRnDWnkOiGPGWY+h4ZC8RKFUS+EOspkCgywVR0k84ogPQ5yTJNDwPPMvyAG3SOzpr7+2utBe2N7nghnJjpFIXS7RpHG3OHCSNF1GCCDK6EN5Y25LkiPKW55AZoAP7rZXoVrI6wk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703229669; c=relaxed/simple; bh=q76U8NRaF+gqctezlRcgQFCBFLAU7LQMV6mSLKWWLtM=; h=Subject:To:From:Message-ID:Date:MIME-Version; b=d24+3pL3b/7i7FNL3XOhdDymQl+3MXOd2za385DPJf3qNDUTzDFYT1vuuujvNDvSJYmouwRF2OmwM4JSH8mtgHcBT64/iAAZzA4Q9ZX9+k9HBWo9v5lSVu/amY5Fn/BrS0fhpiqg2OoIXG32ec8bs9Un8nP4ImNHkKlaOZx3tag= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from loongson.cn (unknown [10.20.4.107]) by gateway (Coremail) with SMTP id _____8Cx9OrgOIVl0MgDAA--.14967S3; Fri, 22 Dec 2023 15:21:04 +0800 (CST) Received: from [10.20.4.107] (unknown [10.20.4.107]) by localhost.localdomain (Coremail) with SMTP id AQAAf8Axnr7gOIVlBEYFAA--.19382S3; Fri, 22 Dec 2023 15:21:04 +0800 (CST) Subject: Re: Ping: [PATCH] LoongArch: Replace -mexplicit-relocs=auto simple-used address peephole2 with combine To: Xi Ruoyao , gcc-patches@gcc.gnu.org Cc: i@xen0n.name, xuchenghua@loongson.cn References: <20231212064754.6623-1-xry111@xry111.site> <64af9171-de9f-df27-1a84-b31fd0876a82@loongson.cn> <64c1875873aee3d8f196a4dd84fdf9f6fb3ee53d.camel@xry111.site> From: chenglulu Message-ID: <8bb6e0c3-8e3c-7dc4-947d-fd338725fe16@loongson.cn> Date: Fri, 22 Dec 2023 15:21:04 +0800 User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <64c1875873aee3d8f196a4dd84fdf9f6fb3ee53d.camel@xry111.site> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID:AQAAf8Axnr7gOIVlBEYFAA--.19382S3 X-CM-SenderInfo: xfkh0wpoxo3qxorr0wxvrqhubq/ X-Coremail-Antispam: 1Uk129KBj9xXoW7XF4UKr43Kw47Cr4kZF1UJwc_yoWfJrcE9r yIy39Fkw1UAFZ7ta1qgrn8AasrJFWUGryqv3ykWrsFv340v395urZY93s3CwnIqa9Ykr9x C3saqrW5A397CosvyTuYvTs0mTUanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUj1kv1TuYvT s0mT0YCTnIWjqI5I8CrVACY4xI64kE6c02F40Ex7xfYxn0WfASr-VFAUDa7-sFnT9fnUUI cSsGvfJTRUUUbakYFVCjjxCrM7AC8VAFwI0_Jr0_Gr1l1xkIjI8I6I8E6xAIw20EY4v20x vaj40_Wr0E3s1l1IIY67AEw4v_JrI_Jryl8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxS w2x7M28EF7xvwVC0I7IYx2IY67AKxVWUJVWUCwA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxV WUJVW8JwA2z4x0Y4vEx4A2jsIE14v26r4UJVWxJr1l84ACjcxK6I8E87Iv6xkF7I0E14v2 6r4UJVWxJr1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqjxCEc2xF0cIa020Ex4CE44I27w Aqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE 14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCYjI0SjxkI62AI1c AE67vIY487MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMxCIbckI1I0E 14v26r1Y6r17MI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4 CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1x MIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF 4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVWUJVW8JbIYCTnI WIevJa73UjIFyTuYvjxU25EfUUUUU X-Spam-Status: No, score=-8.5 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: 在 2023/12/22 下午3:09, Xi Ruoyao 写道: > On Fri, 2023-12-22 at 11:44 +0800, chenglulu wrote: >> 在 2023/12/21 下午8:00, chenglulu 写道: >>> Sorry, I've been busy with something else these two days. I don't >>> think there's anything wrong with the code, >>> >>> but I need to test the spec.:-) >> Hi, Ruoyao: >> >> After applying this patch, spec2006 464.h264 ref will have a 6.4% >> performance drop. So I'm going to retest it. > I think 6.4% is large enough not to be a random error. > > Is there an example showing the code regression? > > And I'm wondering if keeping the peephole besides the new > define_insn_and_split produces a better result instead of solely relying > on define_insn_and_split? > I haven't debugged this yet, I'm retesting, if there is still such a big performance gap, I think I need to see the reason.