From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id 49B163858D32 for ; Mon, 22 Aug 2022 09:06:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 49B163858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1C4881FB4B; Mon, 22 Aug 2022 09:06:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1661159207; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yKm3G/fFLdYNplvA223I3KqBu+a+a0/wygaE7Qih+ek=; b=Mnf9kQ9MREKqHiriTWpjzCxUGvgB91EH0p3PZ7ZEAGJsNiSEgyEOWVeLmVyQBH1vDSrVZQ +g12/sfTMOD9VjwVLTDt+fIMydryas1rY2CswnMwZM5IvdIwM2BrM2WAjYzDzz13d7WUNW YXr49Zo9Olv6iJokjyITsK2bGs4ReO8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1661159207; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yKm3G/fFLdYNplvA223I3KqBu+a+a0/wygaE7Qih+ek=; b=gmTp7Ya/I68B57xG+oqwEL7jI7q+bo6ojLc5KYhbOnQrvmJMzvb4cLpQDW1zvAay6AxXjg gjr/EhHNFKM8UxAw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 067AD13523; Mon, 22 Aug 2022 09:06:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id PvlyACdHA2PrZwAAMHmgww (envelope-from ); Mon, 22 Aug 2022 09:06:47 +0000 Content-Type: multipart/mixed; boundary="------------ZVsr0QCM5Rs3RTR7i7A5ZDYI" Message-ID: <8bc15a0b-83a5-2ef0-028a-ba3e8acc6d6a@suse.cz> Date: Mon, 22 Aug 2022 11:06:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Subject: Re: [PATCH] jobserver: detect properly O_NONBLOCK Content-Language: en-US To: Richard Biener Cc: GCC Patches References: From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, SPF_HELO_NONE, SPF_SOFTFAIL, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Aug 2022 09:06:54 -0000 This is a multi-part message in MIME format. --------------ZVsr0QCM5Rs3RTR7i7A5ZDYI Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/19/22 09:44, Richard Biener wrote: > libstdc++ uses > > # For Networking TS. > AC_CHECK_HEADERS([fcntl.h sys/ioctl.h sys/socket.h sys/uio.h poll.h > netdb.h arpa/inet.h netinet/in.h netinet/tcp.h]) > AC_CHECK_DECL(F_GETFL,,,[#include ]) > AC_CHECK_DECL(F_SETFL,,,[#include ]) > if test "$ac_cv_have_decl_F_GETFL$ac_cv_have_decl_F_SETFL" = yesyes ; then > AC_CHECK_DECL(O_NONBLOCK,,,[#include ]) > fi > > I'd rather not invent sth fancy with /dev/null (that seems very unixy) All right, there's v2. What do you think? Martin --------------ZVsr0QCM5Rs3RTR7i7A5ZDYI Content-Type: text/x-patch; charset=UTF-8; name="0001-jobserver-detect-properly-O_NONBLOCK.patch" Content-Disposition: attachment; filename="0001-jobserver-detect-properly-O_NONBLOCK.patch" Content-Transfer-Encoding: base64 RnJvbSBhMzc4OWYxNTFhOTJhMzExNDNhM2U2MmQ3ZTMzMzNlOWVjNzg4Nzk0IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJ0aW4gTGlza2EgPG1saXNrYUBzdXNlLmN6PgpE YXRlOiBUaHUsIDE4IEF1ZyAyMDIyIDEzOjAzOjQyICswMjAwClN1YmplY3Q6IFtQQVRDSF0g am9ic2VydmVyOiBkZXRlY3QgcHJvcGVybHkgT19OT05CTE9DSwoKZ2NjL0NoYW5nZUxvZzoK CgkqIGNvbmZpZ3VyZS5hYzogRGV0ZWN0IE9fTk9OQkxPQ0sgZmxhZyBmb3Igb3Blbi4KCSog Y29uZmlnLmluOiBSZWdlbmVyYXRlLgoJKiBjb25maWd1cmU6IFJlZ2VuZXJhdGUuCgkqIG9w dHMtY29tbW9uLmNjIChqb2JzZXJ2ZXJfaW5mbzo6Y29ubmVjdCk6IFNldCBpc19jb25uZWN0 ZWQKCSAgcHJvcGVybHkgYmFzZWQgb24gT19OT05CTE9DSy4KCSogb3B0cy1qb2JzZXJ2ZXIu aCAoc3RydWN0IGpvYnNlcnZlcl9pbmZvKTogQWRkIGlzX2Nvbm5lY3RlZAoJICBtZW1iZXIg dmFyaWFibGUuCgpnY2MvbHRvL0NoYW5nZUxvZzoKCgkqIGx0by5jYyAod2FpdF9mb3JfY2hp bGQpOiBBc2sgaWYgd2UgYXJlIGNvbm5lY3RlZCB0byBqb2JzZXJ2ZXIuCgkoc3RyZWFtX291 dF9wYXJ0aXRpb25zKTogTGlrZXdpc2UuCi0tLQogZ2NjL2NvbmZpZ3VyZSAgICAgICAgfCAy OSArKysrKysrKysrKysrKysrKysrKysrKysrKystLQogZ2NjL2NvbmZpZ3VyZS5hYyAgICAg fCAgOSArKysrKysrKysKIGdjYy9sdG8vbHRvLmNjICAgICAgIHwgMTIgKysrKysrLS0tLS0t CiBnY2Mvb3B0cy1jb21tb24uY2MgICB8IDExICsrKysrKysrKystCiBnY2Mvb3B0cy1qb2Jz ZXJ2ZXIuaCB8ICAyICsrCiA1IGZpbGVzIGNoYW5nZWQsIDU0IGluc2VydGlvbnMoKyksIDkg ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZ2NjL2NvbmZpZ3VyZSBiL2djYy9jb25maWd1 cmUKaW5kZXggZGE3YTQ1MDY2YjUuLjgwNDk4ZTY4ZTM2IDEwMDc1NQotLS0gYS9nY2MvY29u ZmlndXJlCisrKyBiL2djYy9jb25maWd1cmUKQEAgLTEyNDYwLDYgKzEyNDYwLDMxIEBAICRh c19lY2hvICIjZGVmaW5lIEhPU1RfSEFTX09fQ0xPRVhFQyAxIiA+PmNvbmZkZWZzLmgKIAog ZmkKIAorIyBDaGVjayBpZiBPX05PTkJMT0NLIGlzIGRlZmluZWQgYnkgZmNudGwKK2ZvciBh Y19oZWFkZXIgaW4gZmNudGwuaAorZG8gOgorICBhY19mbl9jeHhfY2hlY2tfaGVhZGVyX3By ZXByb2MgIiRMSU5FTk8iICJmY250bC5oIiAiYWNfY3ZfaGVhZGVyX2ZjbnRsX2giCitpZiB0 ZXN0ICJ4JGFjX2N2X2hlYWRlcl9mY250bF9oIiA9IHh5ZXM7IHRoZW4gOgorICBjYXQgPj5j b25mZGVmcy5oIDw8X0FDRU9GCisjZGVmaW5lIEhBVkVfRkNOVExfSCAxCitfQUNFT0YKKwor ZmkKK2RvbmUKKworYWNfZm5fY3h4X2NoZWNrX2RlY2wgIiRMSU5FTk8iICJPX05PTkJMT0NL IiAiYWNfY3ZfaGF2ZV9kZWNsX09fTk9OQkxPQ0siICIjaW5jbHVkZSA8ZmNudGwuaD4KKyIK K2lmIHRlc3QgIngkYWNfY3ZfaGF2ZV9kZWNsX09fTk9OQkxPQ0siID0geHllczsgdGhlbiA6 CisKK2ZpCisKK2lmIHRlc3QgJGFjX2N2X2hhdmVfZGVjbF9PX05PTkJMT0NLID0geWVzOyB0 aGVuCisKKyRhc19lY2hvICIjZGVmaW5lIEhPU1RfSEFTX09fTk9OQkxPQ0sgMSIgPj5jb25m ZGVmcy5oCisKK2ZpCisKKwogIyBDKysgTW9kdWxlcyB3b3VsZCBsaWtlIHNvbWUgbmV0d29y a2luZyBmZWF0dXJlcyB0byBwcm92aWRlIHRoZSBtYXBwaW5nCiAjIHNlcnZlci4gIFlvdSBj YW4gc3RpbGwgdXNlIG1vZHVsZXMgd2l0aG91dCB0aGVtIHRob3VnaC4KICMgVGhlIGZvbGxv d2luZyBuZXR3b3JrLXJlbGF0ZWQgY2hlY2tzIGNvdWxkIHByb2JhYmx5IGRvIHdpdGggc29t ZQpAQCAtMTk2NzgsNyArMTk3MDMsNyBAQCBlbHNlCiAgIGx0X2RsdW5rbm93bj0wOyBsdF9k bG5vX3VzY29yZT0xOyBsdF9kbG5lZWRfdXNjb3JlPTIKICAgbHRfc3RhdHVzPSRsdF9kbHVu a25vd24KICAgY2F0ID4gY29uZnRlc3QuJGFjX2V4dCA8PF9MVF9FT0YKLSNsaW5lIDE5Njgx ICJjb25maWd1cmUiCisjbGluZSAxOTcwNiAiY29uZmlndXJlIgogI2luY2x1ZGUgImNvbmZk ZWZzLmgiCiAKICNpZiBIQVZFX0RMRkNOX0gKQEAgLTE5Nzg0LDcgKzE5ODA5LDcgQEAgZWxz ZQogICBsdF9kbHVua25vd249MDsgbHRfZGxub191c2NvcmU9MTsgbHRfZGxuZWVkX3VzY29y ZT0yCiAgIGx0X3N0YXR1cz0kbHRfZGx1bmtub3duCiAgIGNhdCA+IGNvbmZ0ZXN0LiRhY19l eHQgPDxfTFRfRU9GCi0jbGluZSAxOTc4NyAiY29uZmlndXJlIgorI2xpbmUgMTk4MTIgImNv bmZpZ3VyZSIKICNpbmNsdWRlICJjb25mZGVmcy5oIgogCiAjaWYgSEFWRV9ETEZDTl9ICmRp ZmYgLS1naXQgYS9nY2MvY29uZmlndXJlLmFjIGIvZ2NjL2NvbmZpZ3VyZS5hYwppbmRleCBm NzBiNmMyNGZkYS4uODE5YjQ5MGQxYjYgMTAwNjQ0Ci0tLSBhL2djYy9jb25maWd1cmUuYWMK KysrIGIvZ2NjL2NvbmZpZ3VyZS5hYwpAQCAtMTcwNyw2ICsxNzA3LDE1IEBAIGlmIHRlc3Qg JGFjX2N2X29fY2xvZXhlYyA9IHllczsgdGhlbgogICBbRGVmaW5lIGlmIE9fQ0xPRVhFQyBz dXBwb3J0ZWQgYnkgZmNudGwuXSkKIGZpCiAKKyMgQ2hlY2sgaWYgT19OT05CTE9DSyBpcyBk ZWZpbmVkIGJ5IGZjbnRsCitBQ19DSEVDS19IRUFERVJTKFtmY250bC5oXSkKK0FDX0NIRUNL X0RFQ0woT19OT05CTE9DSywsLFsjaW5jbHVkZSA8ZmNudGwuaD5dKQoraWYgdGVzdCAkYWNf Y3ZfaGF2ZV9kZWNsX09fTk9OQkxPQ0sgPSB5ZXM7IHRoZW4KKyAgQUNfREVGSU5FKEhPU1Rf SEFTX09fTk9OQkxPQ0ssIDEsCisgIFtEZWZpbmUgaWYgT19OT05CTE9DSyBzdXBwb3J0ZWQg YnkgZmNudGwuXSkKK2ZpCisKKwogIyBDKysgTW9kdWxlcyB3b3VsZCBsaWtlIHNvbWUgbmV0 d29ya2luZyBmZWF0dXJlcyB0byBwcm92aWRlIHRoZSBtYXBwaW5nCiAjIHNlcnZlci4gIFlv dSBjYW4gc3RpbGwgdXNlIG1vZHVsZXMgd2l0aG91dCB0aGVtIHRob3VnaC4KICMgVGhlIGZv bGxvd2luZyBuZXR3b3JrLXJlbGF0ZWQgY2hlY2tzIGNvdWxkIHByb2JhYmx5IGRvIHdpdGgg c29tZQpkaWZmIC0tZ2l0IGEvZ2NjL2x0by9sdG8uY2MgYi9nY2MvbHRvL2x0by5jYwppbmRl eCBjODIzMDdmNGY3ZS4uM2E5MTQ3YjAxYjUgMTAwNjQ0Ci0tLSBhL2djYy9sdG8vbHRvLmNj CisrKyBiL2djYy9sdG8vbHRvLmNjCkBAIC0yMTMsMTEgKzIxMywxMSBAQCB3YWl0X2Zvcl9j aGlsZCAoKQogICAgIH0KICAgd2hpbGUgKCFXSUZFWElURUQgKHN0YXR1cykgJiYgIVdJRlNJ R05BTEVEIChzdGF0dXMpKTsKIAotICAgIC0tbnJ1bnM7CisgIC0tbnJ1bnM7CiAKLSAgICAv KiBSZXR1cm4gdG9rZW4gdG8gdGhlIGpvYnNlcnZlciBpZiBhY3RpdmUuICAqLwotICAgIGlm IChqaW5mbyAhPSBOVUxMICYmIGppbmZvLT5pc19hY3RpdmUpCi0gICAgICBqaW5mby0+cmV0 dXJuX3Rva2VuICgpOworICAvKiBSZXR1cm4gdG9rZW4gdG8gdGhlIGpvYnNlcnZlciBpZiBh Y3RpdmUuICAqLworICBpZiAoamluZm8gIT0gTlVMTCAmJiBqaW5mby0+aXNfY29ubmVjdGVk KQorICAgIGppbmZvLT5yZXR1cm5fdG9rZW4gKCk7CiB9CiAjZW5kaWYKIApAQCAtMjU0LDcg KzI1NCw3IEBAIHN0cmVhbV9vdXRfcGFydGl0aW9ucyAoY2hhciAqdGVtcF9maWxlbmFtZSwg aW50IGJsZW4sIGludCBtaW4sIGludCBtYXgsCiAgICAgIHN0cmVhbWluZyBwcm9jZXNzLiAg Ki8KICAgaWYgKCFsYXN0KQogICAgIHsKLSAgICAgIGlmIChqaW5mbyAhPSBOVUxMICYmIGpp bmZvLT5pc19hY3RpdmUpCisgICAgICBpZiAoamluZm8gIT0gTlVMTCAmJiBqaW5mby0+aXNf Y29ubmVjdGVkKQogCXdoaWxlICh0cnVlKQogCSAgewogCSAgICBpZiAoamluZm8tPmdldF90 b2tlbiAoKSkKQEAgLTI5MSw3ICsyOTEsNyBAQCBzdHJlYW1fb3V0X3BhcnRpdGlvbnMgKGNo YXIgKnRlbXBfZmlsZW5hbWUsIGludCBibGVuLCBpbnQgbWluLCBpbnQgbWF4LAogICAgICAg d2hpbGUgKG5ydW5zID4gMCkKIAl3YWl0X2Zvcl9jaGlsZCAoKTsKIAotICAgICAgaWYgKGpp bmZvICE9IE5VTEwgJiYgamluZm8tPmlzX2FjdGl2ZSkKKyAgICAgIGlmIChqaW5mbyAhPSBO VUxMICYmIGppbmZvLT5pc19jb25uZWN0ZWQpCiAJamluZm8tPmRpc2Nvbm5lY3QgKCk7CiAg ICAgfQogICBhc21fbm9kZXNfb3V0cHV0ID0gdHJ1ZTsKZGlmZiAtLWdpdCBhL2djYy9vcHRz LWNvbW1vbi5jYyBiL2djYy9vcHRzLWNvbW1vbi5jYwppbmRleCA0ZGVjOWY5NDQ0Ny4uYmZm MmJlMDJkMzggMTAwNjQ0Ci0tLSBhL2djYy9vcHRzLWNvbW1vbi5jYworKysgYi9nY2Mvb3B0 cy1jb21tb24uY2MKQEAgLTIwNjQsNyArMjA2NCwxNiBAQCB2b2lkCiBqb2JzZXJ2ZXJfaW5m bzo6Y29ubmVjdCAoKQogewogICBpZiAoIXBpcGVfcGF0aC5lbXB0eSAoKSkKLSAgICBwaXBl ZmQgPSBvcGVuIChwaXBlX3BhdGguY19zdHIgKCksIE9fUkRXUiB8IE9fTk9OQkxPQ0spOwor ICAgIHsKKyNpZiBIT1NUX0hBU19PX05PTkJMT0NLCisgICAgICBwaXBlZmQgPSBvcGVuIChw aXBlX3BhdGguY19zdHIgKCksIE9fUkRXUiB8IE9fTk9OQkxPQ0spOworICAgICAgaXNfY29u bmVjdGVkID0gdHJ1ZTsKKyNlbHNlCisgICAgICBpc19jb25uZWN0ZWQgPSBmYWxzZTsKKyNl bmRpZgorICAgIH0KKyAgZWxzZQorICAgIGlzX2Nvbm5lY3RlZCA9IHRydWU7CiB9CiAKIHZv aWQKZGlmZiAtLWdpdCBhL2djYy9vcHRzLWpvYnNlcnZlci5oIGIvZ2NjL29wdHMtam9ic2Vy dmVyLmgKaW5kZXggNzZjMWQ5YjI4ODIuLjI4NGIyNDE3ODM3IDEwMDY0NAotLS0gYS9nY2Mv b3B0cy1qb2JzZXJ2ZXIuaAorKysgYi9nY2Mvb3B0cy1qb2JzZXJ2ZXIuaApAQCAtNTUsNiAr NTUsOCBAQCBzdHJ1Y3Qgam9ic2VydmVyX2luZm8KICAgaW50IHBpcGVmZCA9IC0xOwogICAv KiBSZXR1cm4gdHJ1ZSBpZiBqb2JzZXJ2ZXIgaXMgYWN0aXZlLiAgKi8KICAgYm9vbCBpc19h Y3RpdmUgPSBmYWxzZTsKKyAgLyogUmV0dXJuIHRydWUgaWYgY29tbXVuaWNhdGlvbiB3aXRo IGpvYnNlcnZlciBpcyB3b3JraW5nLiAgKi8KKyAgYm9vbCBpc19jb25uZWN0ZWQgPSBmYWxz ZTsKIH07CiAKICNlbmRpZiAvKiBHQ0NfSk9CU0VSVkVSX0ggKi8KLS0gCjIuMzcuMgoK --------------ZVsr0QCM5Rs3RTR7i7A5ZDYI--