From: "Kewen.Lin" <linkw@linux.ibm.com>
To: GCC Patches <gcc-patches@gcc.gnu.org>
Cc: Peter Bergner <bergner@linux.ibm.com>,
David Edelsohn <dje.gcc@gmail.com>,
Segher Boessenkool <segher@kernel.crashing.org>
Subject: PING^1 [PATCH] rs6000: Fix some issues related to Power10 fusion [PR104024]
Date: Tue, 15 Mar 2022 19:35:52 +0800 [thread overview]
Message-ID: <8c25c645-fa61-aa44-3af7-7f98a91bbd2d@linux.ibm.com> (raw)
In-Reply-To: <7d52f901-8d59-1948-421f-680ba8b4cfce@linux.ibm.com>
Hi,
Gentle ping: https://gcc.gnu.org/pipermail/gcc-patches/2022-February/590692.html
BR,
Kewen
on 2022/2/22 10:47 AM, Kewen.Lin via Gcc-patches wrote:
> Hi,
>
> As PR104024 shows, currently the option -mpower10-fusion isn't guarded
> under -mcpu=power10, so compiler can optimize some patterns unexpectedly.
> As the option is undocumented, this patch just simply unmasks it.
> For some define_insns in fusion.md which have constraint v, they don't
> have the correct conditions there, it can cause ICEs if the modes are
> not supported there. Besides, it seems better to use BOOL_128 instead
> of VM since the patterns are vector logical operations.
>
> Bootstrapped and regtested on powerpc64-linux-gnu P8 and
> powerpc64le-linux-gnu P9 and P10.
>
> Is it ok for trunk?
>
> BR,
> Kewen
> -----
> PR target/104024
>
> gcc/ChangeLog:
>
> * config/rs6000/fusion.md: Regenerate.
> * config/rs6000/genfusion.pl: Add the check for define_insns
> with constraint v, use BOOL_128 instead of VM.
>
> gcc/testsuite/ChangeLog:
>
> * gcc.target/powerpc/pr104024-1.c: New test.
> * gcc.target/powerpc/pr104024-2.c: New test.
next prev parent reply other threads:[~2022-03-15 11:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 2:47 Kewen.Lin
2022-03-15 11:35 ` Kewen.Lin [this message]
2022-11-30 8:30 Kewen.Lin
2022-12-14 11:25 ` PING^1 " Kewen.Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c25c645-fa61-aa44-3af7-7f98a91bbd2d@linux.ibm.com \
--to=linkw@linux.ibm.com \
--cc=bergner@linux.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).