* [PATCH] [OG10] Fix warning messages in privatized-ref-[23].C testcases
@ 2020-09-16 10:33 Kwok Cheung Yeung
2020-09-17 10:27 ` [PATCH] [OG10] Fix warning messages in privatized-ref-1.f95 testcase Kwok Cheung Yeung
0 siblings, 1 reply; 2+ messages in thread
From: Kwok Cheung Yeung @ 2020-09-16 10:33 UTC (permalink / raw)
To: GCC Patches, Tobias Burnus, Thomas Schwinge
[-- Attachment #1: Type: text/plain, Size: 539 bytes --]
Hello
The libgomp.oacc-c++/privatized-ref-[23].C testcases request 64 workers in a
parallel section, but Nvidia only supports a maximum of 32 workers, and GCN a
maximum of 16. The worker numbers are overridden by the compiler with a warning
message printed, which causes test failures on Nvidia. On GCN, the warning
message is not printed by default (enabled by -foffload=-Wopenacc-dims).
This patch fixes this by requesting 16 workers, which is acceptable on both
Nvidia and AMD GCN. Committed on the OG10 branch as obvious.
Kwok
[-- Attachment #2: privatized-ref_fix.patch --]
[-- Type: text/plain, Size: 2706 bytes --]
commit 15967a2016248eb04ef493af4e4889ceef9890b3
Author: Kwok Cheung Yeung <kcy@codesourcery.com>
Date: Wed Sep 16 03:18:54 2020 -0700
Fix warning messages in libgomp.oacc-c++/privatized-ref-[23].C testcases
More workers are requested than are supported, resulting in warning messages
as the number of workers is overridden.
2020-09-16 Kwok Cheung Yeung <kcy@codesourcery.com>
libgomp/
* testsuite/libgomp.oacc-c++/privatized-ref-2.C (workers, vectors):
Reduce number of workers to 16.
* testsuite/libgomp.oacc-c++/privatized-ref-3.C (workers, vectors):
Likewise.
diff --git a/libgomp/ChangeLog.omp b/libgomp/ChangeLog.omp
index 4f56f55..6e313aa 100644
--- a/libgomp/ChangeLog.omp
+++ b/libgomp/ChangeLog.omp
@@ -1,3 +1,10 @@
+2020-09-16 Kwok Cheung Yeung <kcy@codesourcery.com>
+
+ * testsuite/libgomp.oacc-c++/privatized-ref-2.C (workers, vectors):
+ Reduce number of workers to 16.
+ * testsuite/libgomp.oacc-c++/privatized-ref-3.C (workers, vectors):
+ Likewise.
+
2020-09-15 Tobias Burnus <tobias@codesourcery.com>
Backport from mainline
diff --git a/libgomp/testsuite/libgomp.oacc-c++/privatized-ref-2.C b/libgomp/testsuite/libgomp.oacc-c++/privatized-ref-2.C
index 3884f16..052ccc5 100644
--- a/libgomp/testsuite/libgomp.oacc-c++/privatized-ref-2.C
+++ b/libgomp/testsuite/libgomp.oacc-c++/privatized-ref-2.C
@@ -7,7 +7,7 @@ void workers (void)
double res[65536];
int i;
-#pragma acc parallel copyout(res) num_gangs(64) num_workers(64)
+#pragma acc parallel copyout(res) num_gangs(64) num_workers(16)
{
int i, j;
#pragma acc loop gang
@@ -34,7 +34,7 @@ void vectors (void)
double res[65536];
int i;
-#pragma acc parallel copyout(res) num_gangs(64) num_workers(64)
+#pragma acc parallel copyout(res) num_gangs(64) num_workers(16)
{
int i, j;
#pragma acc loop gang worker
diff --git a/libgomp/testsuite/libgomp.oacc-c++/privatized-ref-3.C b/libgomp/testsuite/libgomp.oacc-c++/privatized-ref-3.C
index c1a10cb..d887178 100644
--- a/libgomp/testsuite/libgomp.oacc-c++/privatized-ref-3.C
+++ b/libgomp/testsuite/libgomp.oacc-c++/privatized-ref-3.C
@@ -7,7 +7,7 @@ void workers (void)
double res[65536];
int i;
-#pragma acc parallel copyout(res) num_gangs(64) num_workers(64)
+#pragma acc parallel copyout(res) num_gangs(64) num_workers(16)
{
int i, j;
int tmpvar;
@@ -34,7 +34,7 @@ void vectors (void)
double res[65536];
int i;
-#pragma acc parallel copyout(res) num_gangs(64) num_workers(64)
+#pragma acc parallel copyout(res) num_gangs(64) num_workers(16)
{
int i, j;
int tmpvar;
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] [OG10] Fix warning messages in privatized-ref-1.f95 testcase
2020-09-16 10:33 [PATCH] [OG10] Fix warning messages in privatized-ref-[23].C testcases Kwok Cheung Yeung
@ 2020-09-17 10:27 ` Kwok Cheung Yeung
0 siblings, 0 replies; 2+ messages in thread
From: Kwok Cheung Yeung @ 2020-09-17 10:27 UTC (permalink / raw)
To: GCC Patches, Tobias Burnus, Thomas Schwinge
[-- Attachment #1: Type: text/plain, Size: 727 bytes --]
The libgomp.oacc-fortran/privatized-ref-1.f95 also has the same issue, and has
been fixed in the same way.
Kwok
On 16/09/2020 11:33 am, Kwok Cheung Yeung wrote:
> Hello
>
> The libgomp.oacc-c++/privatized-ref-[23].C testcases request 64 workers in a
> parallel section, but Nvidia only supports a maximum of 32 workers, and GCN a
> maximum of 16. The worker numbers are overridden by the compiler with a warning
> message printed, which causes test failures on Nvidia. On GCN, the warning
> message is not printed by default (enabled by -foffload=-Wopenacc-dims).
>
> This patch fixes this by requesting 16 workers, which is acceptable on both
> Nvidia and AMD GCN. Committed on the OG10 branch as obvious.
>
> Kwok
[-- Attachment #2: privatized-ref-1_f95_fix.patch --]
[-- Type: text/plain, Size: 1722 bytes --]
commit abe747ac4e1e7c6a14b0877b88a7555b11e6bcb1
Author: Kwok Cheung Yeung <kcy@codesourcery.com>
Date: Thu Sep 17 03:16:04 2020 -0700
Fix warning messages in libgomp.oacc-fortran/privatized-ref-1.f95 testcase
2020-09-17 Kwok Cheung Yeung <kcy@codesourcery.com>
libgomp/
* testsuite/libgomp.oacc-fortran/privatized-ref-1.f95 (workers, vectors):
Reduce number of workers to 16.
diff --git a/libgomp/ChangeLog.omp b/libgomp/ChangeLog.omp
index 890a4e2..fbe8bb4 100644
--- a/libgomp/ChangeLog.omp
+++ b/libgomp/ChangeLog.omp
@@ -1,3 +1,8 @@
+2020-09-17 Kwok Cheung Yeung <kcy@codesourcery.com>
+
+ * testsuite/libgomp.oacc-fortran/privatized-ref-1.f95 (workers, vectors):
+ Reduce number of workers to 16.
+
2020-09-16 Kwok Cheung Yeung <kcy@codesourcery.com>
* testsuite/libgomp.oacc-fortran/privatized-ref-2.f90: XFAIL on nvptx.
diff --git a/libgomp/testsuite/libgomp.oacc-fortran/privatized-ref-1.f95 b/libgomp/testsuite/libgomp.oacc-fortran/privatized-ref-1.f95
index f16f69c..e4b8520 100644
--- a/libgomp/testsuite/libgomp.oacc-fortran/privatized-ref-1.f95
+++ b/libgomp/testsuite/libgomp.oacc-fortran/privatized-ref-1.f95
@@ -34,7 +34,7 @@ contains
integer :: i, j
real, intent(out) :: res(:)
- !$acc parallel copyout(res) num_gangs(64) num_workers(64)
+ !$acc parallel copyout(res) num_gangs(64) num_workers(16)
!$acc loop gang
do i=0,255
@@ -54,7 +54,7 @@ contains
integer :: i, j
real, intent(out) :: res(:)
- !$acc parallel copyout(res) num_gangs(64) num_workers(64)
+ !$acc parallel copyout(res) num_gangs(64) num_workers(16)
!$acc loop gang worker
do i=0,255
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-17 10:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-16 10:33 [PATCH] [OG10] Fix warning messages in privatized-ref-[23].C testcases Kwok Cheung Yeung
2020-09-17 10:27 ` [PATCH] [OG10] Fix warning messages in privatized-ref-1.f95 testcase Kwok Cheung Yeung
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).