From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id E2FFD3857350; Mon, 24 Jul 2023 20:05:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E2FFD3857350 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="6.01,228,1684828800"; d="scan'208";a="14260834" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa1.mentor.iphmx.com with ESMTP; 24 Jul 2023 12:05:54 -0800 IronPort-SDR: uskNOStU36Ecga3JDEIo4N+Hkw/NglE0uuDcDI+42IBM7Rg8UrnCnakxOWSxbcXmRewyDrw//g XGbPNijiaybnceu3Xfsme7YkW344jr3oY1F5fPNcZjbg/yv0iX5fM80n9F6NDR9DBdQ3iSPJUx oBiuYtEjL39pFcqD7AVgJB3WnrCEv1eHvmExp0u9nDoEjmjv199Jgju/dW2DrHfINW2pjeaguA AmYSnJ5KJRECfqMjvVf7J3KcdXru8JCJC/UIZOUK+ubJx3N2mbkEVNFhFqWkU4sATUzS3VEmju P2g= Message-ID: <8c753767-dede-d297-8be2-a46d5a333f16@codesourcery.com> Date: Mon, 24 Jul 2023 22:05:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [Patch] OpenMP/Fortran: Reject not strictly nested target -> teams [PR110725, PR71065] Content-Language: en-US To: Jakub Jelinek CC: gcc-patches , fortran References: From: Tobias Burnus In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-15.mgc.mentorg.com (139.181.222.15) To svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 24.07.23 21:49, Jakub Jelinek via Fortran wrote: > Thanks for working on this. The fuzzy thing on the Fortran side is > if e.g. multiple nested BLOCK statements can appear sandwiched in between > target and teams (of course without declarations in them), or if e.g. The current patch rejects nested blocks, be it 'omp target; block; block; omp teams;' or be it 'omp target; block; block;end block; omp teams'= . The current wording in the spec is also rather explicit as 'block' is a statement. (BTW: For 'block; block; omp teams', the simplistic search won't work such that for those only the location of TARGET and not of TEAMS is shown. I could try harder but as it is useful as is and such code should be rare, I don't do it.) Thus, I believe the patch should be fine. Tobias PS: I know that some regard {{{ }}} and block; block, ... end block; ... as something to be ignored. Thus, for 'omp atomic', TR12 will allow any number of curly braces and BLOCK/ENDBLOCK pairs. The wording there is rather explicit but also localized, i.e. it won't affect other code locations (for now at least). ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955