From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 99E7B3858D28 for ; Tue, 2 Apr 2024 17:16:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 99E7B3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 99E7B3858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712078175; cv=none; b=b+9JdgxWnADgh5StqV3/5OkZj8RJhP735rxCIsVObX30NcpHxzLGxhO37N8vSoaQz+1x8W9qUQ9a8NCN1Z9p3CSEEG7dogX8ZP/bNd32IXF4394XJG6VakAEBIAJvn8Zjeh8BHGwDTfQzhw9v7scX7yzYdsyWDupOzk2baHSBDE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712078175; c=relaxed/simple; bh=5Dl9AZFg3AYgX3J6/F1DbnSp94QyqJ5TPsj/zkbAhLM=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=RgEy7NnojIrR7H8BXvgS761XHXlkpQ5ohLumc6H8SftTjVK5vvETx9lAfleR/+LM71LIHKPMOX8nvLMOYZmXLe1nVBq3OZE1UqTSAfzs+PWoAEdpdsvmCeF88EKx336lXYsljRNce729oQG9g286SunRjx+3MEButIjUUxkA7tA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712078172; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MBO/dlDg9pBVp3XlJxXavG8SqxZVyiWyBh2A2rZZxzc=; b=R1PLZDs+3/QekClRvZCxAUS9ztaeWb1TcRkkAUg2ZctM4S6+Kw0+nk9dxZfZDih/+2k5Aj /kR5jwxnwtYqrMHD68kh9JC+Bu0VnhAU7I8hGxzL4KKtULjY5cgF+Ri7xXR4r57gFpw8ko U2ZBloX6VcnKfD7J9sVIfny57CCk0i4= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-361-OwWBFPOjPXSlKiFHPzn4XQ-1; Tue, 02 Apr 2024 13:16:10 -0400 X-MC-Unique: OwWBFPOjPXSlKiFHPzn4XQ-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-69924edc4feso1051456d6.1 for ; Tue, 02 Apr 2024 10:16:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712078170; x=1712682970; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MBO/dlDg9pBVp3XlJxXavG8SqxZVyiWyBh2A2rZZxzc=; b=pWbz8OMHnkk5q9I1cIGO7xsASXWbeTsqX/9mLPsRMkhjUtFxR7ji5t3j2plWbF2FtG FUD6hdVbrUuKtwtsJUB9FJGu7ZYwVMKG+OjVATmHFhEbiCe+7pFMv2znaIWzyo/gP7+S 21JNIAkBW4TAHKf2DdAbH+ZN0/4FAOJMNKNouAh3gt1Y1z+Q6tWqqBp/2SSq6yX1LcKC 20nOM2PGzHJ3BHgMUq4VxzeMJpA6aVt73klp+ad9eHis9VA6aat7jD6xYoU0JFlCPo2X xl1QFWQyrK9eslQVO6ArTRUb523NBBB+uz9xz3dxnp610inDKBnHEO6FkE9YKvP9H8/O 7IfA== X-Forwarded-Encrypted: i=1; AJvYcCXYYdHrTk82A7tYPAEFxlRBaG3v4/beoZz+YgnKQ6Mah1Qwc9N6j0ouUbU0GkeaEak8Aco6W0VMJ3VeW4iu/uJZCUy1F2cglw== X-Gm-Message-State: AOJu0Yxcjg7/aExfP5yiE7CJbvxkf1Z5X6p/1LyQu/HzDOwPdWDeAGKO 0Q046w4FgHLzBO22X5jA06w1Lf9oJBLiHimYz97Ihp0g9s47aqJCxn0yhs+Wl/t8FjYuyU7wyaC CzXKhA7p2jiVWpabss53IqIQcJ09hd3j25v2/kfmEau7xAqsta3+2iLlSjDRDrqM= X-Received: by 2002:a0c:9b0a:0:b0:696:79f1:c637 with SMTP id b10-20020a0c9b0a000000b0069679f1c637mr232802qve.25.1712078169827; Tue, 02 Apr 2024 10:16:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFVoNAhmz2lufb2AE1qG/6TQ+57pjXRCSQEOCOxPxeDANqFkdo3GQziEVN2GwrsurSKFJ4zcA== X-Received: by 2002:a0c:9b0a:0:b0:696:79f1:c637 with SMTP id b10-20020a0c9b0a000000b0069679f1c637mr232773qve.25.1712078169536; Tue, 02 Apr 2024 10:16:09 -0700 (PDT) Received: from [192.168.1.130] (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id h6-20020a0562140da600b006986fc6582dsm5531617qvh.57.2024.04.02.10.16.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Apr 2024 10:16:08 -0700 (PDT) Message-ID: <8c8105b6-f022-4a3b-a8d2-6105805d75ed@redhat.com> Date: Tue, 2 Apr 2024 13:16:07 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] c++: ICE with scoped enum in switch condition [PR114451] To: Marek Polacek , GCC Patches References: <20240329223101.421760-1-polacek@redhat.com> From: Jason Merrill In-Reply-To: <20240329223101.421760-1-polacek@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/29/24 18:31, Marek Polacek wrote: > Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk/13? OK. > -- >8 -- > Here we ICE when gimplifying > > enum class Type { Pawn }; > struct Piece { > Type type : 4; > }; > void foo() { > switch (Piece().type) > case Type::Pawn:; > } > > because we ended up with TYPE_PRECISION (cond) < TYPE_PRECISION (case). > That's because the case expr type here is the unlowered type Type, > whereas the conditional's type is the lowered . This > is not supposed to happen: see the comment in pop_switch around the > is_bitfield_expr_with_lowered_type check. > > But here we did not revert to the lowered SWITCH_STMT_TYPE, because > the conditional contains a TARGET_EXPR, which has side-effects, which > means that finish_switch_cond -> maybe_cleanup_point_expr wraps it > in a CLEANUP_POINT_EXPR. And is_bitfield_expr_with_lowered_type does > not see through those. > > PR c++/103825 > > gcc/cp/ChangeLog: > > * typeck.cc (is_bitfield_expr_with_lowered_type): Handle > CLEANUP_POINT_EXPR. > > gcc/testsuite/ChangeLog: > > * g++.dg/cpp0x/enum44.C: New test. > --- > gcc/cp/typeck.cc | 1 + > gcc/testsuite/g++.dg/cpp0x/enum44.C | 30 +++++++++++++++++++++++++++++ > 2 files changed, 31 insertions(+) > create mode 100644 gcc/testsuite/g++.dg/cpp0x/enum44.C > > diff --git a/gcc/cp/typeck.cc b/gcc/cp/typeck.cc > index f5a0a2273be..9a096b51d55 100644 > --- a/gcc/cp/typeck.cc > +++ b/gcc/cp/typeck.cc > @@ -2400,6 +2400,7 @@ is_bitfield_expr_with_lowered_type (const_tree exp) > case NEGATE_EXPR: > case NON_LVALUE_EXPR: > case BIT_NOT_EXPR: > + case CLEANUP_POINT_EXPR: > return is_bitfield_expr_with_lowered_type (TREE_OPERAND (exp, 0)); > > case COMPONENT_REF: > diff --git a/gcc/testsuite/g++.dg/cpp0x/enum44.C b/gcc/testsuite/g++.dg/cpp0x/enum44.C > new file mode 100644 > index 00000000000..92408c92217 > --- /dev/null > +++ b/gcc/testsuite/g++.dg/cpp0x/enum44.C > @@ -0,0 +1,30 @@ > +// PR c++/103825 > +// { dg-do compile { target c++11 } } > + > +enum class Type { Pawn }; > +struct Piece { > + Type type : 4; > +}; > + > +void > +foo () > +{ > + switch (Piece().type) > + case Type::Pawn:; > + > + auto x = Piece().type; > + switch (x) > + case Type::Pawn:; > +} > + > +enum class En {A}; > +struct St {En field :1;}; > + > +void > +bar () > +{ > + volatile St s = {En::A}; > + switch(s.field) { > + case En::A : break; > + } > +} > > base-commit: 4c18ace1cb69a31af4ac719850a66de79ed12e93