From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by sourceware.org (Postfix) with ESMTPS id 449323857C51 for ; Fri, 18 Nov 2022 19:13:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 449323857C51 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x62b.google.com with SMTP id b21so5372900plc.9 for ; Fri, 18 Nov 2022 11:13:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QeF+2nSMw4zMGKc6sWR3HPEfkQBKC9L7KVDo/NVVw5M=; b=aWLupxoW9hpvvWcMHL4adZADAQJ6B9vK7rYslLO82L9JkBwCKg5fcw4IVJObDaDo85 Jd9KQveqXlJ8iXCt+ePeh/Q7Julg9HLPc4ILdwzJaF/gdrZsTGPKGSYUli4SKeAB07jE LSdRhwQKCc31v+Qzo0AApSaQfCm2Vqk7Av41c741OMypGRmKgMUJ0W5zmM1yien0F6Eh 32cORjZH5OJWIZBXFWnciFfHB2BCrQrS/KtGvF+Yq++SHaA7sHKomoWd9SW6ZqyKsa8P ctz2ZdvwtAI8nGcE763JRZe7xe0Y9moAvfbiMhpMS1JXgstPrUoyZ9vJ86/v+3MVsHVG 7k7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QeF+2nSMw4zMGKc6sWR3HPEfkQBKC9L7KVDo/NVVw5M=; b=SkVu0jeLRD0MdZU8dsCWD+kUxmrf4tmTj7oe8CW5YGvZhVhqlGUJ3DViV2ghISliJk r+qpenMknhJc4KyFR/jgUZEn6n1t/Ua6wA+PRJ8HQ/jn95p3w9ry8/iSxzkDFE2+bgKJ rfNAFlM3hhjvHcDMOnfj0cFLXnM34Hjcp6ADf092XtkR0GPnxTaqQ2YN+KQgNUSdb8Ux IpTuGmAUb6XgMsMYYiJJMMvJy5Pm/tKlaw5sXGO/iGre1P1RRCu9lL+8HvpLk/K6MWlo KITnKJlifC+twBbY1Fp/6BO8o7XjLqJcsFKZGuJNp0W1o4oItyPFcLnK/kJS+cuE79hb arwA== X-Gm-Message-State: ANoB5pmxFYlKpbOn1mlpVTQxwt9zCPZ7I22BQPkhlaFSTciqjI2F/2H+ a6NvX3oKcw4kql+JB6ZYxCk= X-Google-Smtp-Source: AA0mqf78/cxWuQXxnfjIVW/BiXjJ61ANtAYkzdOGChoUcUGtuoSscEluzSXXr4XRKmCTIhShEq8Kxg== X-Received: by 2002:a17:90a:c381:b0:212:bfc3:3271 with SMTP id h1-20020a17090ac38100b00212bfc33271mr8925916pjt.99.1668798827793; Fri, 18 Nov 2022 11:13:47 -0800 (PST) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id na4-20020a17090b4c0400b0020c899b11f1sm5792204pjb.23.2022.11.18.11.13.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Nov 2022 11:13:47 -0800 (PST) Message-ID: <8ca4581a-cd38-5ba0-2bdc-158d58fdf52a@gmail.com> Date: Fri, 18 Nov 2022 12:13:45 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v2 0/2] Use Zbs with xori/ori/andi and polarity-reversed twobit-tests Content-Language: en-US To: Philipp Tomsich , gcc-patches@gcc.gnu.org Cc: Kito Cheng , Palmer Dabbelt , Vineet Gupta , Jeff Law , Christoph Muellner References: <20221118111001.1488517-1-philipp.tomsich@vrull.eu> From: Jeff Law In-Reply-To: <20221118111001.1488517-1-philipp.tomsich@vrull.eu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/18/22 04:09, Philipp Tomsich wrote: > We had a few patches on the list that shared predicates (for extending > the reach of xori and ori -- and for the branches on two > polarity-reversed bits) and thus depended on each other. > > These all had approval with requested changes, so these are now > collected together for v2. > > Note that this adds the (a & ~C) case, so please take a look on that > part and OK the updated series. > > > > Changes in v2: > - Collects already approved changes for v2 for (a | C) and (a ^ C). > - Pulls in the (already) approved branch on polarity-reversed bits > for v2, as it shares predicates with the other changes. > - Newly adds support for the (a & ~C) case. > > Philipp Tomsich (2): > RISC-V: Use bseti/bclri/binvi to extend reach of ori/andi/xori > RISC-V: Handle "(a & twobits) == singlebit" in branches using Zbs > > gcc/config/riscv/bitmanip.md | 79 +++++++++++++++++++ > gcc/config/riscv/iterators.md | 8 ++ > gcc/config/riscv/predicates.md | 33 ++++++++ > gcc/config/riscv/riscv.h | 8 ++ > .../riscv/{zbs-bclri.c => zbs-bclri-01.c} | 0 > gcc/testsuite/gcc.target/riscv/zbs-bclri-02.c | 27 +++++++ > gcc/testsuite/gcc.target/riscv/zbs-binvi.c | 22 ++++++ > gcc/testsuite/gcc.target/riscv/zbs-bseti.c | 27 +++++++ > .../gcc.target/riscv/zbs-if_then_else-01.c | 20 +++++ > 9 files changed, 224 insertions(+) > rename gcc/testsuite/gcc.target/riscv/{zbs-bclri.c => zbs-bclri-01.c} (100%) > create mode 100644 gcc/testsuite/gcc.target/riscv/zbs-bclri-02.c > create mode 100644 gcc/testsuite/gcc.target/riscv/zbs-binvi.c > create mode 100644 gcc/testsuite/gcc.target/riscv/zbs-bseti.c > create mode 100644 gcc/testsuite/gcc.target/riscv/zbs-if_then_else-01.c 1/2 and 2/2 are both OK. jeff