From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 00F4D385E827 for ; Tue, 2 Apr 2024 20:31:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 00F4D385E827 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 00F4D385E827 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712089920; cv=none; b=MEd9xTTFI4sPnqATWB3gSLEOglf/iecJv6y3DurGkMV2ZTb7I+7w7m3V3akdoes81eCCLlQ3k7GM5+oVB5zuWHjJGxKWX76ZfE6y7Bm8vb3n9NfJxfb65GBgkqFZBOphz3tjc6X6xOhaqBhhgSyNq8IghpY89jOZJfBPGQzkJx8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712089920; c=relaxed/simple; bh=q/1nvXPPqoP6dBtf7MPioqi7BwzQBWpf1vuAuyXQetc=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=WHHrkFvqMs7Pi68GTB4cUOTUDRNb7q+PJdsEmNhQdnZn6K5TQNzVNmLOkdpvtHWJjJRF2DPHnCP9ThBrEN/JgrCdXtL1pqfEwQFJHb+VBvgjdNDgEbiMvAwsv9qHmsHnaVamcQQv2bvW5lLMDLpTNrEsiIRyeM2N0Jyrf0W2ukQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712089918; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DulhO9uyDDNF4WG29Uqgt5fYkpE9QAXnGwGDkiygVf4=; b=KFYipSU7nGryk77G1GPI0v4FVCXIzpIv1pPdMpNXyIMlzM9r/m3MIYYTjjCHWG8SO8EUNX UD8I396FDjuRYdoieUPh2Fwo8YKv+YTMAhhTbxPrcDS9KQzwsTHD4lOtwBexxEAM6uAF+c bl5JlMnVRDDeBRf7Xtk5laC98bNzPZY= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-184-9g5YS9QaM06OIco2fho7RA-1; Tue, 02 Apr 2024 16:31:57 -0400 X-MC-Unique: 9g5YS9QaM06OIco2fho7RA-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2d835fe0b39so3744271fa.3 for ; Tue, 02 Apr 2024 13:31:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712089915; x=1712694715; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DulhO9uyDDNF4WG29Uqgt5fYkpE9QAXnGwGDkiygVf4=; b=FAFtXMxkpwbkmx1kaSJRN2BTZuIb7dr9NTEptypHeYeMwsQaS8Be0Wwyrja+qCaPkm mh4RsQU8ag4c3YM2wlo4pnkzTgCU+9tOnKvICJDoFlBMf8tMhlXmSY6fJN4VJM+bx7/C 1uGoWrFwinCgXN5jo8NJD/eTp+28j5Lm+zs2d2dtYZiX9ypGQnvkDzX+EiEc3pieKT3H hahVUHnqduGcwyQinQrOG4f4mKqC6QYdzvC+nbo717AMiLW4+W1yEPwdJPLzIReqCDz1 rAPQN6psKJS5mpFPGCgmf0vkadwAd22YvhS3eX9G6mk0PufbvIRv5dFDhfFj00FhvP7j IUTA== X-Gm-Message-State: AOJu0YyDDsZpJaPbHRyB+RUsRBZyoZqmi+LW1AYgxwOmwHAgurye8sp7 5puy4o2VYEuxnx11bbJ9KPgcFxaM76qPu4rR7mo6gBvUWtKiYWFKMRFnojm80/7Zz5xJqYERDb8 OgzcGDL2yfur4XeDPfGSs4F27wBqUtFp/S+j2StS0dRh94BKwUL3k348= X-Received: by 2002:a2e:b009:0:b0:2d7:8152:1ee5 with SMTP id y9-20020a2eb009000000b002d781521ee5mr7197042ljk.31.1712089914974; Tue, 02 Apr 2024 13:31:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFYPm81Ttw6eIUAIO/z1QodBKk4sbo0Pw9uHhhFAmfmJ0LP7aYQKeX+lR163MOw9D6h5icR1A== X-Received: by 2002:a2e:b009:0:b0:2d7:8152:1ee5 with SMTP id y9-20020a2eb009000000b002d781521ee5mr7197024ljk.31.1712089914514; Tue, 02 Apr 2024 13:31:54 -0700 (PDT) Received: from digraph.polyomino.org.uk (digraph.polyomino.org.uk. [2001:8b0:bf73:93f7::51bb:e332]) by smtp.gmail.com with ESMTPSA id m28-20020a05600c3b1c00b00414688af147sm22383155wms.20.2024.04.02.13.31.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 13:31:54 -0700 (PDT) Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.95) (envelope-from ) id 1rrkmu-0022jt-KT; Tue, 02 Apr 2024 20:31:20 +0000 Date: Tue, 2 Apr 2024 20:31:20 +0000 (UTC) From: Joseph Myers To: Martin Uecker cc: gcc-patches@gcc.gnu.org Subject: Re: [C PATCH] Fix ICE with -g and -std=c23 related to incomplete types [PR114361] In-Reply-To: Message-ID: <8ca93241-716e-644a-2b10-a55b55a746db@redhat.com> References: <02a9b94e4d653b6f1b9f89a1b62187f46e871738.camel@tugraz.at> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 2 Apr 2024, Martin Uecker wrote: > Fix ICE with -g and -std=c23 related to incomplete types [PR114361] > > We did not copy TYPE_CANONICAL to the incomplete variants when > completing a structure. > > PR c/114361 > > gcc/c/ > * c-decl.c (finish_struct): Set TYPE_CANONICAL when completing > strucute types. > > gcc/testsuite/ > * gcc.dg/pr114361.c: New test. > * gcc.dg/c23-tag-incomplete-1.c: New test. > * gcc.dg/c23-tag-incomplete-2.c: New test. OK. -- Joseph S. Myers josmyers@redhat.com