From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from xry111.site (xry111.site [89.208.246.23]) by sourceware.org (Postfix) with ESMTPS id 49AEC3858D28 for ; Tue, 4 Oct 2022 13:14:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 49AEC3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=xry111.site Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xry111.site DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site; s=default; t=1664889243; bh=1iWCwp/yLvZ+Wa39X6h5RPV4U/lWOabjXRT0Gi/Z3s0=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=mug0b+4iLlIKUS0BN7RlTa1Tl4UsDxUMfj40auWPe8wzrmp6Xi3pxl/TPF+O3mnGs viG4zt3w3+iHWagckWxG74QEc7rQr6TaEqJq5Lj/6B2Au5I3yNTV2MWYu2uxA4c3sK +97GMTIdWdgAXmiusnVH6QKjYRcwWJZDOD/hkuME= Received: from [IPv6:240e:358:11e4:2500:dc73:854d:832e:2] (unknown [IPv6:240e:358:11e4:2500:dc73:854d:832e:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384)) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id 4085965C44; Tue, 4 Oct 2022 09:13:59 -0400 (EDT) Message-ID: <8ccc48f13c385c6c3583cc9e63a09457163dcd23.camel@xry111.site> Subject: Re: Adding a new thread model to GCC From: Xi Ruoyao To: LIU Hao Cc: gcc-patches@gcc.gnu.org Date: Tue, 04 Oct 2022 21:13:50 +0800 In-Reply-To: References: <0f1f223a-3756-1da3-bd1d-b87edd34e1f9@126.com> <7116A6F3-3968-4720-A65C-FFB05BFE181D@gmail.com> <7c519f0b-2a6d-e9bf-993a-2eff2cdad418@126.com> <0F33BB41-41EC-4068-84F1-9AD6DCCF190A@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.0 MIME-Version: 1.0 X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FROM_SUSPICIOUS_NTLD,KAM_SHORT,LIKELY_SPAM_FROM,SPF_HELO_PASS,SPF_PASS,TXREP,T_PDS_OTHER_BAD_TLD autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: I don't really understand MinGW, but some "non-technical" things: On Tue, 2022-10-04 at 20:44 +0800, LIU Hao via Gcc-patches wrote: > After applying these patches, configure scripts in these > subdirectories need to be regenerated: >=20 > =C2=A0=C2=A0 * gcc > =C2=A0=C2=A0 * libgcc > =C2=A0=C2=A0 * libatomic > =C2=A0=C2=A0 * libstdc++-v3 In GCC development we usually include the configure regeneration in the patch because the scripts are also version controlled. > The patch for libgfortran fixes >=20 > * https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D105764 It's better to include the ID in the subject and ChangeLog of the patch. Like: [PATCH 1/3] libgfortran: Use `__gthread_t` instead of `pthread_t` [PR 10= 5764] =20 It used to cause errors if a thread model other than `posix` was selecte= d, which looks like a leftover from a79878585a1c5e32bafbc6d1e73f91fd6e4293b= f. =20 libgfortran/ChangeLog: =20 PR libgfortran/105764 * io/async.h (struct async_unit): Use `__gthread_t` instead of `pthread_t`. This allows a git hook to append a message into the PR 105764 entry in bugzilla once the patch is committed into trunk. Normally I leave an empty line after "ChangeLog:" but I'm not sure if it's strictly needed. > gcc/config/ChangeLog: > * i386/mingw-mcfgthread.h: New file > * i386/mingw32.h: Add builtin macro and default libraries for > mcfgthread when thread model is `mcf` Normally I leave a "." for each ChangeLog entry, but I'm not sure if it's strictly needed. However there is no gcc/config/ChangeLog, use gcc/ChangeLog instead. And, from https://gcc.gnu.org/contribute.html#patches: "It is strongly discouraged to post patches as MIME parts of type application/whatever, disposition attachment or encoded as base64 or quoted-printable." Just try "git send-email", it will do the correct thing. Mimicking its behavior in a mail client is also possible but error-prune (the mail client can destroy your patch by replacing your tabs with spaces, etc.) --=20 Xi Ruoyao School of Aerospace Science and Technology, Xidian University