From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 509893858D39 for ; Thu, 9 Nov 2023 20:49:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 509893858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 509893858D39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699562971; cv=none; b=QLpW4n2X6dxk9IU8UUFKlZetUxOegzo9o7BGgB9CwsNYoJ4GKSfDKXzg/OcfC9Vik/Gkv8OfJhvrwr/n3Dz/zjo4OkpWzG2u5YXissl4EYYY+1FMTHTd7lBGJd1vBU9EUH+iiDmgsHyaA5aZMMX2zVXh0am/e0pyAZt12fYEdAM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699562971; c=relaxed/simple; bh=IqQH17G6nzH5uKrFtHLMKaDf1dWEDmQOntTYTcRY7x4=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=U4S0moXgr6c7QIrrTydx9w1YqQ0MCChAM+UAbHmFWDu6dcc/aACEOM3qJ2ZGKyMJI1RVk26ARcbN6pQfA5etKPBl+sCDthURKk+iWlc4n0WnPulBRfJoRTCNigm0xRbpJ1Juxc5F9GV2FXQNHDPG/vqlyfxN6aXEus/avOLrhp8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699562970; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IqQH17G6nzH5uKrFtHLMKaDf1dWEDmQOntTYTcRY7x4=; b=XrqHvlkBpJfarEEOa5qKR0epVnM1SQ7+2vvOVkzWIGFwgkFYmxwIF1wArgAGYF8XPD1t2r 7E0i2FaObGr/sRyb8ArbOM8Z1u2bxHZ7BehhQQhY4C92YZE+b6wkgzoL2jxkO1aZDgYwcd wKfwF5P5rdmXmESPNJVfvtyozddygys= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-249-Tpdqfl4ZOzqsvOtqN4oW4A-1; Thu, 09 Nov 2023 15:49:28 -0500 X-MC-Unique: Tpdqfl4ZOzqsvOtqN4oW4A-1 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-77a033cbd96so145430385a.2 for ; Thu, 09 Nov 2023 12:49:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699562967; x=1700167767; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=IqQH17G6nzH5uKrFtHLMKaDf1dWEDmQOntTYTcRY7x4=; b=NJLpY9R6AL8rQH4psivBIR1B15ihvDbZRXpRYzkCuU/nzDzO1tqsOyYgbGcHu5yUau YuuIQcXRKCiPHOcuIUr3Om8u6FTt75c5jDCWG6CzQRubFX/PcQxPU14iWsn/9t46EZh6 TEUKvlYPTb1vilpIIWI6zeulwyNecjjC1+dsLWWbSrkZNLn4mYddjP1T0iOsLKpLdKu9 YzZvnbgkxYxp+8HWB5CrMqWXXV1mOBgdmjipilDBd8C+ez7j3vy1qMXZMFW6qEMUfR5b XXUZLSLDfrFcMoqQrE02vj4MgZY3z4eT8XErTz36XLUIVj0XLRYNxXPLcDwaE9MDSxBy xegQ== X-Gm-Message-State: AOJu0YzBBBHdJWgOBj21mCmUXyGLl4ZqTvrwo4CY9HIFMncsDz4Zx1/X 5ea529L9pnZMKFfH1NnbW4uquiXSFC4humP59QyfUv7+YmK/LbzLSVtwzkSeefL+kzz646YREKY SOEhQu5O8eLTWo1jgtiZeVUfpTw== X-Received: by 2002:a05:620a:4691:b0:76f:1ead:ddb9 with SMTP id bq17-20020a05620a469100b0076f1eadddb9mr6653229qkb.51.1699562967380; Thu, 09 Nov 2023 12:49:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IFJW7Q1CGa8pfF1d+Di62DXc4w46JCSRAfiwQykOtb1rTcSKwlpVLYNOwVGX0RVyboMbCvYxw== X-Received: by 2002:a05:620a:4691:b0:76f:1ead:ddb9 with SMTP id bq17-20020a05620a469100b0076f1eadddb9mr6653214qkb.51.1699562967153; Thu, 09 Nov 2023 12:49:27 -0800 (PST) Received: from t14s.localdomain (c-76-28-97-5.hsd1.ma.comcast.net. [76.28.97.5]) by smtp.gmail.com with ESMTPSA id h20-20020a05620a285400b00770f3e5618esm180404qkp.101.2023.11.09.12.49.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Nov 2023 12:49:26 -0800 (PST) Message-ID: <8cd36a7829ceb78c8e98d1d268403f9eed121128.camel@redhat.com> Subject: Re: [PATCH] Add missing declaration of get_restrict in C++ interface From: David Malcolm To: Guillaume Gomez , gcc-patches@gcc.gnu.org, jit@gcc.gnu.org, Antoni Date: Thu, 09 Nov 2023 15:49:25 -0500 In-Reply-To: References: User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 2023-11-09 at 21:03 +0100, Guillaume Gomez wrote: > Hi, >=20 > This patch adds the `get_restrict` method declaration for > the C++ interface as it was forgotten. >=20 > Thanks in advance for the review. Looking at my jit.sum results, it looks like the .cc files are indeed FAILing on initial compilation, with errors such as: In file included from gcc/testsuite/jit.dg/test-alignment.cc:4: gcc/testsuite/../jit/libgccjit++.h:1414:1: error: no declaration matches 'g= ccjit::type gccjit::type::get_restrict()' gcc/testsuite/../jit/libgccjit++.h:1414:1: note: no functions named 'gccjit= ::type gccjit::type::get_restrict()' gcc/testsuite/../jit/libgccjit++.h:350:9: note: 'class gccjit::type' define= d here which presumably started with r14-3552-g29763b002459cb. Hence the patch looks good to me - thanks! Does this patch fix those test cases? Dave