From: chenglulu <chenglulu@loongson.cn>
To: Xi Ruoyao <xry111@xry111.site>, YunQiang Su <wzssyqa@gmail.com>
Cc: chenxiaolong <chenxiaolong@loongson.cn>,
gcc-patches@gcc.gnu.org, i@xen0n.name, xuchenghua@loongson.cn,
schwab@linux-m68k.org, ci_notify@linaro.org
Subject: Re: [PATCH v2] LoongArch: testsuite:Added additional vectorization "-mlsx" option.
Date: Mon, 15 Jan 2024 15:26:01 +0800 [thread overview]
Message-ID: <8ce49ac9-c668-ef8a-ef03-1a7b06e5ee8c@loongson.cn> (raw)
In-Reply-To: <7b74e3f09cd083e489850774f2c85079bd470301.camel@xry111.site>
在 2024/1/15 下午2:42, Xi Ruoyao 写道:
> On Mon, 2024-01-15 at 14:32 +0800, YunQiang Su wrote:
>> Xi Ruoyao <xry111@xry111.site> 于2024年1月15日周一 12:11写道:
>>> On Mon, 2024-01-15 at 09:29 +0800, chenxiaolong wrote:
>>>> At 21:13 +0800 on Saturday, 2024-01-13, Xi Ruoyao wrote:
>>>>> At 15:28 +0800 on Saturday 2024-01-13, chenxiaolong wrote:
>>>>>> gcc/testsuite/ChangeLog:
>>>>>>
>>>>>> * gcc.dg/pr104992.c: Added additional "-mlsx" compilation
>>>>>> options.
>>>>>> * gcc.dg/signbit-2.c: Dito.
>>>>>> * gcc.dg/tree-ssa/scev-16.c: Dito.
>>>>>> * gfortran.dg/graphite/vect-pr40979.f90: Dito.
>>>>>> * gfortran.dg/vect/fast-math-mgrid-resid.f: Dito.
>>>>> I don't feel it right about the changes to pr104992.c and scev-16.c
>>>>> because no other architectures add special options there. Why are we
>>>>> so special?
>>>> Because on the LoongArch architecture, GCC requires the addition of
>>>> vectorization options in order to generate vector code. Use the
>>>> check_effective_target_vect_cmdline_needed command in the lib/target-
>>>> supports.exp file to set whether the command line option is needed to
>>>> enable vectorizations. For example, ia64,x86,aarch64, and riscv
>>>> architectures, vectorization is enabled by default.
>>> But no. The default baseline of 32-bit x86 is i686, which is basically
>>> a Pentium III launched in 1999 without any vector instructions.
>>>
>>> We are still missing something here.
>>>
>> There is a line
>> #define vector __attribute__((vector_size(4*sizeof(int))))
>> I guess it is the syntax needs to be supported.
> This is always supported. If the target does not have vector
> instructions GCC will just expand vector arithmetic as a loop.
>
> Maybe we should just move this test into gcc.dg/vect where the framework
> automatically add options like -mlsx or -msse2?
>
The test contents of pr104992.c and scev-16.c are related to vectorization.
It would be great if these two could be moved to the gcc.dg/vect directory,
but we are not sure if this is allowed to be moved.
If it can be moved, how about modifying it in this patch?
prev parent reply other threads:[~2024-01-15 7:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-13 7:28 chenxiaolong
2024-01-13 13:13 ` Xi Ruoyao
2024-01-15 1:29 ` chenxiaolong
2024-01-15 4:10 ` Xi Ruoyao
2024-01-15 6:32 ` YunQiang Su
2024-01-15 6:42 ` Xi Ruoyao
2024-01-15 7:10 ` chenxiaolong
2024-01-15 7:50 ` Xi Ruoyao
2024-01-16 2:57 ` chenxiaolong
2024-01-16 4:58 ` Xi Ruoyao
2024-01-16 9:51 ` Xi Ruoyao
2024-01-16 10:20 ` Richard Biener
2024-01-18 7:15 ` chenglulu
2024-01-18 7:44 ` Xi Ruoyao
2024-01-18 8:49 ` chenglulu
2024-01-18 14:12 ` chenglulu
2024-01-15 7:26 ` chenglulu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ce49ac9-c668-ef8a-ef03-1a7b06e5ee8c@loongson.cn \
--to=chenglulu@loongson.cn \
--cc=chenxiaolong@loongson.cn \
--cc=ci_notify@linaro.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=i@xen0n.name \
--cc=schwab@linux-m68k.org \
--cc=wzssyqa@gmail.com \
--cc=xry111@xry111.site \
--cc=xuchenghua@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).