From: Peter Bergner <bergner@linux.ibm.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: Jeff Law <law@redhat.com>,
Vladimir N Makarov <vmakarov@redhat.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [RFC][PATCH LRA] WIP patch to fix one part of PR87507
Date: Wed, 07 Nov 2018 16:29:00 -0000 [thread overview]
Message-ID: <8ce78db9-485e-478d-fd16-a6e1ff0779e3@linux.ibm.com> (raw)
In-Reply-To: <20181107001402.GH5994@gate.crashing.org>
On 11/6/18 6:14 PM, Segher Boessenkool wrote:
> Or more general, that what is inside the subreg is a reg, because the
> code does rely on that.
I think you mean to beef up the following from:
+ if (HARD_REGISTER_P (nop_reg)
+ && REG_USERVAR_P (nop_reg)
+ && HARD_REGISTER_P (m_reg)
+ && REG_USERVAR_P (m_reg))
+ break;
to:
+ if (REG_P (nop_reg)
+ && HARD_REGISTER_P (nop_reg)
+ && REG_USERVAR_P (nop_reg)
+ && REG_P (m_reg)
+ && HARD_REGISTER_P (m_reg)
+ && REG_USERVAR_P (m_reg))
+ break;
...correct? I can add that. I don't think we need to modify
the other patch hunks, since we know operand_reg[x] is already
a reg.
Peter
next prev parent reply other threads:[~2018-11-07 16:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-19 21:51 Peter Bergner
2018-10-20 6:47 ` Peter Bergner
2018-10-20 21:05 ` Segher Boessenkool
2018-10-22 22:08 ` Jeff Law
2018-10-23 0:25 ` Peter Bergner
2018-10-23 1:16 ` Peter Bergner
2018-10-27 23:25 ` Peter Bergner
2018-11-06 20:28 ` Jeff Law
2018-11-07 0:14 ` Segher Boessenkool
2018-11-07 16:29 ` Peter Bergner [this message]
2018-11-07 17:36 ` Jeff Law
2018-11-07 17:45 ` Peter Bergner
2018-11-08 2:17 ` Peter Bergner
2018-11-08 22:07 ` Jeff Law
2018-11-08 22:42 ` Peter Bergner
2018-10-23 4:54 ` Segher Boessenkool
2018-10-23 6:47 ` Peter Bergner
2018-10-25 0:55 ` Jeff Law
2018-10-20 17:23 ` Segher Boessenkool
2018-10-22 23:23 ` Vladimir Makarov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ce78db9-485e-478d-fd16-a6e1ff0779e3@linux.ibm.com \
--to=bergner@linux.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=law@redhat.com \
--cc=segher@kernel.crashing.org \
--cc=vmakarov@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).