From: Christophe Lyon <christophe.lyon@arm.com>
To: Max Filippov <jcmvbkbc@gmail.com>, gcc-patches@gcc.gnu.org
Cc: Nick Clifton <nickc@redhat.com>,
Richard Earnshaw <richard.earnshaw@arm.com>,
Ramana Radhakrishnan <ramana.gcc@gmail.com>,
Kyrylo Tkachov <kyrylo.tkachov@arm.com>
Subject: Re: [PATCH] libgcc: arm: fix build for FDPIC target
Date: Mon, 25 Mar 2024 11:08:27 +0100 [thread overview]
Message-ID: <8cfae3e9-eead-4ed7-8c56-8619506d473c@arm.com> (raw)
In-Reply-To: <20240322201441.2161826-1-jcmvbkbc@gmail.com>
Hi,
On 3/22/24 21:14, Max Filippov wrote:
> libgcc/
> * unwind-arm-common.inc (__gnu_personality_sigframe_fdpic): Cast
> last argument of _Unwind_VRS_Set to void *.
> ---
> libgcc/unwind-arm-common.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libgcc/unwind-arm-common.inc b/libgcc/unwind-arm-common.inc
> index 5453f38186b5..576f7e93e8a8 100644
> --- a/libgcc/unwind-arm-common.inc
> +++ b/libgcc/unwind-arm-common.inc
> @@ -248,7 +248,7 @@ __gnu_personality_sigframe_fdpic (_Unwind_State state,
> + ARM_SIGCONTEXT_R0;
> /* Restore regs saved on stack by the kernel. */
> for (i = 0; i < 16; i++)
> - _Unwind_VRS_Set (context, _UVRSC_CORE, i, _UVRSD_UINT32, sp + 4 * i);
> + _Unwind_VRS_Set (context, _UVRSC_CORE, i, _UVRSD_UINT32, (void *)(sp + 4 * i));
LGTM (but I'm not a maintainer).
Thanks,
Christophe
>
> return _URC_CONTINUE_UNWIND;
> }
next prev parent reply other threads:[~2024-03-25 10:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 20:14 Max Filippov
2024-03-25 10:08 ` Christophe Lyon [this message]
2024-03-25 18:23 ` Max Filippov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8cfae3e9-eead-4ed7-8c56-8619506d473c@arm.com \
--to=christophe.lyon@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jcmvbkbc@gmail.com \
--cc=kyrylo.tkachov@arm.com \
--cc=nickc@redhat.com \
--cc=ramana.gcc@gmail.com \
--cc=richard.earnshaw@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).