From: "Andre Vieira (lists)" <andre.simoesdiasvieira@arm.com>
To: gcc-patches@gcc.gnu.org
Cc: Richard.Sandiford@arm.com, Jakub@redhat.com, kyrylo.tkachov@arm.com
Subject: [PATCHv2 1/2] aarch64: Do not give ABI change diagnostics for _BitInt(N)
Date: Wed, 27 Mar 2024 18:29:59 +0000 [thread overview]
Message-ID: <8d2380b8-4f62-42c8-b6ed-9c6021a4ef32@arm.com> (raw)
In-Reply-To: <a7d49d0a-6771-4fb8-b524-f6fc2d34b872@arm.com>
[-- Attachment #1: Type: text/plain, Size: 355 bytes --]
This patch makes sure we do not give ABI change diagnostics for the ABI
breaks of GCC 9, 13 and 14 for any type involving _BitInt(N), since that
type did not exist before this GCC version.
ChangeLog:
* config/aarch64/aarch64.cc (bitint_or_aggr_of_bitint_p): New function.
(aarch64_layout_arg): Don't emit diagnostics for types involving
_BitInt(N).
[-- Attachment #2: aarch64_bitint1v2.patch --]
[-- Type: text/plain, Size: 3789 bytes --]
diff --git a/gcc/config/aarch64/aarch64.cc b/gcc/config/aarch64/aarch64.cc
index 1ea84c8bd7386e399f6ffa3a5e36408cf8831fc6..b68cf3e7cb9a6fa89b4e5826a39ffa11f64ca20a 100644
--- a/gcc/config/aarch64/aarch64.cc
+++ b/gcc/config/aarch64/aarch64.cc
@@ -6744,6 +6744,33 @@ aarch64_function_arg_alignment (machine_mode mode, const_tree type,
return alignment;
}
+/* Return true if TYPE describes a _BitInt(N) or an angreggate that uses the
+ _BitInt(N) type. These include ARRAY_TYPE's with an element that is a
+ _BitInt(N) or an aggregate that uses it, and a RECORD_TYPE or a UNION_TYPE
+ with a field member that is a _BitInt(N) or an aggregate that uses it.
+ Return false otherwise. */
+
+static bool
+bitint_or_aggr_of_bitint_p (tree type)
+{
+ if (!type)
+ return false;
+
+ if (TREE_CODE (type) == BITINT_TYPE)
+ return true;
+
+ /* If ARRAY_TYPE, check it's element type. */
+ if (TREE_CODE (type) == ARRAY_TYPE)
+ return bitint_or_aggr_of_bitint_p (TREE_TYPE (type));
+
+ /* If RECORD_TYPE or UNION_TYPE, check the fields' types. */
+ if (RECORD_OR_UNION_TYPE_P (type))
+ for (tree field = TYPE_FIELDS (type); field; field = TREE_CHAIN (field))
+ if (bitint_or_aggr_of_bitint_p (TREE_TYPE (field)))
+ return true;
+ return false;
+}
+
/* Layout a function argument according to the AAPCS64 rules. The rule
numbers refer to the rule numbers in the AAPCS64. ORIG_MODE is the
mode that was originally given to us by the target hook, whereas the
@@ -6767,12 +6794,6 @@ aarch64_layout_arg (cumulative_args_t pcum_v, const function_arg_info &arg)
if (pcum->aapcs_arg_processed)
return;
- bool warn_pcs_change
- = (warn_psabi
- && !pcum->silent_p
- && (currently_expanding_function_start
- || currently_expanding_gimple_stmt));
-
/* HFAs and HVAs can have an alignment greater than 16 bytes. For example:
typedef struct foo {
@@ -6907,6 +6928,18 @@ aarch64_layout_arg (cumulative_args_t pcum_v, const function_arg_info &arg)
&& (!alignment || abi_break_gcc_9 < alignment)
&& (!abi_break_gcc_13 || alignment < abi_break_gcc_13));
+
+ bool warn_pcs_change
+ = (warn_psabi
+ && !pcum->silent_p
+ && (currently_expanding_function_start
+ || currently_expanding_gimple_stmt)
+ /* warn_pcs_change is currently used to gate diagnostics in case of
+ abi_break_gcc_{9,13,14}. These however, do not apply to _BitInt(N)
+ types as they were only introduced in GCC 14. */
+ && (!type || !bitint_or_aggr_of_bitint_p (type)));
+
+
/* allocate_ncrn may be false-positive, but allocate_nvrn is quite reliable.
The following code thus handles passing by SIMD/FP registers first. */
@@ -21266,19 +21299,25 @@ aarch64_gimplify_va_arg_expr (tree valist, tree type, gimple_seq *pre_p,
rsize = ROUND_UP (size, UNITS_PER_WORD);
nregs = rsize / UNITS_PER_WORD;
- if (align <= 8 && abi_break_gcc_13 && warn_psabi)
+ if (align <= 8
+ && abi_break_gcc_13
+ && warn_psabi
+ && !bitint_or_aggr_of_bitint_p (type))
inform (input_location, "parameter passing for argument of type "
"%qT changed in GCC 13.1", type);
if (warn_psabi
&& abi_break_gcc_14
- && (abi_break_gcc_14 > 8 * BITS_PER_UNIT) != (align > 8))
+ && (abi_break_gcc_14 > 8 * BITS_PER_UNIT) != (align > 8)
+ && !bitint_or_aggr_of_bitint_p (type))
inform (input_location, "parameter passing for argument of type "
"%qT changed in GCC 14.1", type);
if (align > 8)
{
- if (abi_break_gcc_9 && warn_psabi)
+ if (abi_break_gcc_9
+ && warn_psabi
+ && !bitint_or_aggr_of_bitint_p (type))
inform (input_location, "parameter passing for argument of type "
"%qT changed in GCC 9.1", type);
dw_align = true;
next prev parent reply other threads:[~2024-03-27 18:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-25 17:44 [PATCH 0/2] aarch64, bitint: Add support for _BitInt for AArch64 Little Endian Andre Vieira
2024-01-25 17:45 ` [PATCH 1/2] bitint: Use TARGET_ARRAY_MODE for large bitints where target supports it Andre Vieira
2024-02-02 15:18 ` Jakub Jelinek
2024-01-25 17:45 ` [PATCH 2/2] aarch64: Add support for _BitInt Andre Vieira
2024-01-25 19:40 ` Richard Sandiford
2024-02-02 14:46 ` Jakub Jelinek
2024-02-27 13:40 ` Andre Vieira (lists)
2024-02-28 11:19 ` Jakub Jelinek
2024-03-07 17:59 ` Richard Sandiford
2024-03-27 18:24 ` [PATCHv2 0/2] aarch64, bitint: Add support for _BitInt for AArch64 Little Endian Andre Vieira (lists)
2024-03-27 18:29 ` Andre Vieira (lists) [this message]
2024-03-28 12:54 ` [PATCHv2 1/2] aarch64: Do not give ABI change diagnostics for _BitInt(N) Richard Sandiford
2024-04-10 9:16 ` Andre Vieira (lists)
2024-04-10 10:24 ` Richard Sandiford
2024-03-27 18:31 ` [PATCHv2 2/2] aarch64: Add support for _BitInt Andre Vieira (lists)
2024-03-28 15:00 ` Richard Sandiford
2024-03-28 15:03 ` Jakub Jelinek
2024-03-28 15:21 ` Richard Sandiford
2024-04-10 9:17 ` [PATCHv3 " Andre Vieira (lists)
2024-04-10 10:27 ` Richard Sandiford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d2380b8-4f62-42c8-b6ed-9c6021a4ef32@arm.com \
--to=andre.simoesdiasvieira@arm.com \
--cc=Jakub@redhat.com \
--cc=Richard.Sandiford@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kyrylo.tkachov@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).