From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18827 invoked by alias); 28 Sep 2017 06:47:34 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 18813 invoked by uid 89); 28 Sep 2017 06:47:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy= X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 28 Sep 2017 06:47:32 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-MBX-04.mgc.mentorg.com) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1dxSbZ-0001iS-2L from Tom_deVries@mentor.com ; Wed, 27 Sep 2017 23:47:29 -0700 Received: from [127.0.0.1] (137.202.0.87) by SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) with Microsoft SMTP Server (TLS) id 15.0.1263.5; Thu, 28 Sep 2017 07:47:24 +0100 To: Jakub Jelinek CC: Thomas Schwinge , GCC Patches From: Tom de Vries Subject: [openacc, testsuite, committed] Fix libgomp.oacc-c-c++-common/loop-g-{1,2}.c for non-nvidia devices Message-ID: <8d323e0d-9790-2fc0-3ea4-2ae73a7c3064@mentor.com> Date: Thu, 28 Sep 2017 06:47:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------3BC950F12EECBEB52E321164" X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) X-SW-Source: 2017-09/txt/msg01849.txt.bz2 --------------3BC950F12EECBEB52E321164 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-length: 562 Hi, this patch makes the test-cases libgomp.oacc-c-c++-common/loop-g-{1,2}.c work for non-nvidia devices. For nvidia devices, a vector_length of 32 is required for the test to pass. For devices with a non-32 forced vector_length, this test-case will fail the test for excess errors due to: ... warning: using vector_length (x), ignoring 32 ... Fixed by removing the explicit vector_length setting. For nvidia devices, 32 is required, but that's also the forced default, so there's no need to be explicit about it. Committed as obvious. Thanks, - Tom --------------3BC950F12EECBEB52E321164 Content-Type: text/x-patch; name="0001-Fix-libgomp.oacc-c-c-common-loop-g-1-2-.c-for-non-nvidia-devices.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename*0="0001-Fix-libgomp.oacc-c-c-common-loop-g-1-2-.c-for-non-nvidi"; filename*1="a-devices.patch" Content-length: 1620 Fix libgomp.oacc-c-c++-common/loop-g-{1,2}.c for non-nvidia devices 2017-09-28 Tom de Vries * testsuite/libgomp.oacc-c-c++-common/loop-g-1.c (main): Remove vector_length(32) clause from acc parallel directive. * testsuite/libgomp.oacc-c-c++-common/loop-g-2.c (main): Same. --- libgomp/testsuite/libgomp.oacc-c-c++-common/loop-g-1.c | 2 +- libgomp/testsuite/libgomp.oacc-c-c++-common/loop-g-2.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libgomp/testsuite/libgomp.oacc-c-c++-common/loop-g-1.c b/libgomp/testsuite/libgomp.oacc-c-c++-common/loop-g-1.c index 7bff6cd..ae1d588 100644 --- a/libgomp/testsuite/libgomp.oacc-c-c++-common/loop-g-1.c +++ b/libgomp/testsuite/libgomp.oacc-c-c++-common/loop-g-1.c @@ -15,7 +15,7 @@ int main () for (ix = 0; ix < N;ix++) ary[ix] = -1; -#pragma acc parallel num_gangs(32) vector_length(32) copy(ary) copy(ondev) +#pragma acc parallel num_gangs(32) copy(ary) copy(ondev) { #pragma acc loop gang for (unsigned ix = 0; ix < N; ix++) diff --git a/libgomp/testsuite/libgomp.oacc-c-c++-common/loop-g-2.c b/libgomp/testsuite/libgomp.oacc-c-c++-common/loop-g-2.c index 92b82a0..c06d861 100644 --- a/libgomp/testsuite/libgomp.oacc-c-c++-common/loop-g-2.c +++ b/libgomp/testsuite/libgomp.oacc-c-c++-common/loop-g-2.c @@ -15,7 +15,7 @@ int main () for (ix = 0; ix < N;ix++) ary[ix] = -1; -#pragma acc parallel num_gangs(32) vector_length(32) copy(ary) copy(ondev) +#pragma acc parallel num_gangs(32) copy(ary) copy(ondev) { #pragma acc loop gang (static:1) for (unsigned ix = 0; ix < N; ix++) --------------3BC950F12EECBEB52E321164--