From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by sourceware.org (Postfix) with ESMTPS id 631E73858D1E for ; Sun, 9 Apr 2023 00:25:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 631E73858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x1033.google.com with SMTP id h24-20020a17090a9c1800b002404be7920aso1418301pjp.5 for ; Sat, 08 Apr 2023 17:25:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680999934; x=1683591934; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=OEPoavsB7dHV6tPUcNp5n0Xuv2FH5CDEGIVcnjeCf/0=; b=fwEyd3Sk4BRlKYCHty7wH1tFPQzeY/LVRfoNpW44COO9BpiZAM7Wuev7RNa5pExFT5 /o0rydMafQmk7LFyxMoIpit7ufujKyTOLxFYltbvxLsjFOYzX7JYPGgaJQOyOPxU0ePB 9JEa1lxeS14NovGRm/b2IXtVUPvx0+2g1XxCBpO48x71Io0OVN2oX/ySQHdJ6vthDJ7V rgK9nTxNq+xJzHUntuEpEdWWoUvsmK9dRzHm9eawP2e46Qf/oakAOHNm2Lan89S22sKD 86aXfCDnAeashA79uGFz2sOWrsHg43Wi8F8xVFNTq6ALEEnYHNgp/UKVmlYHQ+k8kDzv T7vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680999934; x=1683591934; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OEPoavsB7dHV6tPUcNp5n0Xuv2FH5CDEGIVcnjeCf/0=; b=YFfexxKdOUkJDJz6+gq+Rhew/5yoi7BnBqgNEp0kZRzns1/1JJzDvbSz8DqvePaV2o 79KOD+nsA3u1J4rMwMExGNawuBbVeDQtBoenJezra+LB05eDXJPeS8ELAqlVXNHE8gCc tDNqjPRU+2Yy5gLcRMwc4QdoGi3MfdapqrdpBFCFTwBNgcrP7nKEIj5JIVXP0+P2slI7 EgkZlYe86Vb9pNnGQ+wkPU/GkzRmj5H50fvnWGfIh0uTwwWSDWrJaXDhywR5txVwhG5c R2efNq5kkfsMaoCLrxodAQJIoU/k/1bi+Wnt1MXlT+UfAyI8xTQwmipJpU9mQHLg8OKv B8TQ== X-Gm-Message-State: AAQBX9fYf9V3m19D78TsqMQTV0jETs3CUN/S5Kv5q/MHfU4v4XQMHPuF MRO0jqVvHgYOlC6+tFJhmaQ= X-Google-Smtp-Source: AKy350ZA7pLupRwBsBcwLXf3T7D6L+MVE+hOA29PHdUL7CMIYIakwUE4rl0Nffm7kJaLQ1u/pV9c4Q== X-Received: by 2002:a17:902:c74a:b0:19e:665b:2514 with SMTP id q10-20020a170902c74a00b0019e665b2514mr3278692plq.43.1680999933911; Sat, 08 Apr 2023 17:25:33 -0700 (PDT) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id h4-20020a170902748400b001a52eadb3e1sm871841pll.152.2023.04.08.17.25.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 08 Apr 2023 17:25:33 -0700 (PDT) Message-ID: <8d3c3861-c291-e762-a2a8-0b520f39a7e3@gmail.com> Date: Sat, 8 Apr 2023 18:25:32 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH] combine: Fix simplify_comparison AND handling for WORD_REGISTER_OPERATIONS targets [PR109040] Content-Language: en-US To: Eric Botcazou , Jakub Jelinek Cc: gcc-patches@gcc.gnu.org, Richard Biener , Richard Sandiford References: <2220543.iZASKD2KPV@fomalhaut> <3412470.QJadu78ljV@fomalhaut> From: Jeff Law In-Reply-To: <3412470.QJadu78ljV@fomalhaut> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/6/23 08:21, Eric Botcazou wrote: >> So, perhaps just in the return op0; case add further code for >> WORD_REGISTER_OPERATIONS and sub-word modes which will call nonzero_bits >> again for the word mode and decide if it is still safe. > > Does it work to just replace mode by word_mode in the calls to nonzero_bits? It helps marginally -- basically we defer mucking up the code a bit. We then hit this in simplify_and_const_int_1: /* See what bits may be nonzero in VAROP. Unlike the general case of a call to nonzero_bits, here we don't care about bits outside MODE. */ nonzero = nonzero_bits (varop, mode) & GET_MODE_MASK (mode); That just seems wrong for WORD_REGISTER_OPERATIONS targets. Hacking both locations in a similar manner fixes the test. jeff