From: Andreas Krebbel <krebbel@linux.ibm.com>
To: Jeff Law <law@redhat.com>, Eric Botcazou <ebotcazou@adacore.com>,
Richard Biener <richard.guenther@gmail.com>,
Jakub Jelinek <jakub@redhat.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Andreas Krebbel <krebbel@linux.vnet.ibm.com>
Subject: Re: [PATCH] PR86844: Fix for store merging
Date: Mon, 10 Sep 2018 14:06:00 -0000 [thread overview]
Message-ID: <8d5e4bd1-e42b-111e-29d2-67a5206ba315@linux.ibm.com> (raw)
In-Reply-To: <a27ea6eb-cee6-c84b-0241-5bc67f228725@redhat.com>
On 20.08.2018 16:30, Jeff Law wrote:
> On 08/18/2018 03:20 AM, Eric Botcazou wrote:
>>> Eric, didn't your patches explicitely handle this case of a non-constant
>>> inbetween?
>>
>> Only if there is no overlap at all, otherwise you cannot do things simply.
>>
>>> Can you have a look / review here?
>>
>> Jakub is probably more qualified to give a definitive opinion, as he wrote
>> check_no_overlap and the bug is orthogonal to my patches since it is present
>> in 8.x; in any case, all transformations are supposed to be covered by the
>> testsuite.
> FYI. Jakub is on PTO through the end of this week and will probably be
> buried when he returns.
Jakub, could you please have a look whether that's the right fix?
https://gcc.gnu.org/ml/gcc-patches/2018-08/msg00474.html
Andreas
next prev parent reply other threads:[~2018-09-10 14:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-07 11:35 Andreas Krebbel
2018-08-17 13:50 ` Richard Biener
2018-08-18 9:20 ` Eric Botcazou
2018-08-20 14:30 ` Jeff Law
2018-09-10 14:06 ` Andreas Krebbel [this message]
2018-09-10 17:53 ` Jakub Jelinek
2018-09-11 14:06 ` Andreas Krebbel
2018-09-12 8:54 ` [PATCH] Fix store merging (PR tree-optimization/86844) Jakub Jelinek
2018-09-12 9:04 ` Richard Biener
2018-09-12 9:11 ` Jakub Jelinek
2018-09-12 11:02 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d5e4bd1-e42b-111e-29d2-67a5206ba315@linux.ibm.com \
--to=krebbel@linux.ibm.com \
--cc=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=krebbel@linux.vnet.ibm.com \
--cc=law@redhat.com \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).